Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file25632/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file25705/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file25562/test_calendar.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
I didn't event know that there is such a handy assertRaisesRegex context.
Many thanks for pointing this out!
--
Added file: http://bugs.python.org/file25632/test_calendar.patch
___
Python tracker
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
I've improved calendar.py test coverage a bit.
Before:
41071% calendar (.../Lib/calendar.py)
After:
41077% calendar (.../Lib/calendar.py)
--
components: Tests
files: test_calendar.patch
keywords: patch
messages
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Thanks for the review.
I'll happily tune the patch myself. Just when I have some spare time again.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14796
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
For convenience I have uploaded the separate patch without warnings. Which
means that it will generate some output during tests run.
--
Added file: http://bugs.python.org/file24691/test_aifc_3_2.patch
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24691/test_aifc_3_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file24692/test_aifc_3_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24605/test_fractions.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14089
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file24630/test_fractions.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14089
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
The last few missing bits to complete test coverage of 'fractions.py' library.
./python.exe -E -Wd -m test -v -T -D ../coverage/test_fractions test_fractions
lines cov% module (path)
270 100% fractions
(/Users/family
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24285/audioop_size_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13806
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Yes, that tests really should be there too. Added them to patch.
--
Added file: http://bugs.python.org/file24344/audioop_size_check.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24260/audioop_size_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13806
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Yep, you're right. Didn't noticed audioop_check_size() function at first.
The fact that audioop accepts unicode strings seems weird to me too. I've
replaced strings with bytes in tests. However, I'm afraid to add restrictions
to library
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24284/audioop_size_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13806
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file24285/audioop_size_check.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13806
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
I have absolutely no idea :-)
I just covered every line of code with tests. Some bugs prevented me from do
it, so I fixed them.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
According to documentation (http://docs.python.org/library/audioop.html),
adpcm2lin, alaw2lin and ulaw2lin are using 'width' argument to represent output
frames width. However, in audioop.c module there are checks that are raising
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file24112/aifc_compression.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13681
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Ok, I have opened issue 13806 with audioop fix alone. However, I cannot change
current issue's dependencies to reflect that current issue depends on issue
13806. Could anyone do this for me please?
--
Added file: http
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
Two changes have been made to the library:
1. Lowercase compression type support have been added to the sample width
validation routine during write operation. Everywhere else compression types
are used in both lowercase and uppercase.
2
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Fourth patch goes to issue 13680
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
This patch resolves two issues:
1. ADPCM compressed audio files reading. Such files have frame size of 4 bits.
Aifc lib cannot represent 4 bits frame size because it uses integer bytes count
variable. I have replaced it with bits count
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
I have put changes to both aifc and audioop module in this single patch. The
reason is that aifc test reading compressed frames will work properly only
after audioop fix has been applied
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
The last, fifth, patch goes to issue 13681
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
1. Markers serialization test coverage improved.
2. Marker name changed from string to bytes, because _write_string function
uses bytes.
3. Check for closed file handle moved to 'close' method, because otherwise I
caught 'attempt
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23934/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
The split is in progress. There will be at least two more patches.
Regarding your comments:
1) Sorry for my english :-) It is fully determined by the input. With this
particular test input the assertNotEqual will always pass. So I've removed
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Third patch goes to issue 13594
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23734/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Sounds perfectly reasonable. Here goes the first patch with pure test coverage.
--
Added file: http://bugs.python.org/file23931/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
1. Fixed _write_float to handle infinity, NaN and negative numbers correctly.
2. Renamed _write_long to _write_ulong because it actually writes unsigned
value.
3. Added _read_ushort as counterpart of _write_ushort. This is never used
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Patch must be applied after http://bugs.python.org/file23931/test_aifc.patch
from issue 13394.
Not sure if review tool can handle this correctly.
--
___
Python tracker rep...@bugs.python.org
http
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Second patch goes to issue 13589
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Second patch goes to issue 13589
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
___
___
Python-bugs-list
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23931/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file23934/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Forget about patch must be applied before thing.
I've made independent patch. :-)
--
Added file: http://bugs.python.org/file23935/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23932/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23935/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file23939/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23939/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Added file: http://bugs.python.org/file23940/aifc_numbers_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
title: Aifc float serialization fix - Aifc low level serialization primitives
fix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13589
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
title: Patch to increase aifc lib test coverage with couple of minor fixes -
Patch to increase aifc lib test coverage
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23678/test_aifc2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
1. Test coverage increased to 95%.
2. G722 compressed files reading in aifc.py fixed (it used to use 0 bytes frame
size).
3. audioop's ulaw2lin, alaw2lin and adpcm2lin length checks fixed (width should
be used for output only, because input
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23677/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Minor style fixes
--
Added file: http://bugs.python.org/file23734/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
Removed file: http://bugs.python.org/file23733/test_aifc.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13394
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
I got following error when trying to delete outdated patch set:
Environment:
Request Method: POST
Request URL: http://bugs.python.org/review/13394/patchset/3680/delete
Django Version: 1.1.1 SVN-17047
Python Version: 2.5.2
Installed
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Thanks for your review, Ezio!
Here goes new patch with all issues you've mentioned been fixed.
--
Added file: http://bugs.python.org/file23678/test_aifc2.patch
___
Python tracker rep
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
I've increased coverage of aifc.py by test_aifc.py:
before:
[1/1] test_aifc
lines cov% module (path)
56063% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py)
...
after:
[1/1] test_aifc
lines cov% module
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Thank you all for help. I finally managed to build it. :-)
So here are complete steps I've taken to build python after OS reinstall:
1. Install XCode 4.2
2. Install MacPorts
3. sudo port -v selfupdate
4. sudo port install gcc46
5. ./configure
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
resolution: - works for me
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13241
___
___
Python
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13241
___
___
Python-bugs
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
resolution: works for me - fixed
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13241
Changes by Oleg Plakhotnyuk oleg...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13241
___
___
Python-bugs
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Ah, of course.
Initially I've tried to compile using this:
i686-apple-darwin10-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658)
(LLVM build 2336.1.00)
XCode version 4.2, build 4C199
New submission from Oleg Plakhotnyuk oleg...@gmail.com:
Trying to build latest development revision:
localhost:repo family$ hg summary
parent: 73044:a985d733b3a3 tip
#12753: Add support for Unicode name aliases and named sequences.
branch: default
commit: (clean)
update: (current)
Constantly
Oleg Plakhotnyuk oleg...@gmail.com added the comment:
Oh yes.
I am building with this command line:
./configure --with-pydebug make -j2
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13241
64 matches
Mail list logo
