Pablo Galindo Salgado added the comment:
New changeset 9d8a64a7ccebb288094d4e9da66f30d2ada9a973 by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-45024 and bpo-23864: Document how interface testing works with the
collections ABCs (GH-28218) (GH-28266)
https://github.com/python
Pablo Galindo Salgado added the comment:
New changeset 39c4fe5e2b2ae5ac45c380b0a83e86bac3d7129c by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-44640: Improve punctuation consistency in isinstance/issubclass error
messages (GH-27144) (GH-28436)
https://github.com/python
Pablo Galindo Salgado added the comment:
New changeset 84d56ec4bc0cb44629ba898a30eece48546828d2 by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-42038: fix description of returned list of lines (GH-27529) (GH-28428)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset f025ea23210173b42303360aca05132e4ffdfed3 by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-30637: Improve the docs of ast.parse regarding differences with compile()
(GH-28459)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset b1873d1e24ed5ef39f37ca3090c2f0c2b34ce23f by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-9811: [doc] strftime handling of unsupported format specifiers is platform
dependent (GH-28264) (GH-28277)
https://github.com/python
Pablo Galindo Salgado added the comment:
New changeset 7f2d049cce6dc749a589424d4fb62ffca0b85b32 by Pablo Galindo (Miss
Islington (bot)) in branch '3.10':
bpo-45193: Restore IDLE completion boxes on Ubuntu (GH-28343)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset a25dcaefb7c4eb0767a112cd31fe0b055f168844 by Pablo Galindo Salgado
in branch 'main':
bpo-45350: Rerun autoreconf with the pkg-config macros (GH-28708)
https://github.com/python/cpython/commit/a25dcaefb7c4eb0767a112cd31fe0b055f168844
Pablo Galindo Salgado added the comment:
New changeset f146ca36f81075f222aa3a1595042597d96dfad3 by Pablo Galindo Salgado
in branch '3.10':
bpo-45350: Rerun autoreconf with the pkg-config macros (GH-28707)
https://github.com/python/cpython/commit/f146ca36f81075f222aa3a1595042597d96dfad3
Pablo Galindo Salgado added the comment:
Something seems wrong with the openssl detection when the PKG_PROG_PKG_CONFIG
is active :(
Christian, could you please take a look? I would like to get this ready for the
release
--
___
Python tracker
Change by Pablo Galindo Salgado :
--
pull_requests: +27060
pull_request: https://github.com/python/cpython/pull/28708
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +27059
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28707
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Created a PR for this:
https://github.com/pablogsal/cpython_autoconf/pull/1
I think we should move this dockerfile to the CPython repo and update the
devguide.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
Ah, the problem is that pkgconfig is *not* installed in that DOckerfile. I can
confirm that installing pkg-config and rerunning works.
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
I can confirm that running autoreconf with Christian's version doesn't change
the git tree:
❯ docker run -v`pwd`:/src tiran/cpython_autoconf
Rebuilding configure script
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
Pablo Galindo Salgado added the comment:
This runs:
"autoreconf -ivf"
with the correct version of autotools required by the openssl changes
--
___
Python tracker
<https://bugs.python.o
Pablo Galindo Salgado added the comment:
For regeneration I was using:
https://github.com/tiran/cpython_autoconf
as instructed by Christian.
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
Regarding preventing this, I have added a check so the autotools version
doesn't get updated incorrectly:
https://github.com/python/cpython/pull/28152
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
> it appears to have been inadvertently deleted in
> 2fc857a5721a5b42bcb696c9cae1bbcc82a91b17 (PR 25860) probably due to an
> autoconf version mismatch.
Since then, I have updated the autotools version to the old one in
https://github.c
Pablo Galindo Salgado added the comment:
We use a pinned version of pyperformance so the code has not changed. I need to
manually bump the version and when they happens I wipe all previous benchmarks
--
nosy: +pablogsal -vstinner
title: speed.python.org: dulwich_log performance
Change by Pablo Galindo Salgado :
--
components: -Parser
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue45334>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
New changeset b07fddd527efe67174ce6b0fdbe8dac390b16e4e by Pablo Galindo Salgado
in branch 'main':
Revert "bpo-45229: Make datetime tests discoverable (GH-28615)" (GH-28650)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +27018
pull_request: https://github.com/python/cpython/pull/28650
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
> Seems this is not a new bug:
I agree, is unfortunate. But sadly is breaking all buildbots and therefore is
hiding other issues and making the 'test-with-buildbots' label not useful. I
would prefer to revert until we have a fix (and not l
Pablo Galindo Salgado added the comment:
> But I am not in strict opposition against this feature. It is just that I
> have fixed so many bugs, that I try to search potential flaws and drawbacks
> in any new feature. Now you know about this, and you can decide whether the
Pablo Galindo Salgado added the comment:
Unfortunately, this PR28615 seems to have broken a bunch of buildbots. For
instance:
https://buildbot.python.org/all/#/builders/75/builds/172/steps/5/logs/stdio
```
test_divide_and_round (test.datetimetester.TestModule_Pure) ... ok
Pablo Galindo Salgado added the comment:
> My concern is that such feature can provoke bugs. The risk can exceed the
> minor benefit.
But isn't that risk the same for other formatting parameters?
--
___
Python tracker
<https://bugs.p
Pablo Galindo Salgado added the comment:
You can see how is implemented on am64 for example here:
https://blog.nelhage.com/2010/10/amd64-and-va_arg/
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
I concur with Terry, ending a file with *is* a syntax
error.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg402911
___
Python tracker
<https://bugs.python.org/issue42813>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
I concur
--
___
Python tracker
<https://bugs.python.org/issue42813>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
The va_start macro just sets up a pointer to the first function parameter,
e.g.:-
void func (int a, ...)
{
// va_start
char *p = (char *) + sizeof a;
}
which makes p point to the second parameter. The va_arg macro does this:-
void func
Pablo Galindo Salgado added the comment:
> There was no much need of this feature. In rare cases when we needed to build
> a bool in Py_BuildValue (I have found only 2 cases in the stdlib, and one of
> them is added by me) we use the following idiom:
Is true that this is not ve
Pablo Galindo Salgado added the comment:
> Either create a new draft PR, or put it in the same PR 28634.
I prefer to reach an agreement first here before I add more things to the PR
--
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +27003
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28634
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
We should allow Py_BuildValue to take a "p" argument that takes a C int and
produces a Python Bool so it would be symmetric with the p format code for
PyArg_Parse that takes a Python object and returns a C int containing
PyObject_
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> IMO, we should note in What's New that only for Windows, 3.10.0 has a slight
> slowdown.
I disagree. This is a regression/bug and we don't advertise "known bugs" in the
what's new, the same for any other bugfix that has been dela
Pablo Galindo Salgado added the comment:
> I have another fix.
If you have another fix, please create a PR ASAN and get it reviewed and merged
by a core dev in the next 24 hours, otherwise it will need to wait until 3.10.1
--
___
Python trac
Pablo Galindo Salgado added the comment:
Ah, that is likely because type_getsets now gets directly an __annotations__
field.
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
New changeset 6c1154b9de29e1c9cd3d05f5289543e5cff73895 by Pablo Galindo Salgado
in branch 'main':
bpo-44394: Ensure libexpat is linked against libm (GH-28617)
https://github.com/python/cpython/commit/6c1154b9de29e1c9cd3d05f5289543e5cff73895
Pablo Galindo Salgado added the comment:
The changelog says now:
bpo-44559: [Enum] module reverted to 3.9; 3.10 changes pushed until 3.11
(https://docs.python.org/3.10/whatsnew/changelog.html#id9)
Please, feel free to reopen if we are missing anything
--
resolution: -> fixed
st
Pablo Galindo Salgado added the comment:
If you want a potential fix to be included in 3.10.0 it must be commited in the
next 24/48 hours, otherwise it will need to wait for 3.10.1
--
nosy: -petr.viktorin, vstinner
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
pull_requests: +26988
pull_request: https://github.com/python/cpython/pull/28617
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Christian, could you bisect using your reproducer?
--
___
Python tracker
<https://bugs.python.org/issue45319>
___
___
Pablo Galindo Salgado added the comment:
This means that if anyone wants to pursue the 4% that is left the fix must be
committed within 24 hours.
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I'm landing PR 28475 for now as it improves the situation from 7% to 4%
slowdown and is contained enough.
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
If someone wants this issue to be solved in 3.10.0 it must be resolved ASAP. I
am going to start freezing the release branch in one day or two to start
testing the final candidate as much as possible so this issue has 24h at max to
be merged
Pablo Galindo Salgado added the comment:
I will prepare a PR to also document the gdb helpers in the main docs. The wiki
is insuficient.
--
assignee: Mark.Shannon -> pablogsal
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue45316>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
The backport to 3.8 broke 3.8.12 in AIX:
0/Modules/_decimal/libmpdec/sixstep.o
build/temp.aix-7.1-3.8/tmp/python3.8-3.8.12-0/Modules/_decimal/libmpdec/transpose.o
-L. -L/opt/bb/lib -L/opt/bb/lib64 -R/opt/bb/lib64 -lm -o
build/lib.aix-7.1-3.8
Pablo Galindo Salgado added the comment:
> I don't understand which long term solution do you propose.
A kind reminder that for 3.10 we cannot add new APIs so this proposal still
*makes sense* for the short term (3.10).
--
___
Python trac
Pablo Galindo Salgado added the comment:
New changeset 84975146a7ce64f1d50dcec8311b7f7188a5c962 by Pablo Galindo Salgado
in branch 'main':
bpo-35606: Fix math.prod tests using 'start' as keyword parameter (GH-28595)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
We are starting to optimize first the easy cases of CALL_FUNCTION and move
slowly to add more and more calls into it. This approach has the advantage that
allow us to take it in small increments
Change by Pablo Galindo Salgado :
--
pull_requests: +26975
pull_request: https://github.com/python/cpython/pull/28595
___
Python tracker
<https://bugs.python.org/issue35
Pablo Galindo Salgado added the comment:
New changeset 20f439b6b9e1032930a31b88694ab9f37a09e6b4 by Pablo Galindo Salgado
in branch 'main':
bpo-45249: Ensure the traceback module prints correctly syntax errors with
ranges (GH-28575)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset e5f13ce5b48b551c09fdd0faeafa6ecf860de51c by Pablo Galindo Salgado
in branch 'main':
bpo-43914: Correctly highlight SyntaxError exceptions for invalid generator
expression in function calls (GH-28576)
https://github.com/python/cpython
Change by Pablo Galindo Salgado :
--
pull_requests: +26959
pull_request: https://github.com/python/cpython/pull/28576
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
pull_requests: +26958
pull_request: https://github.com/python/cpython/pull/28575
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
New changeset 7b88f63e1dd4006b1a08b9c9f087dd13449ecc76 by Erlend Egeberg
Aasland in branch 'main':
bpo-44958: Revert GH-27844 (GH-28574)
https://github.com/python/cpython/commit/7b88f63e1dd4006b1a08b9c9f087dd13449ecc76
Pablo Galindo Salgado added the comment:
One important thing is that "traceback.print_exception" should correctly print
syntax errors .
--
___
Python tracker
<https://bugs.python.o
Pablo Galindo Salgado added the comment:
Seems that the issue went away when configuring the maxfiles with
$ launchctl limit maxfiles
instead of with "ulimit -n"
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Pablo Galindo Salgado added the comment:
> ulimit -n 1000
If i do this, the test hangs some times instead of crashing
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
The same test sometimes hangs forever
--
___
Python tracker
<https://bugs.python.org/issue45290>
___
___
Python-bug
New submission from Pablo Galindo Salgado :
==
FAIL: test_multiprocessing_pool_circular_import
(test.test_importlib.test_threaded_import.ThreadedImportTests
Change by Pablo Galindo Salgado :
--
title: test_gdbm segfaults in M1 Mac -> test_dbm and test_dbm_ndbm segfaults in
M1 Mac
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
See https://buildbot.python.org/all/#/builders/725/builds/4
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
components: +macOS -Tests
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<https://bugs.python.org/issue45289>
___
___
New submission from Pablo Galindo Salgado :
0:04:14 load avg: 3.86 [141/427/1] test_dbm crashed (Exit code -11)
Fatal Python error: Segmentation fault
Current thread 0x000102e2bd40 (most recent call first):
File
"/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/buil
Pablo Galindo Salgado added the comment:
> Typing `import sys; sys.exit()` every time I want to test something quick on
> the REPL is awful UX.
Without disagreeing with the general sentiment, just note that you can always
do
Pablo Galindo Salgado added the comment:
> Add a context manager which suppresses keyboard interruption.
That's not enough technically. This can be any signal handler that raises an
exception, no?
--
___
Python tracker
<https://bugs.pyth
Pablo Galindo Salgado added the comment:
> Though I wouldn't like to lose the ability to extract the Python stack by
> inspecting native memory alone.
Don't worry about it, I am personally making sure that keeps being possible. it
will need some changes in the tools, but not an
Pablo Galindo Salgado added the comment:
Cherry-picked!
--
priority: release blocker ->
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Also, I checked the DWARF tree of all existing wheels for 3.10 on PyPI (there
aren't many) and none had anything that uses the size of the struct.
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> I'll just note that a change in struct size does technically break ABI, since
> *arrays* of PyThreadState will break.
Not that matters now because we are not proceeding but just to clarify why I
deemed this acceptable: arrays of PyThrea
Pablo Galindo Salgado added the comment:
What was rejected was https://www.python.org/dev/peps/pep-0651/ which included
this idea but had a lot more stuff in it. In particular, it was rejected
because it gave semantics to overflow exceptions (two exceptions were
proposed), new APIs
Pablo Galindo Salgado added the comment:
Always happy to help :)
--
___
Python tracker
<https://bugs.python.org/issue24076>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
I discussed this particular instance with the Steering Council and the
conclusion was that this field (use_tracing) is considered an implementation
detail and therefore its removal it's justified so we won't be restoring it.
I'm therefore closing
Pablo Galindo Salgado added the comment:
I'm removing the release blocker as per above, feel free to close of there is
nothing else to discuss or act on here.
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Also, I personally thing there is absolutely no guarantee that Cython code
generated for 3.9 should work for 3.10 and the thread state is a private
structure that has undocumented fields and is not part of the stable API nor
the limited API so
Pablo Galindo Salgado added the comment:
Also, just to clarify, I also opened PR 28498 to discuss the possibility of
going ahead, I still don't want to move on without consensus.
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
>From PR 28498:
@vstinner @ambv The ABI is not broken, the only thing that this PR change is
the size of the struct. All the offsets to the members are the same and
therefore will be valid in any compiled code.
Any compiled wheels will still w
Change by Pablo Galindo Salgado :
--
pull_requests: +26893
pull_request: https://github.com/python/cpython/pull/28498
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
New changeset 1c7e98dc258a0e7ccd2325a1aefc4aa2de51e1c5 by Pablo Galindo Salgado
in branch 'main':
bpo-24076: Fix reference in sum() introduced by GH-28469 (GH-28493)
https://github.com/python/cpython/commit/1c7e98dc258a0e7ccd2325a1aefc4aa2de51e1c5
Pablo Galindo Salgado added the comment:
Sorry, I meant PR 28493
--
___
Python tracker
<https://bugs.python.org/issue24076>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
Opened #28493 to fix the refleak
--
___
Python tracker
<https://bugs.python.org/issue24076>
___
___
Python-bugs-list m
Change by Pablo Galindo Salgado :
--
pull_requests: +26888
pull_request: https://github.com/python/cpython/pull/28493
___
Python tracker
<https://bugs.python.org/issue24
Pablo Galindo Salgado added the comment:
Unfortunately commit debd80403721b00423680328d6adf160a28fbff4 introduced a
reference leak:
❯ ./python -m test test_grammar -R :
0:00:00 load avg: 2.96 Run tests sequentially
0:00:00 load avg: 2.96 [1/1] test_grammar
beginning 9 repetitions
123456789
Pablo Galindo Salgado added the comment:
New changeset a356272362c15f2561872f3206baf5e9a0543997 by Pablo Galindo Salgado
in branch 'main':
bpo-45200: Ignore test_multiprocessing_* in ASAN build due to false positives
(GH-28492)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +26887
pull_request: https://github.com/python/cpython/pull/28492
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
New changeset 050d1035957379d70e8601e6f5636637716a264b by Erlend Egeberg
Aasland in branch 'main':
bpo-44958: Only reset `sqlite3` statements when needed (GH-27844)
https://github.com/python/cpython/commit/050d1035957379d70e8601e6f5636637716a264b
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26884
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28488
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
Removing the usage of the C stack in Python-to-Python calls will allow future
optimizations in the eval loop to take place and can yield some speed ups given
that we will be removing C function calls and preambles by inlining the callee
in the same
Pablo Galindo Salgado added the comment:
Can you try a doctest that fails on something that is not a SyntaxError.
Something like:
>>> def foo(x):
...return x + 42
>>> foo(None)
--
___
Python tracker
<https://bugs.
Pablo Galindo Salgado added the comment:
Ah, but that is a different issue. This is not PEP 657, this is a SyntaxError,
so is related how those are printed, which I think is separared.
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
Hu, could you explain a bit more in detail what is the expected output? I
can see highlighting in the exec call that you pasted:
exec(compile(example.source, filename, "s
Pablo Galindo Salgado added the comment:
Can someone repeat the benchmarks with
https://github.com/python/cpython/pull/28475 ?
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
> I didn't check the error rate of this issue. Usually, I'm not sure why, but
> I'm the one affected by every single test which fails randomly :-D
If you wish, as a compromise we can ignore multiprocessing tests on ASAN build
for now and leav
501 - 600 of 4424 matches
Mail list logo
