Pablo Galindo Salgado added the comment:
Also, the ordered dict dealloc is already doing that:
https://github.com/python/cpython/blob/a856364cc920d8b16750fd1fadc902efb509754c/Objects/odictobject.c#L1372-L1373
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
> I'm thinking that edit to tp_dealloc was incorrect.
What edit are you referring to? PR 18749 only touches tp_clear and tp_traverse,
not tp_dealloc
--
___
Python tracker
<https://bugs.pyth
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> I could not reproduce the crash and from the discussion it seems resolved. Is
> there anything left here?
No, this should be fixed by now. I just forgot to close the issue. Thanks for
th
Pablo Galindo Salgado added the comment:
New changeset a6779715c4d0289acb59a8fd3660ab2e5d486c4b by Erlend Egeberg
Aasland in branch 'main':
bpo-45041: Simplify `sqlite3.Cursor.executescript()` (GH-28020)
https://github.com/python/cpython/commit/a6779715c4d0289acb59a8fd3660ab2e5d486c4b
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 771a5467132f0400d4c987db8ba807f845b655bc by Erlend Egeberg
Aasland in branch 'main':
bpo-45040: Simplify sqlite3 transaction control functions (GH-28019)
https://github.com/python/cpython/commit/771a5467132f0400d4c987db8ba807f845b655bc
Pablo Galindo Salgado added the comment:
New changeset 1d42408495402b06ecae91420735aeff454be6b5 by Nikita Sobolev in
branch 'main':
bpo-45128: fixes `test_multiprocessing_fork` mysterious crash (GH-28387)
https://github.com/python/cpython/commit/1d42408495402b06ecae91420735aeff454be6b5
Pablo Galindo Salgado added the comment:
New changeset e6d05a4092b4176a30d1d1596585df13c2ab676d by Pablo Galindo Salgado
in branch 'main':
bpo-30637: Improve the docs of ast.parse regarding differences with compile()
(GH-28459)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26860
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/28459
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> Pablo, marking as release blocker. PR GH-28232 is merged to 3.10. It should
> be cherry-picked for 3.10.0 inclusion.
Done!
--
resolution: -> fixed
stage: patch review -> resolved
status: op
Pablo Galindo Salgado added the comment:
New changeset 9c23a1ebade19f20c7d6e592a7d0329545a9a746 by Miss Islington (bot)
in branch '3.10':
bpo-44640: Improve punctuation consistency in isinstance/issubclass error
messages (GH-27144) (GH-28436)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
I have checked and indeed this has been fixed already.
Thanks a lot, Victor for the fix!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bug
Pablo Galindo Salgado added the comment:
> are ready to be cherrypicked into into the 3.10.0 release branch.
Once that is done, 'release blocker' can be removed, but issue should remain
open for a separate fix for 3.9.
Done! I am removing the release blocker and the 3.10, 3.11 version t
Pablo Galindo Salgado added the comment:
I understand what you mean and I sympathize with it, but this is no different
to random failures that we get in the other CI.
The check is not failing constantly because otherwise no PRs could be merged
and that's not what is happening.
I
Pablo Galindo Salgado added the comment:
> Pablo: would it be possible to make the Address Sanitizer not mandatory on
> pull requests, until this libasan race condition is fixed?
I don't think that's a good idea because then people will simply
Pablo Galindo Salgado added the comment:
If https://bugs.python.org/file50280/310rc2_benchmarks.txt is correct, this
means that we have a 7% slowdown in Windows PGO builds for 3.10, which I don't
think is acceptable.
I am marking this as a release blocker until there is some agreement. I
New submission from Pablo Galindo Salgado :
In the main branch, pyperformance fails to build due to something regarding the
freeze module:
2021-09-17 00:03:46,170: /home/pablogsal/cpython_cron/Programs/_freeze_module
importlib._bootstrap /home/pablogsal/cpython_cron/Lib/importlib
Pablo Galindo Salgado added the comment:
> Pablo, should this be a release blocker?
How severe is the regression? If is severe enough we can mark it as a release
blocker, but a conclusion needs to be reached ASAP because I don't want to
change a fundamental macro a few days bef
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26774
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28360
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> but quite reliably does occur (three times in three different spots) if the
> whole test suite is executed:
The thing is that we are running the test suite constantly on CI and buildbots
and non of them have seen this problem :(
We should see
Pablo Galindo Salgado added the comment:
I think this adds too much complexity for an Easter egg. The compiler flags
have been proven to be quite brittle (see past bugs regarding them) so I don't
want to add new ones of we can avoid
Pablo Galindo Salgado added the comment:
New changeset dda5ff2d095c795f00afaa64505069a2409f6099 by Miss Islington (bot)
in branch '3.10':
bpo-4356: Mention the new key arguments for the bisect module APIs in the 3.10
What's new (GH-28339) (GH-28340)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
> Pablo, I'm not sure what you cherry-picked,
I cherry-picked https://github.com/python/cpython/pull/26684
but this can be easily undone as this is cherry-picked to the 3.10.0 release
branch that I have much more control upon.
What would you pre
Pablo Galindo Salgado added the comment:
New changeset 1aaa85949717e4ab2ed700e58762f0a3ce049a37 by Pablo Galindo Salgado
in branch 'main':
bpo-4356: Mention the new key arguments for the bisect module APIs in the 3.10
What's new (GH-28339)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 20.0 -> 21.0
pull_requests: +26752
pull_request: https://github.com/python/cpython/pull/28339
___
Python tracker
<https://bugs.python.org/iss
Pablo Galindo Salgado added the comment:
Brett, can you take a look when you have some time?
--
___
Python tracker
<https://bugs.python.org/issue45183>
___
___
Pablo Galindo Salgado added the comment:
I bisected this to:
3abf6f010243a91bf57cbf357dac33193f7b8407 is the first bad commit
commit 3abf6f010243a91bf57cbf357dac33193f7b8407
Author: Desmond Cheong
Date: Tue Mar 9 04:06:02 2021 +0800
bpo-14678: Update zipimport to support
Pablo Galindo Salgado added the comment:
Thanks Terry,
I have cherry-picked commit b441e99d89a3f05210cc36ade57699384986ca00 to the
3.10.0 release branch!
--
___
Python tracker
<https://bugs.python.org/issue40
Pablo Galindo Salgado added the comment:
> @pablogsal: You might want to merge this back to 3.10.0, once it's merged to
> 3.10. I'll merge it shortly, once the tests have run.
Thanks for the ping. I have cherry-picked PR 28259 to
Pablo Galindo Salgado added the comment:
The bug is not a crash in the interpreter and this PR touches fundamental code
in the interpreter, so I think the safest approach is waiting for 3.10.1
--
priority: release blocker ->
___
Python trac
Change by Pablo Galindo Salgado :
--
pull_requests: +26633
pull_request: https://github.com/python/cpython/pull/28208
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Opened https://bugs.python.org/issue45128
--
___
Python tracker
<https://bugs.python.org/issue45052>
___
___
Python-bug
New submission from Pablo Galindo Salgado :
While testing the release artifacts I encountered this failure:
test test_multiprocessing_fork failed -- Traceback (most recent call last):
File "/tmp/tmpu30qfjpr/installation/lib/python3.10/unittest/mock.py", line
1239, in _dot_lookup
Pablo Galindo Salgado added the comment:
I'm planning to revert PR 28185 because this is blocking the release
--
___
Python tracker
<https://bugs.python.org/issue45
Pablo Galindo Salgado added the comment:
I'm doing the release of 3.10.0rc2 as we speak. Please, review this ASAP or
otherwise this PR will not be backported to 3.10.0 and will have to wait to
3.10.1 as per the devguide.
--
___
Python tracker
Pablo Galindo Salgado added the comment:
This seem to have caused several errors that have manifested on the release of
3.10.0rc2:
test test_multiprocessing_fork failed -- Traceback (most recent call last):
File "/tmp/tmpu30qfjpr/installation/lib/python3.10/unittest/mock.py",
Pablo Galindo Salgado added the comment:
New changeset 97b754d4b46ad9dd63f68906484f805931578c81 by Pablo Galindo Salgado
in branch 'main':
Revert "bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011)"
(GH-28201)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 53257cf19fc06fff446815b3278d4b80ec3e7ba3 by Miss Islington (bot)
in branch '3.10':
bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194)
(GH-28199)
https://github.com/python/cpython/co
Pablo Galindo Salgado added the comment:
Petr, is something left to do for this release blocker? I am planning to start
the release if everything is OK
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 608a6292366ebba20f33d93d8b52cbb928429e47 by Miss Islington (bot)
in branch '3.10':
bpo-44860: Make sysconfig posix_user not depend on platlibdir (GH-27655)
(GH-28197)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset fa2c0b85a8d5c9486661083afdf38cbaadb3432a by Pablo Galindo Salgado
in branch 'main':
bpo-44964: Add a note explaining the new semantics of f_last_i in frame objects
(GH-28200)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
Ok, I am reverting PR 28011. Someone should check it again and decide what to
do, but this won't enter 3.10
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
pull_requests: +26626
pull_request: https://github.com/python/cpython/pull/28201
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Miro, Petr, do you think then that we should revert PR 28011
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26625
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28200
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 2c3474a637949aa6f2f7e15f9764c2dfc49cdba1 by Yury Selivanov in
branch 'main':
bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194)
https://github.com/python/cpython/commit/2c3474a637949aa6f2f7e15f9764c2dfc49c
Pablo Galindo Salgado added the comment:
Hum, I reviewed PR 38011 and the change made sense to me, but If you think
we should reconsider PR 28011, please say so ASAP because the 3.10 backport is
close to be merged
--
___
Python tracker
Pablo Galindo Salgado added the comment:
New changeset 533e725821b15e2df2cd4479a34597c1d8faf616 by Pablo Galindo Salgado
in branch 'main':
bpo-44963: Implement send() and throw() methods for anext_awaitable objects
(GH-27955)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset 4f88161f07538dfb24a43189fd59bf966cb40817 by Tzu-ping Chung in
branch 'main':
bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011)
https://github.com/python/cpython/commit/4f88161f07538dfb24a43189fd59bf966cb40817
Pablo Galindo Salgado added the comment:
IIUC we need to backport PR27655 to 3.10 no? Or do we need something else?
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue45116>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26599
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28170
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I think the best outcome here is to refine the syntax error. Making it behave a
bit better is going to be quite a pain because of how unary "-" and "not" work
on the priority level in the grammar.
I also don't thi
Pablo Galindo Salgado added the comment:
> But we've never gotten past just talking about it
Stay tuned! :)
https://github.com/we-like-parsers/cpython/tree/fstring-grammar
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I honestly want to backport it because I think it should not have any negative
impact, but on the other hand I don't feel very confident as the release
candidate phase is supposed to be as close as possible as the final release and
this is not fixing
Pablo Galindo Salgado added the comment:
Let's wait for 3.10.1 to backport this because I prefer to keep pyc files
stable for the release candidate. Turns out that people are already preparing
wheels to 3.10 and although this may be fine, I don't want to risk
incompatibilities
Change by Pablo Galindo Salgado :
--
components: -Build, C API, Parser, Tests, email
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue39
Pablo Galindo Salgado added the comment:
> I want to backport it to 3.10 or 3.10.1 after Mark's review.
Ok, please, add me as a reviewer to the backport once is ready.
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> Python 3.11 makes it worse: up to 1.5x longer
Sound like you likely want to use the environment variable to deactivate the
extra information ;)
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
>In my example, there are 6 frames. The indicators cover the whole line of 3
>frames: 50%. It's a common case, it's not special.
Special is not uncommon, is just some different behaviour rather than the
default one. I am not arguing that is
Pablo Galindo Salgado added the comment:
Regarding the issue: I understand what you mean but I don't think we should get
into suppressing the indicators in special situations. Some people may say that
in a line that assigns to a call:
x = foo(x)
^^
highlighting foo() is also
Pablo Galindo Salgado added the comment:
> In term of release process, can we change the traceback after Python 3.10.0
> final? Or can we only change it in Python 3.11?
I don't follow what you want to change in 3.10.0 final, PEP 657 is for Python
3.11. Can you c
Pablo Galindo Salgado added the comment:
New changeset e34bb409197d72711ae2c6197f9d8305533034d4 by Erlend Egeberg
Aasland in branch 'main':
bpo-45041: Increase coverage for sqlite3.Cursor.executescript() (GH-28074)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset 86d8b465231473f850cc5e906013ba8581ddb503 by Erlend Egeberg
Aasland in branch 'main':
bpo-16379: expose SQLite error codes and error names in `sqlite3` (GH-27786)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
Is something missing here?
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset f62763d26755260c31c717fb396550e00eb6b2a0 by Erlend Egeberg
Aasland in branch 'main':
bpo-43398: Add test for defect connection factories (GH-27966)
https://github.com/python/cpython/commit/f62763d26755260c31c717fb396550e00eb6b2a0
Pablo Galindo Salgado added the comment:
New changeset 2a80893e5c023a73ccd32cc319f4f0404f548c00 by Erlend Egeberg
Aasland in branch '3.10':
[3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to
commit (GH-26202) (GH-27943)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
I prefer to not backport this to 3.10 because technically we cannot introduce
new deprecations in an rc and I don't want someone compiling with -Werror to
crash between rcs.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
The error is correct:
>>> *(2,3,4)
File "", line 1
SyntaxError: can't use starred expression her
The problem is that you are trying to use as top level while:
*(),
is equivalent to:
(*(),)
which is using them in a tup
Pablo Galindo Salgado added the comment:
New changeset 32c1caa87f68a650f2d009a589a1db30484499cb by Dong-hee Na in branch
'3.10':
bpo-45000: Raise SyntaxError when try to delete __debug__ (GH-27947) (GH-27957)
https://github.com/python/cpython/commit/32c1caa87f68a650f2d009a589a1db30484499cb
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 6ea6cf22e9d084c27a4fffbbd298098a6ad5b776 by Dong-hee Na in branch
'3.10':
[3.10] bpo-45000: Update whatsnews about deleting __debug__ (GH-27956)
(GH-27958)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
Oh, my bad. I can't find the enum values of the return type, though
(PySendResult).
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +26401
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27955
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I am reopening this issue since am_send never got documented here:
https://docs.python.org/3/c-api/typeobj.html#async-structs
--
nosy: +pablogsal
resolution: fixed ->
status: closed -> open
___
Change by Pablo Galindo Salgado :
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue44963>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset b34ca7e0515e6726cf5e938f7239de41df710cfd by Erlend Egeberg
Aasland in branch '3.10':
[3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922).
(GH-27953)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset 0ec17a2494412ea7d76f7d0567b73c1fffa88c18 by Erlend Egeberg
Aasland in branch '3.9':
[3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922)
(GH-27952)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset 7903a1096343d8018e889029f025d39bdd077170 by Erlend Egeberg
Aasland in branch 'main':
bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922)
https://github.com/python/cpython/commit/7903a1096343d8018e889029f025d39bdd077170
Pablo Galindo Salgado added the comment:
New changeset 52702e8ba0d777ac92ec36038213976545c4759e by Erlend Egeberg
Aasland in branch '3.9':
[3.9] bpo-27334: roll back transaction if sqlite3 context manager fails to
commit (GH-26202) (GH-27944)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
New changeset 7ecd3425d45a37efbc745788dfe21df0286c785a by Erlend Egeberg
Aasland in branch 'main':
bpo-27334: roll back transaction if sqlite3 context manager fails to commit
(GH-26202)
https://github.com/python/cpython/commit
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue44999>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Pablo Galindo Salgado :
--
components: -Parser
___
Python tracker
<https://bugs.python.org/issue44999>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 3df0fc89bc2714f5ef03e36a926bc795dcd5e05a by Erlend Egeberg
Aasland in branch 'main':
bpo-44976: Lazy creation of sqlite3 result rows (GH-27884)
https://github.com/python/cpython/commit/3df0fc89bc2714f5ef03e36a926bc795dcd5e05a
Pablo Galindo Salgado added the comment:
As long as the cycles don't actually end in a crash or an infinite cycle, I
think is fine to not include them in the contact.
Even if that were included I don't think is actually a problem. Many APIs in C
or C++ require the user to not form cycles
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 878e7267016ba25d05d8736349fb897c756f311d by Erlend Egeberg
Aasland in branch 'main':
bpo-44965: Early exit for non-DML statements in sqlite3.Cursor.executemany()
(GH-27865)
https://github.com/python/cpython/commit
Pablo Galindo Salgado added the comment:
I am marking this as a release blocker, given that this is probably going to
trip a lot of users.
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Are you ok if I add a small comment to the what's new of 3.10?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Sorry, bad copy paste. Correction:
Technically, the function was called with:
PyCode_Addr2Line(frame->f_code, frame->f_last_i)
but now it needs to be called with
PyCode_Addr2Line(frame->f_code, frame->
New submission from Pablo Galindo Salgado :
I have noticed that the semantics of PyCode_Addr2Line() have changed from 3.9
to 3.10. Technically, the function was called with:
PyCode_Addr2Line(frame->f_code, frame->f_last_i * 2)
but now it needs to be called with
PyCode_Addr2Line
601 - 700 of 4424 matches
Mail list logo
