Pam McA'Nulty added the comment:
Reviewing docs and am writing a queue implementation for usability testing. I
think ShareableList needs to support `close()` and `unlink()` directly. The
`.shm` attribute should be considered an _implementation_ detail, and not be
exposed.
--
nosy
Change by Pam McA'Nulty :
--
title: test_socket test_host_resolution_bad_address test failure -> Test
Failure MacOS : test_socket test_host_resolution_bad_address
___
Python tracker
<https://bugs.python.org/issu
New submission from Pam McA'Nulty :
- Cloned a new cpython onto my new MacOS system (Mojave 10.14.4)
- built as per https://devguide.python.org/
- test failure:
```
./python.exe -m test -j3 test_socket
Run tests in parallel using 3 child processes
0:00:24 load avg: 0.88 [1/1/1] test_socket
Pam McA'Nulty <pam...@mcanulty.org> added the comment:
oops -
"In the example code, the 'result' variable is declared on the stack in the
callback() function. So it will be effectively when callback() returns."
should be
"In the example code, the 'result' variable is
Pam McA'Nulty <pam...@mcanulty.org> added the comment:
In the example code, the 'result' variable is declared on the stack in the
callback() function. So it will be effectively when callback() returns.
Also the "result" variable in main() is never referenced. A pointer m
Pam McA'Nulty added the comment:
I can conform that Chi Hsuan Yen's patch works for me.
I'm concerned that the build includes sys/random.h despite it not actually
being needed to build python on mac os x (my worry is possible "shenanigans" by
Apple in future versions of the
Pam McA'Nulty added the comment:
I've dug into things some more.
In my mac environment, sys/random.h is pretty empty and doesn't actually seem
to provide anything that Python/random.c uses. The compile error is a type
error is because 'u_int' never gets typedef'd in the rest of the compile
Pam McA'Nulty added the comment:
New patch to make consistent wrt use of "defined()"
--
Added file: http://bugs.python.org/file46024/Issue29057_random_include-v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Pam McA'Nulty added the comment:
Good question.
It looks like there are 3 defines getting checked:
HAVE_SYS_RANDOM_H and either HAVE_GETRANDOM or HAVE_GETENTROPY
The previous issue seemed to be that you could have HAVE_GETRANDOM and/or
HAVE_GETENTROPY be set, but still not have a sys/random.h
Pam McA'Nulty added the comment:
I will say that, though my fix seems to work, it feels that the "right" place
to put the fix is in ./configure.
Sadly, I don't speak './configure', though I apparently remember enough C from
17 years ago to get th
Pam McA'Nulty added the comment:
Yeah, I looked at the code and saw what you described, David. I think I'll see
if there's a good place to mention this constraint in the docs and then I'll
find another one (besides the macOS build issue I ran into when trying to build
the latest master
Pam McA'Nulty added the comment:
I just clicked "Random Issue" and it seemed to be an "easy" (ish) one - which
is just what I'd like to tackle over xmas break :)
--
___
Python tracker <rep...@bugs.python.org>
<http
Pam McA'Nulty added the comment:
OSX: 10.11.6 (15G1212)
Xcode 8.2.1 Build version 8C1002
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Pam McA'Nulty added the comment:
Patch for fix
--
keywords: +patch
Added file: http://bugs.python.org/file46009/Issue29057_random_include.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Pam McA'Nulty:
make failed on Mac OS X including sys/random.h
It looks to be caused by this commit:
https://github.com/python/cpython/commit/1958527a2c5dda766b1917ab563622434b3dad0d
Restoring the removed ifdefs solves the problem (see github PR)
Official patch to follow
Changes by Pam McA'Nulty <pam...@mcanulty.org>:
--
nosy: +Pam.McANulty
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14483>
___
_
Changes by Pam McA'Nulty <pam...@mcanulty.org>:
--
title: Increase test coverage of unittest.runner.TextTestResult -> Patch to
Increase test coverage of unittest.runner.TextTestResult
___
Python tracker <rep...@bugs.pytho
New submission from Pam McA'Nulty:
While working on another issue, I added a test to increase (low-hanging fruit)
test coverage in unittest.runner.TextTestResult
--
components: Tests
files: textresult_coverage.patch
keywords: patch
messages: 269330
nosy: Pam.McANulty
priority: normal
Changes by Pam McA'Nulty <pam...@mcanulty.org>:
--
nosy: +Pam.McANulty
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26859>
___
_
Changes by Pam McA'Nulty <pam...@mcanulty.org>:
--
nosy: +Pam.McANulty
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27152>
___
_
Changes by Pam McA'Nulty <pam...@mcanulty.org>:
--
nosy: +Pam.McANulty
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27198>
___
_
Pam McA'Nulty added the comment:
Here's a version of the docs with double quotes
--
Added file:
http://bugs.python.org/file39033/cpython-22812-discovery-double-quotes-v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Pam McA'Nulty added the comment:
Thanks, Zach for both the comments and the mention of the email bounce. I
changed jobs and didn't have this site listed in my must update email address
list (fixed now)
Should I re-update the doc patch and put in double quotes
Pam McA'Nulty added the comment:
This version of the patch just updates the docs. Since the quotes aren't
really necessary for the example to work, the patch removes the single quotes
from the example.
I don't think that the python unittest documentation should explain/document
Pam McA'Nulty added the comment:
Remove quotes from quoted patterns only on windows systems (since if the quotes
get parsed into the pattern field on a non-windows system, one should respect
the user's command line efforts).
Test uses unittest.mock.patch to test windows path
Pam McA'Nulty added the comment:
This version fixes a few things after using review.
I still have some open questions:
o Where in unittest.rst should the StopTestRun documentation actually live?
I've put it right after the SkipTest exception. That doesn't feel perfect,
but I didn't see
Changes by Pam McA'Nulty pam...@webreply.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10612
___
___
Python-bugs
Changes by Pam McA'Nulty pam...@webreply.com:
--
nosy: +kushal.das
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10612
___
___
Python-bugs-list
Pam McA'Nulty added the comment:
Added unittest.StopTestRun exception. It's caught and handled in
testPartExecutor() - which is the same place SkipTest is caught.
If report=False, then it sets the result.haltTestRun attribute, which is a
signal to TestTextRunner to not generate any output
Changes by Pam McA'Nulty pam...@webreply.com:
--
nosy: +Pam.McANulty
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10612
___
___
Python-bugs-list
Pam McA'Nulty added the comment:
Here's a new version. It looks more like the str_parts patch and uses
parentheses instead of continuation as suggested.
Sample output:
pprint.pprint(b\n\na\x00, width=1)
(b'\n'
b'\n'
b'a'
b'\x00')
--
Added file: http://bugs.python.org
Pam McA'Nulty added the comment:
Here's a patch. I needed to handle the fact that the repr of a single byte can
be 1, 2 or 4 characters long and did not want to wrap in the middle of a byte
representation. Note also that bytes literals require a continuation
character. In the pathological
Pam McA'Nulty added the comment:
oops, forgot to add some samples:
pprint.pprint(b\n\n\n\n\n\n, width=5)
b'\n'\
b'\n'\
b'\n'\
b'\n'\
b'\n'\
b'\n'
pprint.pprint({a: b\x00\xff * 20})
{'a': b'\x00\xff\x00\xff\x00\xff\x00\xff\x00\xff\x00\xff\x00\xff\x00\xff\x00'\
b'\xff\x00\xff\x00\xff\x00
Pam McA'Nulty added the comment:
- eval expects bytes to have a continuation character and test_str_wrap did an
eval check so I figured test_bytes_wrap should as well:
# repr some bytes:
b = b\x00\xff * 5
b
b'\x00\xff\x00\xff\x00\xff\x00\xff\x00\xff'
r = repr(b)
r
b'\\x00\\xff\\x00\\xff
34 matches
Mail list logo
