[issue37151] Calling code cleanup after PEP 590

2019-06-07 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 3f345c39255dc3823dd989d4e3c93b12d18c44e0 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-37151: simplify classmethoddescr_call (GH-13340) https://github.com/python/cpython/commit/3f345c39255dc3823dd989d4e3c93b12d18c44e0

[issue37191] Python.h contains intermingled declarations

2019-06-07 Thread Petr Viktorin
Petr Viktorin added the comment: > pygobject3, python-dbus, xen Correction: - The Fedora packages failed to build; this might or might not be due to the projects themseves - pygobject3 actually only warns on this Anyway, we can usually take care of open-source stuff. Only t

[issue37191] Python.h contains intermingled declarations

2019-06-07 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +13761 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13887 ___ Python tracker <https://bugs.python.org/issu

[issue37191] Python.h contains intermingled declarations

2019-06-07 Thread Petr Viktorin
New submission from Petr Viktorin : When compiled with GCC's -Werror=declaration-after-statement ("intermingled declarations" in PEP7), cpython/abstract.h (included from ) errors on vectorcall helper functions added in 3.8.0 Beta 1. It's well within our rights to ignore this: si

[issue37140] ctypes change made clang fail to build

2019-06-04 Thread Petr Viktorin
Petr Viktorin added the comment: The issue is with building clang using Python 3.8; not building Python 3.8 using clang :) -- ___ Python tracker <https://bugs.python.org/issue37

[issue35947] Update libffi_msvc to current version of libffi

2019-06-03 Thread Petr Viktorin
Petr Viktorin added the comment: Possible regression caused by this change: https://bugs.python.org/issue37140 -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue35

[issue37140] ctypes change made clang fail to build

2019-06-03 Thread Petr Viktorin
New submission from Petr Viktorin : Hello, I haven't investigated this fully yet, and won't be able to find time today. I'm forwarding the report here in case someone familiar with the code wants to take a look. On Fedora, "clang" fails to build with Python 3.8, probably due t

[issue36896] clarify in types.rst that FunctionTypes & co constructors don't have stable signature

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 13136e83a637a9f1cfbada7e93097005296659b4 by Petr Viktorin (Matthias Bussonnier) in branch 'master': bpo-36896: Clarify that some types constructors are unstable (GH-13271) https://github.com/python/cpython/commit

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2019-06-02 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13649 pull_request: https://github.com/python/cpython/pull/13761 ___ Python tracker <https://bugs.python.org/issue33

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 1e375c6269e9de4f3d05d4aa6d6d74e00f522d63 by Petr Viktorin in branch 'master': bpo-36027: Really fix "incompatible pointer type" compiler warning (GH-13761) https://github.com/python/cpython/commit/1e375c6269e9de4f3d05d4aa6d6d74

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-02 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13646 pull_request: https://github.com/python/cpython/pull/13761 ___ Python tracker <https://bugs.python.org/issue36

[issue36974] Implement PEP 590

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset be718c33f06b3496faa61142df24fb071fd5d1f1 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: add some assertions for PEP 590 (GH-13682) https://github.com/python/cpython/commit/be718c33f06b3496faa61142df24fb071fd5d1f1

[issue36974] Implement PEP 590

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 9e3e06e582accec82eb29cf665c3b4c7d84d2eb0 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: document PEP 590 (GH-13450) https://github.com/python/cpython/commit/9e3e06e582accec82eb29cf665c3b4c7d84d2eb0

[issue37012] Possible crash due to PyType_FromSpecWithBases()

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 7f4ae1b2cc60cb69938e7c88793b9e9a2dd36d93 by Petr Viktorin in branch 'master': bpo-37012: Clean up special cases in PyType_FromSpecWithBases slot assignments (GH-13496) https://github.com/python/cpython/commit

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in branch 'master': bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings (GH-13758) https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e

[issue36974] Implement PEP 590

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in branch 'master': bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings (GH-13758) https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-02 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13639 pull_request: https://github.com/python/cpython/pull/13758 ___ Python tracker <https://bugs.python.org/issue36

[issue36974] Implement PEP 590

2019-06-02 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13640 pull_request: https://github.com/python/cpython/pull/13758 ___ Python tracker <https://bugs.python.org/issue36

[issue36027] Support negative exponents in pow() where a modulus is specified.

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: I will fix the compiler warning along with another one that I just introduced. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue36

[issue36974] Implement PEP 590

2019-06-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset fb9423fd0a85f06affb8c3a8f25dd598a649aa42 by Petr Viktorin in branch 'master': bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types (GH-13699) https://github.com/python/cpython/commit/fb9423fd0a85f06affb8c3a8f25dd598a649aa42

[issue36974] Implement PEP 590

2019-05-31 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13584 pull_request: https://github.com/python/cpython/pull/13699 ___ Python tracker <https://bugs.python.org/issue36

[issue36974] Implement PEP 590

2019-05-31 Thread Petr Viktorin
Petr Viktorin added the comment: I found an issue in PEP 590: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it. Possible

[issue36974] Implement PEP 590

2019-05-30 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 37788bc23f6f1ed0362b9b3b248daf296c024849 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: rename _FastCallKeywords -> _Vectorcall (GH-13653) https://github.com/python/cpython/commit/37788bc23f6f1ed0362b9b3b248daf296c024

[issue20602] sys.flags and sys.float_info disappear at shutdown

2019-05-30 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 249b7d59d8038f9017fc95dc28a3ce3494aaf832 by Petr Viktorin (Zackery Spytz) in branch 'master': bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (GH-8096) https://github.com/python/cpython/commit

[issue36974] Implement PEP 590

2019-05-30 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset c145f3bfbe80d498d40848450d4d33c14e2cf782 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: remove _PyObject_HasFastCall (GH-13460) https://github.com/python/cpython/commit/c145f3bfbe80d498d40848450d4d33c14e2cf782

[issue36974] Implement PEP 590

2019-05-30 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 735e8afa9ee942367b5d0807633a2b9f662cbdbf by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: inherit the vectorcall protocol (GH-13498) https://github.com/python/cpython/commit/735e8afa9ee942367b5d0807633a2b9f662cbdbf

[issue36974] Implement PEP 590

2019-05-29 Thread Petr Viktorin
Petr Viktorin added the comment: All stable buildbots are back to green. -- ___ Python tracker <https://bugs.python.org/issue36974> ___ ___ Python-bugs-list m

[issue36974] Implement PEP 590

2019-05-29 Thread Petr Viktorin
Petr Viktorin added the comment: No, just https://github.com/python/cpython/pull/13665 is addressing the failures. And it seems that it's successful -- only the slowest of the failed ones (AMD64 Ubuntu Shared 3.x) is still red. bpo-37090 extends the test so it can catch more bugs

[issue37090] test_gdb's test_pycfunction should test all calling conventions

2019-05-29 Thread Petr Viktorin
Change by Petr Viktorin : -- keywords: +patch pull_requests: +13557 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13668 ___ Python tracker <https://bugs.python.org/issu

[issue37090] test_gdb's test_pycfunction should test all calling conventions

2019-05-29 Thread Petr Viktorin
New submission from Petr Viktorin : test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration can pick up calls to C-API functions. Currently it includes the comment: > Tested function must not be defined with METH_NOARGS or METH_O, > otherwise call_function() d

[issue36974] Implement PEP 590

2019-05-29 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset fecb75c1bb46c818e6579ba422cfa5d0d9d104d1 by Petr Viktorin in branch 'master': bpo-36974: Fix GDB integration (GH-13665) https://github.com/python/cpython/commit/fecb75c1bb46c818e6579ba422cfa5d0d9d104d1

[issue36974] Implement PEP 590

2019-05-29 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13555 pull_request: https://github.com/python/cpython/pull/13665 ___ Python tracker <https://bugs.python.org/issue36

[issue36974] Implement PEP 590

2019-05-29 Thread Petr Viktorin
New submission from Petr Viktorin : New changeset aacc77fbd77640a8f03638216fa09372cc21673d by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: implement PEP 590 (GH-13185) https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa09372cc21673d

[issue34626] PEP 384's PyType_Spec and PyType_Slot are not documented

2019-05-28 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36922] Implement Py_TPFLAGS_METHOD_DESCRIPTOR

2019-05-28 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36922] Implement Py_TPFLAGS_METHOD_DESCRIPTOR

2019-05-28 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset eb65e2443ac21739baf6d373abc7b4638b9d6927 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36922: implement PEP-590 Py_TPFLAGS_METHOD_DESCRIPTOR (GH-13338) https://github.com/python/cpython/commit/eb65e2443ac21739baf6d373abc7b4638b9d6927

[issue37072] PyNode_Compile() crashes in Python 3.8.

2019-05-28 Thread Petr Viktorin
Petr Viktorin added the comment: Looks like this is caused by: https://github.com/python/cpython/pull/12086/files#diff-4d35cf8992b795c5e97e9c8b6167cb34R787 PyAST_FromNodeObject doesn't ignore flags any more, so when PyNode_Compile passes NULL flags, it crashes. (This is unfamiliar code

[issue35975] Put back the ability to parse files where async/await aren't keywords

2019-05-28 Thread Petr Viktorin
Petr Viktorin added the comment: It looks like this caused bpo-37072: PyAST_FromNodeObject doesn't ignore flags any more, and when PyNode_Compile passes NULL flags, it crashes. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.

[issue34626] PEP 384's PyType_Spec and PyType_Slot are not documented

2019-05-24 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset f1e17e9f97d9a4e97a5d99574775ee343a3a74fb by Petr Viktorin in branch 'master': bpo-34626: Document creating heap types from the C-API (GH-9154) https://github.com/python/cpython/commit/f1e17e9f97d9a4e97a5d99574775ee343a3a74fb

[issue37012] Possible crash due to PyType_FromSpecWithBases()

2019-05-22 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13411 ___ Python tracker <https://bugs.python.org/issue37012> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37012] Possible crash due to PyType_FromSpecWithBases()

2019-05-22 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13412 ___ Python tracker <https://bugs.python.org/issue37012> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37012] Possible crash due to PyType_FromSpecWithBases()

2019-05-22 Thread Petr Viktorin
New submission from Petr Viktorin : If the PyObject_MALLOC() call failed in PyType_FromSpecWithBases(), PyObject_Free() would be called on a static string in type_dealloc(). Fixed by Zackery Spytz in pull request 10304. I'm opening the issue retroactively. -- messages: 343194 nosy

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

2019-05-22 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset d092caf096fa48baadfc0900792206bb5aa0192d by Petr Viktorin (Jeroen Demeyer) in branch '3.7': bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) (GH-13493) https://github.com/python/cpython/commit

[issue31862] Port the standard library to PEP 489 multiphase initialization

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 33e71e01e95506cf8d93fd68251fc56352bc7b39 by Petr Viktorin (Marcel Plch) in branch 'master': bpo-31862: Port binascii to PEP 489 multiphase initialization (GH-4108) https://github.com/python/cpython/commit/33e71e01e95506cf8d93fd68251fc56352bc7b39

[issue35810] Object Initialization does not incref Heap-allocated Types

2019-05-22 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36936] CALL_FUNCTION_KW opcode: keyword names must be non-empty

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: Closing per discussion in https://github.com/python/cpython/pull/13357 -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: We do, but here the test will need to be changed: Python 3.7.3+ (heads/3.7:791e5fcbab, May 22 2019, 13:37:27) [GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux Type "help", "copyright", "credits" or "license" for

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: Jeroen, do you want to also do a backport for 3.7? -- ___ Python tracker <https://bugs.python.org/issue36907> ___ ___ Python-bug

[issue36907] Crash due to borrowed references in _PyStack_UnpackDict()

2019-05-22 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 77aa396bb9415428de09112ddf6b34bb843811eb by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) https://github.com/python/cpython/commit/77aa396bb9415428de09112ddf6b34bb843811eb

[issue36995] tp_print -> tp_vectorcall_offset

2019-05-21 Thread Petr Viktorin
Petr Viktorin added the comment: All these issues are quite confusing. If PEP 590 is accepted, all of it will need to be implemented. Why open separate issues for all the parts? -- ___ Python tracker <https://bugs.python.org/issue36

[issue36970] Rename _PyObject_FastCallKeywords

2019-05-21 Thread Petr Viktorin
Petr Viktorin added the comment: If and when a function uses the vectorcall protocol (including the argument offset flag), it makes sense to rename it to vectorcall. Doing it before is misleading, IMO. Splitting fixes to unrelated issues (like bpo-36907) from PEP 590 is great, but this one

[issue36937] New _PyObject_MakeTpCall() function

2019-05-21 Thread Petr Viktorin
Petr Viktorin added the comment: Ah, sorry, I didn't get the message through. I'll merge it with the rest of PEP 590. Adding the symbol doesn't make sense *right* now. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36937] New _PyObject_MakeTpCall() function

2019-05-21 Thread Petr Viktorin
Petr Viktorin added the comment: Avoiding the duplication makes sense, but without the rest of PEP 590 it could just be a static function in call.c. -- ___ Python tracker <https://bugs.python.org/issue36

[issue26515] Update extending/embedding docs to new way to build modules in C

2019-05-16 Thread Petr Viktorin
Petr Viktorin added the comment: Correct usage of multi-phase init might now get users stuck when they start needing per-module state. See PEP 573 "Module State Access from C Extension Methods" for the (hopefully) last thing that prevents me from generally recommending multi-

[issue36616] Optimize thread state handling in function call code

2019-04-15 Thread Petr Viktorin
Petr Viktorin added the comment: Indeed, this is a good idea. -- ___ Python tracker <https://bugs.python.org/issue36616> ___ ___ Python-bugs-list mailin

[issue33261] inspect.isgeneratorfunction fails on hand-created methods

2019-04-03 Thread Petr Viktorin
Change by Petr Viktorin : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue33261> ___ ___ Pyth

[issue33261] inspect.isgeneratorfunction fails on hand-created methods

2019-04-02 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset fcef60f59d04c63b3540b4c4886226098c1bacd1 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-33261: guard access to __code__ attribute in inspect (GH-6448) https://github.com/python/cpython/commit/fcef60f59d04c63b3540b4c4886226098c1bacd1

[issue33261] inspect.isgeneratorfunction fails on hand-created methods

2019-03-27 Thread Petr Viktorin
Petr Viktorin added the comment: I just reviewed, and I plan to merge it if I don't see any pushback from the others. Sorry for the extreme delay. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue33

[issue35810] Object Initialization does not incref Heap-allocated Types

2019-03-27 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 364f0b0f19cc3f0d5e63f571ec9163cf41c62958 by Petr Viktorin (Eddie Elizondo) in branch 'master': bpo-35810: Incref heap-allocated types in PyObject_Init (GH-11661) https://github.com/python/cpython/commit/364f0b0f19cc3f0d5e63f571ec9163cf41c62958

[issue36225] Lingering subinterpreters should be implicitly cleared on shutdown

2019-03-13 Thread Petr Viktorin
Petr Viktorin added the comment: Joannah, yes, that looks like a good place. Eric Snow might have more info; he wrote that module. As for testing Py_FatalError, there's an assert_python_failure function in test.support.script_helper

[issue36124] Provide convenient C API for storing per-interpreter state

2019-03-04 Thread Petr Viktorin
Petr Viktorin added the comment: PyModule_GetState() gives you *per-module* state, not per-interpreter state. Module objects are shared across subinterpreters, unless you use multi-phase initialization. > PyModule_GetState() requires having the module object that corresponds > to the

[issue35810] Object Initialization does not incref Heap-allocated Types

2019-02-22 Thread Petr Viktorin
Petr Viktorin added the comment: Changing all types to heap types is definitely a gigantic task. First let's make heap types more usable and bug-free, and then it will be easier :) (I do have an agenda here: improving heap types usable is also yak-shaving* for making modules play nice

[issue35810] Object Initialization Bug with Heap-allocated Types

2019-02-04 Thread Petr Viktorin
Petr Viktorin added the comment: I'll allocate time this week for the review. -- ___ Python tracker <https://bugs.python.org/issue35810> ___ ___ Python-bug

[issue35810] Object Initialization Bug with Heap-allocated Types

2019-01-29 Thread Petr Viktorin
Petr Viktorin added the comment: I would very much like to see this fixed. Yes, it can make some extension types immortal, but I believe those types were relying on buggy behavior, and need to be fixed to prevent memory leaks. I think this is a big enough change to be mentioned in What’s New

[issue10915] Make the PyGILState API compatible with multiple interpreters

2019-01-23 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue10915> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35420] how to migrate a c-extension module to one that supports subinerpreters?

2018-12-19 Thread Petr Viktorin
Petr Viktorin added the comment: Hi (and sorry for the delay -- it's a busy time of year). Unfortunately, there's no good documentation yet. Python's standard library itself is not free of global state, and I don't think we want to start documenting before that's fixed

[issue35186] distutils.command.upload uses deprecated platform.dist with bdist_rpm

2018-12-16 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 4e80f5cbeaee87a26e49bc9623c92a10e28dbbd9 by Petr Viktorin (Paul Ganssle) in branch 'master': bpo-35186: Remove "built with" comment in setup.py upload (GH-10414) https://github.com/python/cpython/commit/4e80f5cbeaee87a26e49bc9623c92a

[issue34784] Heap-allocated StructSequences

2018-12-05 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35052] Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

2018-11-23 Thread Petr Viktorin
Petr Viktorin added the comment: Ah, XML is such an overengineered format! Iusually live with the standard HTML entities but it turns out you can define your own! Here's a reproducer which shows how to do that. -- nosy: +petr.viktorin Added file: https://bugs.python.org/file47942

[issue28709] PyStructSequence_NewType is broken; makes GC type without setting Py_TPFLAGS_HEAPTYPE

2018-11-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue28709> ___ ___

[issue28709] PyStructSequence_NewType is broken; makes GC type without setting Py_TPFLAGS_HEAPTYPE

2018-11-14 Thread Petr Viktorin
Petr Viktorin added the comment: Should be fixed in PR9665 (bpo-34784), thanks to Eddie Elizondo. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue28

[issue34784] Heap-allocated StructSequences

2018-11-13 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 474eedfb3d1b6fecbd749f36bf4a987cf4a00b44 by Petr Viktorin (Eddie Elizondo) in branch 'master': bpo-34784: Fix PyStructSequence_NewType with heap-allocated StructSequence (GH-9665) https://github.com/python/cpython/commit

[issue32797] Tracebacks from Cython modules no longer work

2018-10-24 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 057f4078b044325dae4af55c4c64b684edaca315 by Petr Viktorin (jdemeyer) in branch 'master': bpo-32797: improve documentation of linecache.getline (GH-9540) https://github.com/python/cpython/commit/057f4078b044325dae4af55c4c64b684edaca315

[issue28167] remove platform.linux_distribution()

2018-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: Actually, the scope (right balance between usefulness and maintainability) is probably the hardest real problem to solve here. PyPI lets you iterate on that. For a straight-to-stdlib module, you'd need to get it exactly right on the first time

[issue28167] remove platform.linux_distribution()

2018-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: > I wasn't aware that starting out with a PyPI module is the only accepted > process for getting functionality into stdlib. It's the main way things should get in. (Other ways exist, for example, dataclasses were added as simplification/merging of s

[issue28167] remove platform.linux_distribution()

2018-10-08 Thread Petr Viktorin
Petr Viktorin added the comment: In the recommended library, distro, real-world issues blew the code size up to 1000 lines of code and the open issue count to 15 – so while it's definitely useful, it doesn't seem either fully complete or trivial to maintain: https://github.com/nir0s/distro

[issue28604] Exception raised by python3.5 when using en_GB locale

2018-09-24 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue28604> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24937] Multiple problems in getters & setters in capsulethunk.h

2018-09-24 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue24937] Multiple problems in getters & setters in capsulethunk.h

2018-09-24 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 2d3ff2b5ea6c903973f99d2155c9c1b60591dceb by Petr Viktorin in branch 'master': bpo-24937: Replace the extension module porting HOWTO by links to external projects (GH-9317) https://github.com/python/cpython/commit

[issue26979] The danger of PyType_FromSpec()

2018-09-17 Thread Petr Viktorin
Petr Viktorin added the comment: Ah! It seems you don't need access to all tp_* slots of any type here, but just to PyType.tp_new – only one specific type, and only one specific slot. Specifically, you need a way to create class with a metaclass, from C. Is that right? Or was this only

[issue33486] regen autotools related files

2018-09-14 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33486] regen autotools related files

2018-09-14 Thread Petr Viktorin
Petr Viktorin added the comment: New changeset 24f684692070f53b6f6e4dc67b9fe23dbd58655f by Petr Viktorin (Eitan Adler) in branch 'master': bpo-33486: regen autotools files using autoupdate+autoreconf (GH-6853) https://github.com/python/cpython/commit/24f684692070f53b6f6e4dc67b9fe23dbd58655f

[issue33486] regen autotools related files

2018-09-14 Thread Petr Viktorin
Petr Viktorin added the comment: > If these changes are autogenerated, I would prefer that a trusted core > developer create a PR. I got the same changes in configure.ac. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.p

[issue24056] Better expose closure, generator & coroutine status of functions

2018-09-14 Thread Petr Viktorin
Change by Petr Viktorin : -- nosy: -petr.viktorin ___ Python tracker <https://bugs.python.org/issue24056> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34354] Memory leak on _testCongestion

2018-09-14 Thread Petr Viktorin
Petr Viktorin added the comment: That issue has more information/discussion, and it does look like the same bug, so I'll close this one. Thank you for reporting it! -- nosy: +petr.viktorin resolution: -> duplicate stage: -> resolved status: open -> closed s

[issue24937] Multiple problems in getters & setters in capsulethunk.h

2018-09-14 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +8743 ___ Python tracker <https://bugs.python.org/issue24937> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24937] Multiple problems in getters & setters in capsulethunk.h

2018-09-14 Thread Petr Viktorin
Petr Viktorin added the comment: Well, hasn't this languished for a while. I've talked with Benjamin, and he's OK with just removing the "Porting Extension Modules to Python 3" HOWTO, and replacing it by links to external guides that do a much better job at documenting this. Al

[issue26979] The danger of PyType_FromSpec()

2018-09-14 Thread Petr Viktorin
Petr Viktorin added the comment: 1) If I understand correctly, this problem could be solved by per-class C storage? Something like PyModuleDef.m_size / PyModule_GetState, but for classes? 2) Making PyType_GetSlot work for static types would not be trivial. All types do have the same *basic

[issue34635] inspect: add tools for inspecting subclasses

2018-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: __subclasses__ is, as Tim Peters put it [0], "just Python exposing an internal mechanism for the morbidly curious". I'd expect that not all alternative implementations of Python have something like __subclasses__ -- it's a detail of the impl

[issue26979] The danger of PyType_FromSpec()

2018-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: Thanks! I think that explains enough of the issue. Converting static types to heap ones is just one way you can use PyType_Spec. Another is writing new types, which should work much like Python classes. So I don't think we should change the default

[issue34635] inspect: add tools for inspecting subclasses

2018-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: What's the use case for these? -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue34635> ___ ___ Pytho

[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Petr Viktorin
Change by Petr Viktorin : -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> test_prlimit from test_resource fails when building python3 inside systemd-nspawn environment ___ Python tra

[issue34668] test_resource fails if test has CAP_SYS_RESOURCE but isn't root

2018-09-13 Thread Petr Viktorin
Petr Viktorin added the comment: Check also discussion on issue31132. If you agree, I'm OK with marking that one as duplicate, and removing the test. -- nosy: +petr.viktorin ___ Python tracker <https://bugs.python.org/issue34

[issue33714] module can set an exception in tp_clear

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: I'm not sure what tp_clear should do in this situation. Other than propagating the exception to the GC, the most reasonable behavior seems to be to write the exception to stderr and ignore it -- but I think having the GC do that would be more robust. IOW, I

[issue26979] The danger of PyType_FromSpec()

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: Christian, do you have a specific example of the default tp_dealloc doing the wrong thing? -- ___ Python tracker <https://bugs.python.org/issue26

[issue26979] The danger of PyType_FromSpec()

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: I don't think PEP 384 should be updated. It documents the feature as it was added, and shouldn't be used as documentation now. Instead, Python documentation should be improved to cover all of PEP 389. I submitted a pull request for that (GH-9154

[issue15727] PyType_FromSpecWithBases tp_new bugfix

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: Converting static types to heap ones is just one of the reasons to use PyType_FromSpec*. Another ones are writing such classes from scratch, and converting pure-Python classes to C. I don't think PyObject_FailingNew is a good default for either of those. I

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: > The PEP 399 requires that C accelerator behaves exactly as Python, [...] It does not. PEP 399 requires that that the C code must pass the same *test suite*. And error messages in particular tend to not be checked in tests. Anyway, I don't see

[issue26502] traceback.extract_tb breaks compatibility by returning FrameSummary

2018-09-11 Thread Petr Viktorin
Petr Viktorin added the comment: I don't think I have a good enough feel for what should, generally, go to 3.7. So take my opinion with a grain of salt. But honestly, I don't think the issue is important enough -- I've only seen one codebase affected by it, which wasn't hard to fix

<    2   3   4   5   6   7   8   9   10   >