Petr Viktorin added the comment:
New changeset 3f345c39255dc3823dd989d4e3c93b12d18c44e0 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-37151: simplify classmethoddescr_call (GH-13340)
https://github.com/python/cpython/commit/3f345c39255dc3823dd989d4e3c93b12d18c44e0
Petr Viktorin added the comment:
> pygobject3, python-dbus, xen
Correction:
- The Fedora packages failed to build; this might or might not be due to the
projects themseves
- pygobject3 actually only warns on this
Anyway, we can usually take care of open-source stuff. Only t
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +13761
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13887
___
Python tracker
<https://bugs.python.org/issu
New submission from Petr Viktorin :
When compiled with GCC's -Werror=declaration-after-statement ("intermingled
declarations" in PEP7), cpython/abstract.h (included from ) errors on
vectorcall helper functions added in 3.8.0 Beta 1.
It's well within our rights to ignore this: si
Petr Viktorin added the comment:
The issue is with building clang using Python 3.8; not building Python 3.8
using clang :)
--
___
Python tracker
<https://bugs.python.org/issue37
Petr Viktorin added the comment:
Possible regression caused by this change: https://bugs.python.org/issue37140
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue35
New submission from Petr Viktorin :
Hello,
I haven't investigated this fully yet, and won't be able to find time today.
I'm forwarding the report here in case someone familiar with the code wants to
take a look.
On Fedora, "clang" fails to build with Python 3.8, probably due t
Petr Viktorin added the comment:
New changeset 13136e83a637a9f1cfbada7e93097005296659b4 by Petr Viktorin
(Matthias Bussonnier) in branch 'master':
bpo-36896: Clarify that some types constructors are unstable (GH-13271)
https://github.com/python/cpython/commit
Change by Petr Viktorin :
--
pull_requests: +13649
pull_request: https://github.com/python/cpython/pull/13761
___
Python tracker
<https://bugs.python.org/issue33
Petr Viktorin added the comment:
New changeset 1e375c6269e9de4f3d05d4aa6d6d74e00f522d63 by Petr Viktorin in
branch 'master':
bpo-36027: Really fix "incompatible pointer type" compiler warning (GH-13761)
https://github.com/python/cpython/commit/1e375c6269e9de4f3d05d4aa6d6d74
Change by Petr Viktorin :
--
pull_requests: +13646
pull_request: https://github.com/python/cpython/pull/13761
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset be718c33f06b3496faa61142df24fb071fd5d1f1 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: add some assertions for PEP 590 (GH-13682)
https://github.com/python/cpython/commit/be718c33f06b3496faa61142df24fb071fd5d1f1
Petr Viktorin added the comment:
New changeset 9e3e06e582accec82eb29cf665c3b4c7d84d2eb0 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: document PEP 590 (GH-13450)
https://github.com/python/cpython/commit/9e3e06e582accec82eb29cf665c3b4c7d84d2eb0
Petr Viktorin added the comment:
New changeset 7f4ae1b2cc60cb69938e7c88793b9e9a2dd36d93 by Petr Viktorin in
branch 'master':
bpo-37012: Clean up special cases in PyType_FromSpecWithBases slot assignments
(GH-13496)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in
branch 'master':
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings
(GH-13758)
https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e
Petr Viktorin added the comment:
New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in
branch 'master':
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings
(GH-13758)
https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e
Change by Petr Viktorin :
--
pull_requests: +13639
pull_request: https://github.com/python/cpython/pull/13758
___
Python tracker
<https://bugs.python.org/issue36
Change by Petr Viktorin :
--
pull_requests: +13640
pull_request: https://github.com/python/cpython/pull/13758
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
I will fix the compiler warning along with another one that I just introduced.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset fb9423fd0a85f06affb8c3a8f25dd598a649aa42 by Petr Viktorin in
branch 'master':
bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types (GH-13699)
https://github.com/python/cpython/commit/fb9423fd0a85f06affb8c3a8f25dd598a649aa42
Change by Petr Viktorin :
--
pull_requests: +13584
pull_request: https://github.com/python/cpython/pull/13699
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
I found an issue in PEP 590:
When inheriting a heap subclass from a vectorcall class that sets
.tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit
_Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it.
Possible
Petr Viktorin added the comment:
New changeset 37788bc23f6f1ed0362b9b3b248daf296c024849 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: rename _FastCallKeywords -> _Vectorcall (GH-13653)
https://github.com/python/cpython/commit/37788bc23f6f1ed0362b9b3b248daf296c024
Petr Viktorin added the comment:
New changeset 249b7d59d8038f9017fc95dc28a3ce3494aaf832 by Petr Viktorin
(Zackery Spytz) in branch 'master':
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (GH-8096)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
New changeset c145f3bfbe80d498d40848450d4d33c14e2cf782 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: remove _PyObject_HasFastCall (GH-13460)
https://github.com/python/cpython/commit/c145f3bfbe80d498d40848450d4d33c14e2cf782
Petr Viktorin added the comment:
New changeset 735e8afa9ee942367b5d0807633a2b9f662cbdbf by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: inherit the vectorcall protocol (GH-13498)
https://github.com/python/cpython/commit/735e8afa9ee942367b5d0807633a2b9f662cbdbf
Petr Viktorin added the comment:
All stable buildbots are back to green.
--
___
Python tracker
<https://bugs.python.org/issue36974>
___
___
Python-bugs-list m
Petr Viktorin added the comment:
No, just https://github.com/python/cpython/pull/13665 is addressing the
failures. And it seems that it's successful -- only the slowest of the failed
ones (AMD64 Ubuntu Shared 3.x) is still red.
bpo-37090 extends the test so it can catch more bugs
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +13557
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13668
___
Python tracker
<https://bugs.python.org/issu
New submission from Petr Viktorin :
test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration
can pick up calls to C-API functions. Currently it includes the comment:
> Tested function must not be defined with METH_NOARGS or METH_O,
> otherwise call_function() d
Petr Viktorin added the comment:
New changeset fecb75c1bb46c818e6579ba422cfa5d0d9d104d1 by Petr Viktorin in
branch 'master':
bpo-36974: Fix GDB integration (GH-13665)
https://github.com/python/cpython/commit/fecb75c1bb46c818e6579ba422cfa5d0d9d104d1
Change by Petr Viktorin :
--
pull_requests: +13555
pull_request: https://github.com/python/cpython/pull/13665
___
Python tracker
<https://bugs.python.org/issue36
New submission from Petr Viktorin :
New changeset aacc77fbd77640a8f03638216fa09372cc21673d by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: implement PEP 590 (GH-13185)
https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa09372cc21673d
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset eb65e2443ac21739baf6d373abc7b4638b9d6927 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36922: implement PEP-590 Py_TPFLAGS_METHOD_DESCRIPTOR (GH-13338)
https://github.com/python/cpython/commit/eb65e2443ac21739baf6d373abc7b4638b9d6927
Petr Viktorin added the comment:
Looks like this is caused by:
https://github.com/python/cpython/pull/12086/files#diff-4d35cf8992b795c5e97e9c8b6167cb34R787
PyAST_FromNodeObject doesn't ignore flags any more, so when PyNode_Compile
passes NULL flags, it crashes.
(This is unfamiliar code
Petr Viktorin added the comment:
It looks like this caused bpo-37072: PyAST_FromNodeObject doesn't ignore flags
any more, and when PyNode_Compile passes NULL flags, it crashes.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.
Petr Viktorin added the comment:
New changeset f1e17e9f97d9a4e97a5d99574775ee343a3a74fb by Petr Viktorin in
branch 'master':
bpo-34626: Document creating heap types from the C-API (GH-9154)
https://github.com/python/cpython/commit/f1e17e9f97d9a4e97a5d99574775ee343a3a74fb
Change by Petr Viktorin :
--
pull_requests: +13411
___
Python tracker
<https://bugs.python.org/issue37012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Petr Viktorin :
--
pull_requests: +13412
___
Python tracker
<https://bugs.python.org/issue37012>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Petr Viktorin :
If the PyObject_MALLOC() call failed in PyType_FromSpecWithBases(),
PyObject_Free() would be called on a static string in type_dealloc().
Fixed by Zackery Spytz in pull request 10304. I'm opening the issue
retroactively.
--
messages: 343194
nosy
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset d092caf096fa48baadfc0900792206bb5aa0192d by Petr Viktorin (Jeroen
Demeyer) in branch '3.7':
bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) (GH-13493)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
New changeset 33e71e01e95506cf8d93fd68251fc56352bc7b39 by Petr Viktorin (Marcel
Plch) in branch 'master':
bpo-31862: Port binascii to PEP 489 multiphase initialization (GH-4108)
https://github.com/python/cpython/commit/33e71e01e95506cf8d93fd68251fc56352bc7b39
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
Closing per discussion in https://github.com/python/cpython/pull/13357
--
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
We do, but here the test will need to be changed:
Python 3.7.3+ (heads/3.7:791e5fcbab, May 22 2019, 13:37:27)
[GCC 9.1.1 20190503 (Red Hat 9.1.1-1)] on linux
Type "help", "copyright", "credits" or "license" for
Petr Viktorin added the comment:
Jeroen, do you want to also do a backport for 3.7?
--
___
Python tracker
<https://bugs.python.org/issue36907>
___
___
Python-bug
Petr Viktorin added the comment:
New changeset 77aa396bb9415428de09112ddf6b34bb843811eb by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381)
https://github.com/python/cpython/commit/77aa396bb9415428de09112ddf6b34bb843811eb
Petr Viktorin added the comment:
All these issues are quite confusing. If PEP 590 is accepted, all of it will
need to be implemented. Why open separate issues for all the parts?
--
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
If and when a function uses the vectorcall protocol (including the argument
offset flag), it makes sense to rename it to vectorcall. Doing it before is
misleading, IMO.
Splitting fixes to unrelated issues (like bpo-36907) from PEP 590 is great, but
this one
Petr Viktorin added the comment:
Ah, sorry, I didn't get the message through.
I'll merge it with the rest of PEP 590. Adding the symbol doesn't make sense
*right* now.
--
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
Avoiding the duplication makes sense, but without the rest of PEP 590 it could
just be a static function in call.c.
--
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
Correct usage of multi-phase init might now get users stuck when they start
needing per-module state. See PEP 573 "Module State Access from C Extension
Methods" for the (hopefully) last thing that prevents me from generally
recommending multi-
Petr Viktorin added the comment:
Indeed, this is a good idea.
--
___
Python tracker
<https://bugs.python.org/issue36616>
___
___
Python-bugs-list mailin
Change by Petr Viktorin :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33261>
___
___
Pyth
Petr Viktorin added the comment:
New changeset fcef60f59d04c63b3540b4c4886226098c1bacd1 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-33261: guard access to __code__ attribute in inspect (GH-6448)
https://github.com/python/cpython/commit/fcef60f59d04c63b3540b4c4886226098c1bacd1
Petr Viktorin added the comment:
I just reviewed, and I plan to merge it if I don't see any pushback from the
others.
Sorry for the extreme delay.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue33
Petr Viktorin added the comment:
New changeset 364f0b0f19cc3f0d5e63f571ec9163cf41c62958 by Petr Viktorin (Eddie
Elizondo) in branch 'master':
bpo-35810: Incref heap-allocated types in PyObject_Init (GH-11661)
https://github.com/python/cpython/commit/364f0b0f19cc3f0d5e63f571ec9163cf41c62958
Petr Viktorin added the comment:
Joannah, yes, that looks like a good place. Eric Snow might have more info; he
wrote that module.
As for testing Py_FatalError, there's an assert_python_failure function in
test.support.script_helper
Petr Viktorin added the comment:
PyModule_GetState() gives you *per-module* state, not per-interpreter state.
Module objects are shared across subinterpreters, unless you use multi-phase
initialization.
> PyModule_GetState() requires having the module object that corresponds
> to the
Petr Viktorin added the comment:
Changing all types to heap types is definitely a gigantic task. First let's
make heap types more usable and bug-free, and then it will be easier :)
(I do have an agenda here: improving heap types usable is also yak-shaving* for
making modules play nice
Petr Viktorin added the comment:
I'll allocate time this week for the review.
--
___
Python tracker
<https://bugs.python.org/issue35810>
___
___
Python-bug
Petr Viktorin added the comment:
I would very much like to see this fixed.
Yes, it can make some extension types immortal, but I believe those types were
relying on buggy behavior, and need to be fixed to prevent memory leaks.
I think this is a big enough change to be mentioned in What’s New
Change by Petr Viktorin :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue10915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
Hi (and sorry for the delay -- it's a busy time of year).
Unfortunately, there's no good documentation yet. Python's standard library
itself is not free of global state, and I don't think we want to start
documenting before that's fixed
Petr Viktorin added the comment:
New changeset 4e80f5cbeaee87a26e49bc9623c92a10e28dbbd9 by Petr Viktorin (Paul
Ganssle) in branch 'master':
bpo-35186: Remove "built with" comment in setup.py upload (GH-10414)
https://github.com/python/cpython/commit/4e80f5cbeaee87a26e49bc9623c92a
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
Ah, XML is such an overengineered format!
Iusually live with the standard HTML entities but it turns out
you can define your own!
Here's a reproducer which shows how to do that.
--
nosy: +petr.viktorin
Added file: https://bugs.python.org/file47942
Change by Petr Viktorin :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue28709>
___
___
Petr Viktorin added the comment:
Should be fixed in PR9665 (bpo-34784), thanks to Eddie Elizondo.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue28
Petr Viktorin added the comment:
New changeset 474eedfb3d1b6fecbd749f36bf4a987cf4a00b44 by Petr Viktorin (Eddie
Elizondo) in branch 'master':
bpo-34784: Fix PyStructSequence_NewType with heap-allocated StructSequence
(GH-9665)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
New changeset 057f4078b044325dae4af55c4c64b684edaca315 by Petr Viktorin
(jdemeyer) in branch 'master':
bpo-32797: improve documentation of linecache.getline (GH-9540)
https://github.com/python/cpython/commit/057f4078b044325dae4af55c4c64b684edaca315
Petr Viktorin added the comment:
Actually, the scope (right balance between usefulness and maintainability) is
probably the hardest real problem to solve here.
PyPI lets you iterate on that. For a straight-to-stdlib module, you'd need to
get it exactly right on the first time
Petr Viktorin added the comment:
> I wasn't aware that starting out with a PyPI module is the only accepted
> process for getting functionality into stdlib.
It's the main way things should get in. (Other ways exist, for example,
dataclasses were added as simplification/merging of s
Petr Viktorin added the comment:
In the recommended library, distro, real-world issues blew the code size up to
1000 lines of code and the open issue count to 15 – so while it's definitely
useful, it doesn't seem either fully complete or trivial to maintain:
https://github.com/nir0s/distro
Change by Petr Viktorin :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue28604>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 2d3ff2b5ea6c903973f99d2155c9c1b60591dceb by Petr Viktorin in
branch 'master':
bpo-24937: Replace the extension module porting HOWTO by links to external
projects (GH-9317)
https://github.com/python/cpython/commit
Petr Viktorin added the comment:
Ah! It seems you don't need access to all tp_* slots of any type here, but just
to PyType.tp_new – only one specific type, and only one specific slot.
Specifically, you need a way to create class with a metaclass, from C.
Is that right? Or was this only
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 24f684692070f53b6f6e4dc67b9fe23dbd58655f by Petr Viktorin (Eitan
Adler) in branch 'master':
bpo-33486: regen autotools files using autoupdate+autoreconf (GH-6853)
https://github.com/python/cpython/commit/24f684692070f53b6f6e4dc67b9fe23dbd58655f
Petr Viktorin added the comment:
> If these changes are autogenerated, I would prefer that a trusted core
> developer create a PR.
I got the same changes in configure.ac.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.p
Change by Petr Viktorin :
--
nosy: -petr.viktorin
___
Python tracker
<https://bugs.python.org/issue24056>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
That issue has more information/discussion, and it does look like the same bug,
so I'll close this one.
Thank you for reporting it!
--
nosy: +petr.viktorin
resolution: -> duplicate
stage: -> resolved
status: open -> closed
s
Change by Petr Viktorin :
--
pull_requests: +8743
___
Python tracker
<https://bugs.python.org/issue24937>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
Well, hasn't this languished for a while.
I've talked with Benjamin, and he's OK with just removing the "Porting
Extension Modules to Python 3" HOWTO, and replacing it by links to external
guides that do a much better job at documenting this.
Al
Petr Viktorin added the comment:
1) If I understand correctly, this problem could be solved by per-class C
storage? Something like PyModuleDef.m_size / PyModule_GetState, but for classes?
2) Making PyType_GetSlot work for static types would not be trivial.
All types do have the same *basic
Petr Viktorin added the comment:
__subclasses__ is, as Tim Peters put it [0], "just Python exposing an
internal mechanism for the morbidly curious".
I'd expect that not all alternative implementations of Python have something
like __subclasses__ -- it's a detail of the impl
Petr Viktorin added the comment:
Thanks! I think that explains enough of the issue.
Converting static types to heap ones is just one way you can use PyType_Spec.
Another is writing new types, which should work much like Python classes.
So I don't think we should change the default
Petr Viktorin added the comment:
What's the use case for these?
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue34635>
___
___
Pytho
Change by Petr Viktorin :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> test_prlimit from test_resource fails when building python3
inside systemd-nspawn environment
___
Python tra
Petr Viktorin added the comment:
Check also discussion on issue31132.
If you agree, I'm OK with marking that one as duplicate, and removing the test.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue34
Petr Viktorin added the comment:
I'm not sure what tp_clear should do in this situation.
Other than propagating the exception to the GC, the most reasonable behavior
seems to be to write the exception to stderr and ignore it -- but I think
having the GC do that would be more robust.
IOW, I
Petr Viktorin added the comment:
Christian, do you have a specific example of the default tp_dealloc doing the
wrong thing?
--
___
Python tracker
<https://bugs.python.org/issue26
Petr Viktorin added the comment:
I don't think PEP 384 should be updated. It documents the feature as it was
added, and shouldn't be used as documentation now.
Instead, Python documentation should be improved to cover all of PEP 389.
I submitted a pull request for that (GH-9154
Petr Viktorin added the comment:
Converting static types to heap ones is just one of the reasons to use
PyType_FromSpec*. Another ones are writing such classes from scratch, and
converting pure-Python classes to C. I don't think PyObject_FailingNew is a
good default for either of those.
I
Petr Viktorin added the comment:
> The PEP 399 requires that C accelerator behaves exactly as Python, [...]
It does not. PEP 399 requires that that the C code must pass the same *test
suite*. And error messages in particular tend to not be checked in tests.
Anyway, I don't see
Petr Viktorin added the comment:
I don't think I have a good enough feel for what should, generally, go to 3.7.
So take my opinion with a grain of salt.
But honestly, I don't think the issue is important enough -- I've only seen one
codebase affected by it, which wasn't hard to fix
601 - 700 of 906 matches
Mail list logo