Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue16121>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13322>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12294>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13403>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15393>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue17188>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15819>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11566>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
nosy: -petri.lehtinen
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12606>
___
_
Changes by Petri Lehtinen <pe...@digip.org>:
--
status: open -> closed
title: Returned mail: see transcript for details -> Spam
___
Python tracker <rep...@bugs.python.org>
<http://bugs.
Changes by Petri Lehtinen <pe...@digip.org>:
Removed file: http://bugs.python.org/file40482/mail.zip
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Petri Lehtinen <pe...@digip.org>:
--
files: attachment.zip
nosy: petri.lehtinen
priority: normal
severity: normal
status: open
title: Hello
Added file: http://bugs.python.org/file40433/attachment.zip
___
Python tracke
Petri Lehtinen added the comment:
To me, there's also a valid use case on Unix; A parent process forks and execs,
wanting to share a socket to the executed child process. The best way for the
child to create a socket object is to use the fileno parameter of
socket.socket().
--
nosy
Petri Lehtinen added the comment:
Applied, thanks!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11694
Petri Lehtinen added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11694
___
___
Python-bugs-list mailing list
Unsubscribe
Petri Lehtinen added the comment:
The patch doesn't apply cleanly on 3.4 or default.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17188
Petri Lehtinen added the comment:
Is there a reason why this patch changes the decoding error handler to 'ignore'
(from the default 'strict')?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19806
New submission from Petri Lehtinen:
From Illirgway, https://github.com/akheron/cpython/pull/2:
Fix utf-8 bug, when symbol byte chain splits on 2 tcp-packets:
error: uncaptured python exception, closing channel (:'utf-8' codec can't
decode byte 0xd0 in position 1474: unexpected end of data
Petri Lehtinen added the comment:
A time object isn't associated with any date, so I don't really see a
problem here. The fact that you can shoot yourself in the leg can be
documented, noting that you should use datetime instead.
ISTM the reason why time objects even have an associated timezone
Petri Lehtinen added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17283
___
___
Python-bugs-list mailing list
Unsubscribe
Petri Lehtinen added the comment:
Fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14720
___
___
Python-bugs-list mailing list
Unsubscribe
Petri Lehtinen added the comment:
LGTM.
--
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17267
___
___
Python
Petri Lehtinen added the comment:
I'm investigating it now and will get back with a revised
fully tested patch.
Sounds good. FWIW, it only broke on 3.x and default branches, and you can
probably reproduce it on my own machine, too, by applying the patch and then
running test_netrc
Petri Lehtinen added the comment:
Serhiy Storchaka wrote:
convert_timestamp() can silently return wrong result if seconds
saved with more than millisecond precision (i.e. '2012-04-04
15:06:00.000123456'). I propose or truncate fractional part to 6
digits ('{:06.6}') or explicitly raise
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13952
___
___
Python-bugs-list
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5033
Petri Lehtinen added the comment:
Looks good to me, and all tests also pass on my Ubuntu 12.10.
Chris: Would you be willing to commit this and watch the buildbots do their
job? Or do the buildbots even use the -j option?
--
nosy: +petri.lehtinen
Petri Lehtinen added the comment:
Applied, thanks!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15132
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: - committed/rejected
status: open - closed
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14720
Petri Lehtinen added the comment:
Applied, thanks!
--
resolution: accepted - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8890
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16695
Petri Lehtinen added the comment:
The patch looks good to me.
--
nosy: +petri.lehtinen
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16709
Petri Lehtinen added the comment:
Added some comments to Rietveld.
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17267
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16403
Petri Lehtinen added the comment:
The patch should add something to the The from clause is used for
exception... paragraph, to state that None is also allowed.
It also adds things in a confusing order. I think the new example should go
below other examples, and the changedversion
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16121
Petri Lehtinen added the comment:
Reverted the patch because of the broken netrc tests. This has to be
investigated further.
--
resolution: fixed -
stage: committed/rejected - commit review
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
+1 for the documentation changes, which should be applied to 2.7 as well. The
deprecation is the only thing to go to 3.4 only, if it's done at all.
--
nosy: +petri.lehtinen
versions: +Python 2.7, Python 3.3
Petri Lehtinen added the comment:
Also note that getcode() is already documented in urllib (not urllib2)
documentation:
http://docs.python.org/2/library/urllib.html#urllib.urlopen
--
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
-setlocale(LC_CTYPE, );
+setlocale(LC_CTYPE, C);
This looks dangerous to me. Are you sure readline's behavior doesn't change
because of this?
--
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
Fixed.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8853
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8853
___
___
Python-bugs-list
Changes by Petri Lehtinen pe...@digip.org:
--
stage: test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8853
___
___
Python
Petri Lehtinen added the comment:
Attached a new patch with a test case and fixed error handling.
--
Added file: http://bugs.python.org/file28358/issue8853_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8853
Petri Lehtinen added the comment:
Committed, thanks for the patch!
I made little tweaks before committing:
- changed l1 to UTF-8 in the example (guess you mis-uploaded the latest version)
- changed the argument to 'replace' in test_r_1_replace
- fixed 3-space indentation to 4-space indentation
Petri Lehtinen added the comment:
Since Steven is not responding, I think I can commit it at some point. Thanks
for the remainder :)
--
assignee: - petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11175
Petri Lehtinen added the comment:
Right, good point. Lucas, could you fix the documentation too?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11175
Petri Lehtinen added the comment:
Should the defines be removed then, because they're kind of false promises for
the user.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12082
Petri Lehtinen added the comment:
Serhiy Storchaka wrote:
This can be done in compile time. Something like:
if ((uid_t)-1 0) ...
Ah, neat. I would have expected that to issue a compiler warning,
though, because the comparison is always true if the type is unsigned,
but at least gcc
Petri Lehtinen added the comment:
You probably should have used the word 'fix' rather than 'enhance' here:
else it smells like you're putting new features into a maintenance release.
:-)
Ah, true. But unfixable now :(
--
___
Python tracker rep
Petri Lehtinen added the comment:
Matti Mäki wrote:
I filled up the contributor form and gave it to Petri Lehtinen 2012-10-22
Yeah, and I posted it (along with 14 other contributor forms received
at PyCon Finland) to the PSF last week. They just seem to be a bit
slow to process them
Petri Lehtinen added the comment:
Christian Heimes wrote:
AFAIK C89 doesn't specify integer overflows:
Casting a signed integer to an unsigned integer is always defined, if
that's what you're talking about.
See http://flash-gordon.me.uk/ansi.c.txt, section 3.2.1.2.
If you're talking about
Petri Lehtinen added the comment:
LGTM. Steven?
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9351
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14897
Petri Lehtinen added the comment:
And that comment was meant for totally separate issue, sorry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15916
Petri Lehtinen added the comment:
+for key in vars(subnamespace):
+setattr(namespace, key, getattr(subnamespace, key))
There might be even more clever ways to achieve this, but what about at least
saying for key, value in vars(subnamespace).items(), and then using the value
Petri Lehtinen added the comment:
+for key in vars(subnamespace):
+setattr(namespace, key, getattr(subnamespace, key))
There might be even more clever ways to achieve this, but what about at least
saying for key, value in vars(subnamespace).items(), and then using the value
Petri Lehtinen added the comment:
Checking whether a type is unsigned in configure.ac might be cumbersome...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2005
Petri Lehtinen added the comment:
The fix was committed when 3.3.0 was in release candidate mode, and wasn't
considered important enough to be included in 3.3.0 anymore. It will be
included in 3.3.1, which is to be released next month
Petri Lehtinen added the comment:
LGTM. Let's wait for Steven's comments as he's the maintainer of argparse.
--
keywords: +needs review
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11175
Petri Lehtinen added the comment:
Andrew: Generally all changes deserve a Misc/NEWS entry, see:
http://docs.python.org/devguide/committing.html#news-entries
The feature was new in 3.3, but this change only went in after the release of
3.3.0, so ISTM that a Misc/NEWS entry is required
Petri Lehtinen added the comment:
Yeah, it seems that uid_t and gid_t can be signed or unsigned, while pid_t is
always signed.
Serhiy: What do you suggest?
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15132
___
___
Python-bugs-list
Petri Lehtinen added the comment:
Applied, thanks!
--
nosy: +petri.lehtinen
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15040
Petri Lehtinen added the comment:
Lucas: You only added tests for the repr, you should probably test the actual
new functionality, too.
--
nosy: +petri.lehtinen
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
Andew: Shouldn't Misc/NEWS be updated, too?
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16241
Petri Lehtinen added the comment:
Can this be closed?
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12686
___
___
Python
Changes by Petri Lehtinen pe...@digip.org:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11175
___
___
Python
Changes by Petri Lehtinen pe...@digip.org:
--
keywords: +patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list
Petri Lehtinen added the comment:
Can this be closed?
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13614
___
___
Python
Changes by Petri Lehtinen pe...@digip.org:
--
keywords: +easy
stage: - needs patch
versions: +Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15936
Petri Lehtinen added the comment:
cycle() doesn't use seq, but p (p0, p1, ...). Others use seq (seq[0], seq[1],
...). How do you think these should be changed?
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Petri Lehtinen added the comment:
Cannot reproduce, and cannot find the define in pyconfig.h. It's in
PC/pyconfig.h, but shouldn't affect compiling with gcc.
--
nosy: +petri.lehtinen
status: open - pending
___
Python tracker rep...@bugs.python.org
Petri Lehtinen added the comment:
On MinGW? I'm not a Windows user, but IIRC building extensions with gcc on
MinGW has many problems and isn't officially supported.
--
components: +Windows -None
nosy: +brian.curtin, loewis, tim.golden
___
Python
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13886
___
___
Python-bugs-list mailing
Petri Lehtinen added the comment:
Fixed, thanks!
--
keywords: -needs review
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15222
Petri Lehtinen added the comment:
Attached an updated version of the second patch. David: Is this what you meant?
Also, the patch format should now be rietveld compatible :)
--
Added file:
http://bugs.python.org/file27188
Changes by Petri Lehtinen pe...@digip.org:
Removed file:
http://bugs.python.org/file27188/issue15222_v2_0002_insert_blank_after_each_message_in_mbox.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15222
Changes by Petri Lehtinen pe...@digip.org:
Added file:
http://bugs.python.org/file27189/issue15222_v2_0002_insert_blank_after_each_message_in_mbox.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15222
Petri Lehtinen added the comment:
Attaching a patch that changes all single-file mailboxes to be rewritten
in-place instead of rewriting and renaming. The patch doesn't add an option,
because IMO this should be the default behavior.
In addition to solving the locking problems, this makes
Changes by Petri Lehtinen pe...@digip.org:
Added file: http://bugs.python.org/file27150/issue15122.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15122
Petri Lehtinen added the comment:
This would be considered a new feature, and is thus out of scope for 2.7. An
easy workaround is to encode the unicode path to str using the file system
encoding first (sys.getfilesystemencoding()).
--
resolution: - rejected
stage: needs patch
Changes by Petri Lehtinen pe...@digip.org:
--
keywords: +easy
nosy: +petri.lehtinen
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14922
Petri Lehtinen added the comment:
Since this problem is specific to 2.7, the offending line is actually
http://hg.python.org/cpython/file/2.7/Lib/aifc.py#l344:
344 if type(f) == type(''):
--
components: +Library (Lib) -None
keywords: +easy
nosy: +petri.lehtinen
stage: - needs
Petri Lehtinen added the comment:
My fellow coredevs confirm that this would be a new feature, so it's out of
scope for 2.7 (which is in bugfix-only mode). It's also deterministic in the
sense that you can easily work around it by encoding the unicode filename to
the filesystem encoding first
Petri Lehtinen added the comment:
Fixed, see #13769.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14042
___
___
Python-bugs-list mailing list
Petri Lehtinen added the comment:
Techincally, converting to int is not necessary, because the number of digits
in the unix timestamp doesn't change until year 2286 :)
The patch looks good to me. I don't think comparing pairs would be any more
readable than what the proposed patch does
Petri Lehtinen added the comment:
Fixed, thanks.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15802
Petri Lehtinen added the comment:
Fixed, thanks.
--
keywords: -needs review
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13769
Petri Lehtinen added the comment:
In 3.3, Makefile.pre.in already defines MKDIR_P, in 3.2 it doesn't.
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15819
Petri Lehtinen added the comment:
Attached yet another patch. It explains what input causes the result to be
unicode instead of str.
--
Added file: http://bugs.python.org/file27064/issue13769_v3.patch
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
Attached an updated patch, which is more explicit on what ensure_ascii actually
does.
--
Added file: http://bugs.python.org/file27049/issue13769_v2.patch
___
Python tracker rep...@bugs.python.org
http
Petri Lehtinen added the comment:
Fixed, thanks.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
Petri Lehtinen added the comment:
Well, I wasn't sure about [optional] params before **kwargs. But if that's ok,
then I think the patch is good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14880
Petri Lehtinen added the comment:
No activity in 2 years, closing.
--
nosy: +petri.lehtinen
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9668
Petri Lehtinen added the comment:
Bear in mind that Douglas Crockford thinks a JSON document is valid even if it
contains unpaired surrogates:
http://tech.groups.yahoo.com/group/json/message/1603
http://tech.groups.yahoo.com/group/json/message/1583
It's Unicode that considers unpaired
Petri Lehtinen added the comment:
It may also be unicode if the encoding parameter is used even if there are no
unicode objects in the input.
json.dumps([u'Ş'.encode('iso-8859-9')], encoding='iso-8859-9',
ensure_ascii=False)
u'[\u015e
Petri Lehtinen added the comment:
This is a documentation bug for 2.7. Setting as duplicate of #13769.
--
nosy: +petri.lehtinen
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - closed
superseder: - json.dump(ensure_ascii=False) return str instead
Petri Lehtinen added the comment:
Attached a patch for 2.7 that updates docs and docstrings.
--
keywords: +needs review, patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file27032/issue13769.patch
___
Python tracker rep
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13769
___
___
Python-bugs-list mailing
1 - 100 of 600 matches
Mail list logo
