[issue16038] ftplib: unlimited readline() from connection

2014-09-03 Thread Radu Voicilas
Radu Voicilas added the comment: I'm a little confused about this patch. Please correct me if I'm wrong, but fp.readline([size + 1]) should return a line of length at most size + 1. This means that the check len(line) size will always be true when reading a line that has a length greater

[issue18652] Add itertools.first_true (return first true item in iterable)

2013-08-23 Thread Radu Voicilas
Changes by Radu Voicilas radu.voici...@gmail.com: -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18652 ___ ___ Python-bugs-list

[issue17491] Consolidate traceback.format_tb and traceback.print_tb

2013-03-27 Thread Radu Voicilas
Radu Voicilas added the comment: Is there anything else that I have to do in order for this patch to be looked at ? I am holding off a similar one for print_exception vs. format_exception -- ___ Python tracker rep...@bugs.python.org http

[issue17502] unittest.mock: side_effect iterators ignore DEFAULT

2013-03-27 Thread Radu Voicilas
Changes by Radu Voicilas radu.voici...@gmail.com: -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17502 ___ ___ Python-bugs-list

[issue17504] Dropping duplicated docstring explanation of what Mocks' side_effect does.

2013-03-21 Thread Radu Voicilas
New submission from Radu Voicilas: Seems like there's a duplicated explanation in unittest.mock.Mock's docstring of what side_effect does. The attached patch should take care of that, if I'm not interpreting it wrong and it's actually on purpose there. -- components: Library (Lib

[issue17491] Consolidate traceback.format_tb and traceback.print_tb

2013-03-19 Thread Radu Voicilas
New submission from Radu Voicilas: This is a patch that consolidates the implementation of traceback.format_tb and traceback.print_tb into one common internal function traceback._get_tb. The current implementations are almost identical, except that the print_tb() ones also prints to a file

[issue17464] Improve Test Coverage Of Pydoc

2013-03-18 Thread Radu Voicilas
Radu Voicilas added the comment: Hi, Here are some small comments to your otherwise good to have patch: -- assertEquals has been deprecated in favor of assertEqual, and usually it's great to be consistent across the test suite -- likewise maxDiff should be max_diff mainly because

[issue17453] logging.config.fileConfig error

2013-03-18 Thread Radu Voicilas
Radu Voicilas added the comment: Even though it seems kind of weird to have all those keys set to the empty string, I still think that configparser should handle this case, which might be relevant for some other uses cases (not logging configs). The attached patch should take care

[issue9554] test_argparse.py: use new unittest features

2012-05-21 Thread Radu Voicilas
Radu Voicilas radu.voici...@gmail.com added the comment: Hi Eric, Denver's patch should apply correctly from the root. Also, I've made the changes you mention: try: except: assert has been replaced by: with self.assertRaises() -- Added file: http://bugs.python.org/file25659

[issue9554] test_argparse.py: use new unittest features

2012-05-20 Thread Radu Voicilas
Radu Voicilas radu.voici...@gmail.com added the comment: The patch is still valid - it applies ok. The only issues as mentioned by sandro.tosi are offsets and that it was generated inside Lib/ It would be worth having these changes applied. -- nosy: +raduv

[issue12355] Crawler doesn't follow redirection

2012-05-20 Thread Radu Voicilas
Radu Voicilas radu.voici...@gmail.com added the comment: I can no longer reproduce the issue on tip. Here's the output I get trying to do c.get_releases('webob'): $ ./python issue12355.py version has not been parsed: WebOb-0.8.3-py2.5 version has not been parsed: WebOb-0.9.1-py2.4 version has