Radu Voicilas added the comment:
I'm a little confused about this patch. Please correct me if I'm wrong, but
fp.readline([size + 1]) should return a line of length at most size + 1. This
means that the check len(line) size will always be true when reading a line
that has a length greater
Changes by Radu Voicilas radu.voici...@gmail.com:
--
nosy: +raduv
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18652
___
___
Python-bugs-list
Radu Voicilas added the comment:
Is there anything else that I have to do in order for this patch to be looked
at ? I am holding off a similar one for print_exception vs. format_exception
--
___
Python tracker rep...@bugs.python.org
http
Changes by Radu Voicilas radu.voici...@gmail.com:
--
nosy: +raduv
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17502
___
___
Python-bugs-list
New submission from Radu Voicilas:
Seems like there's a duplicated explanation in unittest.mock.Mock's docstring
of what side_effect does. The attached patch should take care of that, if I'm
not interpreting it wrong and it's actually on purpose there.
--
components: Library (Lib
New submission from Radu Voicilas:
This is a patch that consolidates the implementation of traceback.format_tb and
traceback.print_tb into one common internal function traceback._get_tb. The
current implementations are almost identical, except that the print_tb() ones
also prints to a file
Radu Voicilas added the comment:
Hi,
Here are some small comments to your otherwise good to have patch:
-- assertEquals has been deprecated in favor of assertEqual, and usually it's
great to be consistent across the test suite
-- likewise maxDiff should be max_diff mainly because
Radu Voicilas added the comment:
Even though it seems kind of weird to have all those keys set to the empty
string, I still think that configparser should handle this case, which might be
relevant for some other uses cases (not logging configs).
The attached patch should take care
Radu Voicilas radu.voici...@gmail.com added the comment:
Hi Eric, Denver's patch should apply correctly from the root. Also, I've made
the changes you mention:
try: except: assert
has been replaced by:
with self.assertRaises()
--
Added file: http://bugs.python.org/file25659
Radu Voicilas radu.voici...@gmail.com added the comment:
The patch is still valid - it applies ok. The only issues as mentioned by
sandro.tosi are offsets and that it was generated inside Lib/
It would be worth having these changes applied.
--
nosy: +raduv
Radu Voicilas radu.voici...@gmail.com added the comment:
I can no longer reproduce the issue on tip. Here's the output I get trying to
do c.get_releases('webob'):
$ ./python issue12355.py
version has not been parsed: WebOb-0.8.3-py2.5
version has not been parsed: WebOb-0.9.1-py2.4
version has
11 matches
Mail list logo