Rik added the comment:
Line wrapping is indeed done by `Header`, but why do `base64mime` and
`quoprimime` then have their own line wrapping? I assume so that you can also
use them independently. So that's why I would think `Charset.header_encode`
should also accept a `maxlinelen` so that you
Rik added the comment:
Ok, so you suggest to use `maxlinelen=None` for the `base64mime.header_encode`
which will act the same as giving `maxlinelen=None` to `email.quoprimime`, so
that we don't need to change the API?
And this change would then also be reflected in the Python 3.5 legacy
Rik added the comment:
Ok, do you think there's any risk in making `base64mime.header_encode` handle
`maxlinelen=None`? I think it would be more consistent if
`base64mime.header_encode` and `quoprimime.header_encode` interpret their
arguments similarly
New submission from Rik:
If you look at the `header_encode` method in the `Charset` class in
`email.charset`, you'll see that depending on the `header_encoding` that is set
on the `Charset` instance, it will either encode it using base64 or
quoted-printable (QP):
http://hg.python.org/cpython
Rik Poggi poggi.ri...@gmail.com added the comment:
I wasn't trying to make any argument, just thinking that such particular
signature was intentional.
Also notice that there might be code that doesn't pass the pattern argument,
and fall back on the default value. So a signature change
Rik Poggi poggi.ri...@gmail.com added the comment:
Moving on, I've understood what the bug is about. I've made a couple of tests
for this issue. I'm waiting for a review before adding others (if necessary).
The fix is not going to be easy, because I'm not sure about the Metadata design.
I
Rik Poggi poggi.ri...@gmail.com added the comment:
I think the doc should be improved
(http://docs.python.org/library/unittest.html#load-tests-protocol), it's not
clear how pattern in the example (last one) could not be None.
Changing the discover signature doesn't seem to be an option since
Rik Poggi poggi.ri...@gmail.com added the comment:
Thanks, I'll wait! In the meanwhile I couldn't help to dig a little deeper and
found that the Metadata class is currently logging a warning. Should the
commands raise something when there's a warning in strict mode?
I was playing
Rik Poggi poggi.ri...@gmail.com added the comment:
My assumption that the random log message was related to this bug seems to be
completely wrong. It seems, instead, related to a starstar call of create_dist
in the support module that will loose the order (of an OrderedDict obviously
Rik Poggi poggi.ri...@gmail.com added the comment:
Hi, I'd like to contribute to this bug if it's possible.
I would've directly started, but it seems the situation has moved/changed a
bit, so I'm not sure where the tests are needed.
There's a try/except, like the one mentioned above, in pypi
Rik Poggi poggi.ri...@gmail.com added the comment:
Strictly related or not to this bug, a bit more test coverage shouldn't hurt.
So while waiting for a reply I started writing a couple of tests for
pypi/dist.py, hope they look good.
--
Added file: http://bugs.python.org/file25134
11 matches
Mail list logo
