Robin Schreiber added the comment:
Antoine, regarding that the last pending problem with the patch is related to
the NULL checking of FindModule, I would be inclined to include your proposed
helper API. I see that issue18710 has not been included into the trunk yet, but
I think this is mostly
Robin Schreiber added the comment:
Updated patch accordingly.
Regarding the problem in
http://mail.python.org/pipermail/python-dev/2013-August/127862.html , it can
indeed be solved by returning the already existing module object, if PyInit is
called multiple times. I followed the discussion
Robin Schreiber added the comment:
Everything except for the Xxo_Type. But you are right. Then again, why are
these global static variables from the start? Isn't this because xxmodule is
some kind of dummy module that is supposed to demonstrate some coding
conventions on how to build
Robin Schreiber added the comment:
Updated the patch, corrected multiple syntax errors and missing INCREFS. Also
added the comments that include the members names. I am yet undecided regarding
the NULL-check for FindModule.
Apart from that I have tried to build some tests that prove
Robin Schreiber added the comment:
I have in fact used abitype.py to produce all of my PEP 384 patches, however it
failed to work correctly in like 50% of all cases, and I had to complete the
rest of the patch by hand.I thought about correcting the abitype.py throughout
the GSOC, but I
Robin Schreiber added the comment:
I absolutely agree on mentioning the member names in the comments. :-)
In the example Martin gave in his PEP 3121, the PyInit does not perform any
INCREFs on the Variables that are referenced from inside the module state.
He therefore left out m_free
Robin Schreiber added the comment:
Patch updated to work with current 3.4 Branch version of elementtree.
--
keywords: +patch
Added file: http://bugs.python.org/file28311/_elementtree_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated patch to work with 3.4 Branch version of _struct.c
--
keywords: +patch
Added file: http://bugs.python.org/file28315/_struct_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated parsermodule patch to work with 3.4 Branch version.
--
keywords: +patch
Added file: http://bugs.python.org/file28316/parser_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http
Robin Schreiber added the comment:
Updated posixmodule to work with the 3.4 Branch version.
--
keywords: +patch
Added file: http://bugs.python.org/file28317/posix_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Robin Schreiber added the comment:
I have updated the patch to work again with the current version of the
_datetimemodule.
Regarding the suggestion of separating PEP3121 and PEP384. It might be true
that datetime and other modules do not benefit directly from PEP 384, however
it is still
Robin Schreiber added the comment:
Here is revised version of the patch.
Martin von Löwis and I had discovered a way to reproduce problems with
refactored modules, that
occur without this patch. This is was several months ago, however I will try to
give you a code sample
Robin Schreiber added the comment:
Take a look at the discussion in Issue 15653.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15650
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15721
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15650
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15390
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15727
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15848
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15711
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15735
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15734
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15729
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15653
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15668
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15672
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15675
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15674
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15673
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15671
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15670
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15669
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15667
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15666
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15665
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15662
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15652
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15654
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15651
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15714
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15713
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15712
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15709
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15708
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15707
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15706
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15705
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15704
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15703
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15700
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15699
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15698
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15697
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15691
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15690
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15689
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15688
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15687
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15686
___
___
Python
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15685
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15681
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15680
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15684
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15682
Changes by Robin Schreiber robin.schrei...@me.com:
--
keywords: +pep3121 -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15389
___
___
Python
Robin Schreiber added the comment:
PEP384 demands, among other things, that the TypeObjects themselves are
transformed to Heaptypes. This means that the Typeobjects, that are created
from this new stable ABI, reside within the heap and therefore have to be
managed by the Python GC
Robin Schreiber added the comment:
Before I submitted this patch, I used to have these variables inside the
modulestate, which caused severe problems. I do not know the exact reason, but
my guess is that these variables have to be globally available for every thread
(tcl variables are used
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the xxsubtype
module!
--
components: Extension Modules
files: xxsubtype_pep3121-384_v0.patch
keywords: patch
messages: 169701
nosy: Robin.Schreiber, belopolsky
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the xx module!
--
components: Extension Modules
files: xxmodule_pep3121-384_v0.patch
keywords: patch
messages: 169702
nosy: Robin.Schreiber, belopolsky
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the winapi
module!
--
components: Extension Modules
files: _winapi_pep3121-384_v0.patch
keywords: patch
messages: 168639
nosy: Robin.Schreiber, astrand, effbot, loewis
priority: normal
Robin Schreiber added the comment:
Forgot to change the macro definition...
--
Added file: http://bugs.python.org/file26922/_winapi_pep3121-384_v1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the spwd module!
--
components: Extension Modules
files: spwd_pep3121-384_v0.patch
keywords: patch
messages: 168641
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the ossaudio
module!
--
components: Extension Modules
files: ossaudiodev_pep3121-384_v0.patch
keywords: patch
messages: 168642
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
This small patch prevents PyType_FromSpecWithBases, from setting the base(s)
attribute of the HeapType to NULL-values.
--
components: Interpreter Core
files: PyType_FromSpecWithBases_bases_fix.patch
keywords: patch
messages: 168570
nosy
New submission from Robin Schreiber:
Fixed wrong list-length comparison in PyState_FindModule.
--
components: Interpreter Core
files: PyState_FindModule_LE_fix.patch
keywords: patch
messages: 168572
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15726
___
___
Python-bugs-list
Changes by Robin Schreiber robin.schrei...@me.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python-bugs-list
New submission from Robin Schreiber:
As with every type, that has been created and initialized, HeapTypes created
form PyType_FromSpecWithBases() have to pass through PyType_Ready(). Here the
function inherit_special might be called, which, among other things, does the
following:
3892
New submission from Robin Schreiber:
To create a HeapType from Structseq description, there is the helpful, yet
undocumented PyStructSequence_NewType Method, which can do just that.
Until now, this method solely allocates some generic TypeObject on which it
then performs
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the tkinter
module!
When running the test form inside Python.exe (tkinter._test()), the litte
test-window is rendered correctly. However there are still some error
messages popping up inside
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the decimal
module!
--
components: Regular Expressions
files: _decimal_pep3121-384_v0.patch
keywords: patch
messages: 168511
nosy: Robin.Schreiber, ezio.melotti, mrabarnett, skrah
Changes by Robin Schreiber robin.schrei...@me.com:
--
components: +Extension Modules -Regular Expressions
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
Robin Schreiber added the comment:
I have removed some redundant modulestate lookups and the testsuite now
executes the decimal tests as fast as before the patch is applied. (at least
for me).
May I ask how you tested the decimal performance?
Regarding the failing test:
It appears
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the audioop module!
--
components: Extension Modules
files: audioop_pep3121_v0.patch
keywords: patch
messages: 168353
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the binascii module!
--
components: Extension Modules
files: binascii_pep3121_v0.patch
keywords: patch
messages: 168354
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the fpectl module!
--
components: Extension Modules
files: fpectl_pep3121_v0.patch
keywords: patch
messages: 168355
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the fpetest
module!
--
components: Extension Modules
files: fpetest_pep3121_v0.patch
keywords: patch
messages: 168357
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the itertools
module!
--
components: Extension Modules
files: itertools_pep3121-384_v0.patch
keywords: patch
messages: 168359
nosy: Robin.Schreiber, rhettinger
priority: normal
severity
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the md5 module!
--
components: Extension Modules
files: md5_pep3121-384_v0.patch
keywords: patch
messages: 168360
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the mmap module!
--
components: Extension Modules
files: mmap_pep3121-384_v0.patch
keywords: patch
messages: 168361
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the nis module!
--
components: Extension Modules
files: nis_pep3121_v0.patch
keywords: patch
messages: 168362
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the operator
module!
--
components: Extension Modules
files: operator_pep3121-384_v0.patch
keywords: patch
messages: 168363
nosy: Robin.Schreiber
priority: normal
severity: normal
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the parser
module!
--
components: Extension Modules
files: parser_pep3121-384_v0.patch
keywords: patch
messages: 168364
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the posix
module!
--
components: Extension Modules
files: posix_pep3121-384_v0.patch
keywords: patch
messages: 168367
nosy: Robin.Schreiber
priority: normal
severity: normal
status
New submission from Robin Schreiber:
Changes proposed in PEP3121 have now been applied to the pwd module!
--
components: Extension Modules
files: pwd_pep3121_v0.patch
keywords: patch
messages: 168403
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121
New submission from Robin Schreiber:
Changes proposed in PEP3121 and PEP384 have now been applied to the pyexpat
module!
--
components: Extension Modules
files: pyexpat_pep3121-384_v0.patch
keywords: patch
messages: 168404
nosy: Robin.Schreiber
priority: normal
severity: normal
status
1 - 100 of 164 matches
Mail list logo
