Ron Adam added the comment:
Adding you Nick, I don't have commit rights. This probably doesn't need much..
maybe a one line comment in news is all. (And maybe not even that.)
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http
New submission from Ron Adam:
Shouldn't at least isdecimal return True?
'123.0'.isdecimal()
False
'123.0'.isalnum()
False
'123.0'.isnumeric()
False
'123.0'.isdigit()
False
--
components: Interpreter Core
messages: 195186
nosy: ron_adam
priority: normal
severity: normal
status: open
Ron Adam added the comment:
I get the same resluts if I make the string by str(123.0). I was thinking it
should test True for the isdecimal case for that.
It seems I missunderstood their purpose/use. This seems like it would be a
very common misunderstanding.
It appears, (Because it isn't
Changes by Ron Adam ron3...@gmail.com:
Removed file: http://bugs.python.org/file30922/pdoc_symbols.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
Ron Adam added the comment:
Patch update: removed from pydoc symbols table.
--
Added file: http://bugs.python.org/file30931/pdoc_symbols.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
Ron Adam added the comment:
I agree the specific content for each symbol are separate issues. Those are
probably best addressed individually or a few at a time when they are closely
related.
--
___
Python tracker rep...@bugs.python.org
http
Ron Adam added the comment:
Regarding opertor.get_op:
Look at help(symbols) output for consistancy. There may be items in one that
can be included in the other.
The operator.get_op addition would be useful for improving help on the symbol
information for help/pydoc. Currently it seems
Ron Adam added the comment:
Thanks for catching that. I had used unquote_plus instead of unquote. That is
needed for multi-field form data, pydoc doens't need it.
Removed the back tick from the pydoc symbols list. The topic link for that
symbol was already removed.
I also attempted
Ron Adam added the comment:
Updated the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
___
___
Python-bugs-list mailing list
Changes by Ron Adam ron3...@gmail.com:
Removed file: http://bugs.python.org/file30843/pdoc_symbols.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
Changes by Ron Adam ron3...@gmail.com:
Removed file: http://bugs.python.org/file30831/pdoc_symbols.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
Ron Adam added the comment:
New slightly improved patch. Combined the topic index's, topics, keywords, and
the new symbols case, into a single html_topicsindex(title) function.
--
Added file: http://bugs.python.org/file30843/pdoc_symbols.diff
New submission from Ron Adam:
This patch adds a 'symbols' link after the 'topics' and 'keywords' links in the
html browser menu bar.
help('symbols') worked, but there was no way to get to it in the html browser.
This also adds unquote_plus() to the url handler to unquote the html input form
Changes by Ron Adam ron3...@gmail.com:
--
title: Add 'symbols' link to html menu bar. - Add 'symbols' link to pydoc's
html menu bar.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18387
Ron Adam added the comment:
I'm going to go over this issue again with fresh eyes after having been away
for some time.
Recent experience with another project has helped answer some of the questions
I had earlier. Particulary, how not to over specifying class names and id's.
This should
Ron Adam ron3...@gmail.com added the comment:
What about having idle open a web browser session with pydocs new browse option?
python3 -m pydoc -b
We've added input fields to the pages that take the same input as help()
command does. It also links to the online help pages, and you can view
Changes by Ron Adam ron3...@gmail.com:
Removed file: http://bugs.python.org/file24047/f_why1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13607
Ron Adam ron3...@gmail.com added the comment:
Updated patch with suggested changes.
It also has a cleaned up fast_block_end section.
Concerning speed. What happens is (as Tim and Raymond have pointed out) that we
can make some things a little faster, in exchange for other things being
Ron Adam ron3...@gmail.com added the comment:
I think the time benefits I saw are dependent on how the C code is compiled.
So it may be different on different compilers or the same compiler with only a
very minor change.
Some of the things I've noticed...
A switch is sometimes slower
Changes by Ron Adam ron3...@gmail.com:
Removed file: http://bugs.python.org/file23969/f_why.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13607
Ron Adam ron3...@gmail.com added the comment:
New diff file.
The main difference is I moved the saved why value to the tstate object instead
of the frame object as why_exit.
I'm not seeing the time savings now for some reason. Maybe the previous
increase was a case of coincidental noise
New submission from Ron Adam ron3...@gmail.com:
The following changes cleanup the eval loop and result in a pretty solid 2 to
3% improvement in pybench for me.
And it is about 5% faster for long generators.
* Change why enum type to int and #defines. And moved the why defines to
opcode.h so
Ron Adam ron3...@gmail.com added the comment:
A simple test to show the difference.
BEFORE:
$ python3 -mtimeit def y(n): for x in range(n): yield x
sum(y(10))
10 loops, best of 3: 3.87 usec per loop
$ python3 -mtimeit def y(n): for x in range(n): yield x
sum(y(100))
10
Ron Adam ron3...@gmail.com added the comment:
Thanks for the updated links Nick.
There is a comment in the docs that recommends putting parentheses around any
yield expression that returns a value. So it is in agreement with that in the
function argument case.
The grammar I used does keep
Ron Adam ron3...@gmail.com added the comment:
There is a test for 'yield from' as a function argument without the extra
parentheses.
f(yield from x)
You do need them in the case of a regular yield.
f((yield)) or f((yield value))
Shouldn't the same rule apply in both cases
Ron Adam ron3...@gmail.com added the comment:
Instead of a get_instructions() function, How about using a DisCode class that
defines the API for accessing Opinfo tuples of a disassembled object.
So instead of...
for instr in dis.bytecode_instructions(thing):
process(instr)
You
Changes by Ron Adam ron3...@gmail.com:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13062
___
___
Python-bugs-list mailing
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2571
___
___
Python-bugs-list
New submission from Ron Adam ron_a...@users.sourceforge.net:
There doesn't seem to be any references to it in any other part of pydoc, or
the Library for that matter. Searching for it on google code search (and also
google web search) only turns up auto generated API references for python
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9364
___
___
Python-bugs-list
Ron Adam ron_a...@users.sourceforge.net added the comment:
I agree. It is close enough to be a duplicate. I suggest closing it.
As Ka-Ping noted in the other issue:
There's a link to the base class provided if you want to find out what the
base class does.
This is easy to do if your viewing
Ron Adam ron_a...@users.sourceforge.net added the comment:
A reminder: Check for instances where html.escape is not called on data
inserted into the html pages.
I'll update the patch as the non-css (error handling) parts made it into python
3.2
Ron Adam ron_a...@users.sourceforge.net added the comment:
New and hopefully last patch... pydoc_misc_fix_e.diff
I removed the .html in the ?key= links as Eric suggested.
I checked the navbar float behavior on browsershots.org. Multiple versions of
MSIE, firefox, opera, chrome, and safari
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20473/pydoc_misc_fix_c.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10961
Ron Adam ron_a...@users.sourceforge.net added the comment:
George, My apologies to you for the late corrections. And thanks for doing
this.
Eric, I replied to your comments on Rietveld. Thanks for taking a look.
I'll wait until you have a chance to reply and test it, then upload a new patch
New submission from Ron Adam ron_a...@users.sourceforge.net:
A collection of small fix's that only effect the new browser mode.
* Change title of html pages from Python ... to PyDoc
* Fixed unterminated div float for items returned without a header.
example: str, None, True
Ron Adam ron_a...@users.sourceforge.net added the comment:
new patch...
Adjusted a comment in the _gettopic method.
Everything else the same.
--
Added file: http://bugs.python.org/file20468/pydoc_misc_fix.diff
___
Python tracker rep
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20467/pydoc_misc_fix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10961
Ron Adam ron_a...@users.sourceforge.net added the comment:
A few last minute changes.. I think this will be all.
Run topic contents through html.markup. That makes ref:, pep:, and html: links
if they exist. (I meant to this earlier.)
Fix case where topic reference links are to objects
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20468/pydoc_misc_fix.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10961
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +eric.araujo, rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10961
Ron Adam ron_a...@users.sourceforge.net added the comment:
Yes, you are correct. Pulling the first value off of args would work.
This is new for 3.2, can it still be changed?
One more thing to consider...
One of the things I look at for functions like these is, how easy is it to
separate
Ron Adam ron_a...@users.sourceforge.net added the comment:
Why is this surprising?
def foo(c, c=None):
... pass
...
File stdin, line 1
SyntaxError: duplicate argument 'c' in function definition
In the previous examples, it finds the duplicate at run time instead of compile
time due
Ron Adam ron_a...@users.sourceforge.net added the comment:
Is this issue referring to something in Python's library, or a hypothetical
function someone may write?
If it's in the library, we can look at that case in more detail, otherwise,
it's just a bad program design issue and there's
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is the whole method for reference...
def submit(self, fn, *args, **kwargs):
with self._shutdown_lock:
if self._shutdown_thread:
raise RuntimeError('cannot schedule new futures after shutdown
Ron Adam ron_a...@users.sourceforge.net added the comment:
Change...
are never unpacked within submit.
to...
Are completely separate.
It's the attempt to mix two function signatures together as one, that was/is
the problem
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is a patch for this. Not much to it as the hard parts were already done.
Apparently there was no tests for this, test_pydoc still passes without it.
Does there need to be any messages for the -g option? Pydoc help is displayed
Ron Adam ron_a...@users.sourceforge.net added the comment:
No refactoring is needed.
The second copies are part of the new server. The old server was depreciated
in 3.2 and is supposed to be removed along with the tk panel for 3.3. After
that there will only be one of each again
Ron Adam ron_a...@users.sourceforge.net added the comment:
If the colors are passed directly to the HTML they should be
removed and left to the CSS(s) only. I don't know the code
well enough to say if this is doable and/or if it requires a
deprecation first;
We may have to do dome
Ron Adam ron_a...@users.sourceforge.net added the comment:
To go forward I can create a new private api instead of changing HTMLDoc, that
would be preferable.
Should the -w option also use the new html pages? Or do we need a new option
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is a new diff which updates all the new pydoc pages to use the css file.
The css file is simpler and cleaner. I also made a few adjustments to the url
handler error handling, and changed the titles in the head sections so
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20081/defaultstyle.css
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10716
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20088/pydoc sample html files.zip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10716
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file20183/css_v1.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10716
Ron Adam ron_a...@users.sourceforge.net added the comment:
The HtmlDoc class has methods that take colors. Can this be changed or does it
need to be depreciated first?
def heading(self, title, fgcol, bgcol, extras=''):
Format a page heading.
return '''
table width=100
Ron Adam ron_a...@users.sourceforge.net added the comment:
It may be useful to change those to 'id=' and 'class=' if possible.
It isn't clear to me how much of pydoc is still part of the public api in
python 3.x. pydoc.__all__ is set only to ['help'].
Entering help(pydoc) just gives
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is a tentative start on this. (css_v1.diff)
The css file is much better. It's shorter, simpler and validated.
The header and navbar panel use it in the new server.
Added a markup call to the topic page contents. (The same
Ron Adam ron_a...@users.sourceforge.net added the comment:
The issue10573.diff file with the time stamp 20:03 has a lot of document
changes that don't have corresponding code changes?
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10087
___
___
Python-bugs
Ron Adam ron_a...@users.sourceforge.net added the comment:
The problem is in the following line...
return ''.join(v).encode(encoding, xmlcharrefreplace)
The .encode(encoding, xmlcharrefreplace) is returning a bytes object.
Here is the simplest change to resolve the problem.
return
Ron Adam ron_a...@users.sourceforge.net added the comment:
Oops. You're right.
I miss understood how the encode method works in this particular case. ;-/
I agree with your comments as well.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8916
___
___
Python-bugs-list
Ron Adam ron_a...@users.sourceforge.net added the comment:
I uploaded the css file I used in an experimental version of pydoc. It may
give some useful starting values.
Before this is done, the old server code should be removed (also for 3.3).
(another issue?) There are two files
Ron Adam ron_a...@users.sourceforge.net added the comment:
Eric, most of what's in that file is what I figured out by trial and error in
order to get it to work on the different browsers at that time. (about 3 years
ago.) You are probably more experienced with css than I am, so you are more
Ron Adam ron_a...@users.sourceforge.net added the comment:
I think that's how I ended up with the style sheet I uploaded. It works, but
it can be a slow process.
Another factor is the pydoc server will reread an external style sheet on
browser refreshes. So you can see the results of style
Ron Adam ron_a...@users.sourceforge.net added the comment:
Ok, I just looked at them again, I didn't remember how different it was. They
probably won't be much help other than maybe seeing how some things could be
done. Here's a zip file of some saved pages, so you can take a look
Ron Adam ron_a...@users.sourceforge.net added the comment:
Pydoc skips the badsysntax_pep3120 file for now. When this gets fixed that
workaround should be removed. The work around is commented and refers to this
issue #.
--
___
Python tracker rep
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10588
___
___
Python-bugs
Ron Adam ron_a...@users.sourceforge.net added the comment:
Thanks for the review and style edits Éric. I think it's a much better patch
with the changes and suggestions from you, Nick, and Alexander.
I'll check my white space settings. Thanks for noticing it.
As Nick points out, parts
Ron Adam ron_a...@users.sourceforge.net added the comment:
Is this a duplicate of issue 9319?
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10509
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is the latest patch with tests.
In order to test the html pages I separated out the URL handler. So now we
have three new functions.
pydoc._start_server(urlhandler, port)
pydoc._url_handler(url, content_type=text/html
On 11/19/2010 08:21 AM, Alexander Belopolsky wrote:
Alexander Belopolskybelopol...@users.sourceforge.net added the comment:
On Thu, Nov 18, 2010 at 2:37 AM, Ron Adamrep...@bugs.python.org wrote:
..
I'll try reading and writing directly to the socket and working up some tests
from that.
I
Ron Adam ron_a...@users.sourceforge.net added the comment:
I added an empty _pydoc.css file. The server does read it and you'll be able
to play around with it, but don't expect it to be pretty if you do until the
rest of the html is updated.
Should I put that in the pydoc_data?
It just
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here is the patch in the current state which includes the changes in
issue2001_c.diff as well as most of the changes Éric suggested.
Still to do:
* Use the with statement in several places to ensure closing.
* Add tests
Ron Adam ron_a...@users.sourceforge.net added the comment:
I just noticed I used depreciated in place of deprecated in one of the doc
strings. I can upload a new patch with that fixed.
Before I do that, is there any thing else I can do?
Do you agree that the browse function should be public
Ron Adam ron_a...@users.sourceforge.net added the comment:
I noticed in your patch, the disclaimer only prints when pydoc can find a doc
location (docloc is not None). So it may not get displayed at all depending on
how python is installed. I also think having it on every page may be a bit
Ron Adam ron_a...@users.sourceforge.net added the comment:
Thanks for the review Éric! The more eyes on this the better it will be.
I'm not familiar with rietveld yet. But no time like the present to get
started. Here's the link.
http://codereview.appspot.com/3151042/
I didn't play
Ron Adam ron_a...@users.sourceforge.net added the comment:
Sense these features reuse other parts of pydoc, they are are covered to some
degree by the existing tests.
An easy test would be to just start the server and then shut it down after a
short timeout. Better than nothing.
I'll try
Ron Adam ron_a...@users.sourceforge.net added the comment:
You may also want to update help topics.
help(PRIVATENAMES).
Identifiers (Names)
***
An identifier occurring as an atom is a name. See section
*Identifiers and keywords* for lexical definition and section *Naming
Ron Adam ron_a...@users.sourceforge.net added the comment:
This should be done or very close to done.
The -g option, gui(), and serve() functions are deprecated.
The new features are browse(port, *, open_browser=True), and a '-b' option.
The '-p port' option does browse(port=port
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file19604/issue2001_a.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file19476/pydoc_r86133.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Ron Adam ron_a...@users.sourceforge.net added the comment:
Ok, here is the latest patch for review. issue2001_a.diff'
I restored the pydoc.py file and then put most of the new code in these two
functions,
_startserver(urlhandler, port)
_browse(port=0, *, open_browser=True)
This creates
Ron Adam ron_a...@users.sourceforge.net added the comment:
What about http://bugs.python.org/issue2001#msg114326 ?
Thanks for the reminder.
To Nick:
However, the public (albeit undocumented) nature of the APIs implementing the
old Tk GUI means I'm not comfortable committing the patch
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file16517/pydoc_gui.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file18165/pydoc_server3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file18271/pydoc_server4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Ron Adam ron_a...@users.sourceforge.net added the comment:
Here you go Nick. One file with Underscores for the new class's and functions.
Where there was some overlap in names, like where some of the older server
class's were reused, but don't have exactly the same behavior, I started those
Ron Adam ron_a...@users.sourceforge.net added the comment:
Nick, I can update the patch and move the server back into pydoc.py if that
will help you get this into 3.2 beta.
I can also changed the docstrings of the new parts to # comments
Ron Adam ron_a...@users.sourceforge.net added the comment:
The test in the patch isn't quite right. The following still fails.
Python 3.2a3+ (py3k:85719, Oct 18 2010, 22:32:47)
[GCC 4.4.3] on linux2
Type help, copyright, credits or license for more information.
import imp
imp.find_module
Ron Adam ron_a...@users.sourceforge.net added the comment:
I think a good place for the pager is in the cmd module. I have a separated
version of it I could upload if there is consensus on this.
I've extracted the text server, but it's in a minimum 'works for pydoc' stage.
(See issue 2001
Ron Adam ron_a...@users.sourceforge.net added the comment:
This is by far the simplest fix for this. See patch file.
This patch is what Stefan Krah suggested and I agree unless someone a lot more
familiar with the import process can take a look at this and re-factor things
so the filename
Ron Adam ron_a...@users.sourceforge.net added the comment:
I added you to this Victor because it looks like what your doing to rewrite the
imports to work with Unicode (issue:9425) overlaps this.
See the test in the patch.
Your rewrite may fix this as the segfault has to do with getting
Ron Adam ron_a...@users.sourceforge.net added the comment:
I also put in a temporary fix to skip the test file that was causing it to
crash when doing a search. It's marked as such and can be removed once the bug
is fixed.
--
___
Python tracker
Ron Adam ron_a...@users.sourceforge.net added the comment:
New diff file.
Removed the '-g' option and added a '-b' option.
Using the '-g' option will now bring up pydoc options help.
Added a simple server command prompt with 'b' and 'q' choices
to open a browser and quit the server.
Allow
Ron Adam ron_a...@users.sourceforge.net added the comment:
The error happens when Null is passed to strlen in (unicodeobject.c, line 860)
Passing NULL to a string format function is probably in the category of don't
do that.
Stefans solution of checking for NULL before calling PyErr_Format
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file18160/pydoc_server.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Changes by Ron Adam ron_a...@users.sourceforge.net:
Removed file: http://bugs.python.org/file18163/pydoc_server2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Ron Adam ron_a...@users.sourceforge.net added the comment:
Link to the discussion on the python-dev new group.
Subject: [isssue 2001] Pydoc enhancement patch questions
http://permalink.gmane.org/gmane.comp.python.devel/115474
--
___
Python tracker
Changes by Ron Adam ron_a...@users.sourceforge.net:
--
nosy: +ron_adam
title: PyUnicode_FromFormat segfault when using widths. - PyUnicode_FromFormat
segfault
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7330
1 - 100 of 125 matches
Mail list logo
