[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Ruslan Mstoi added the comment: Thanks for helping with cleaning up the patch. I already removed that docstring too. -- ___ Python tracker <http://bugs.python.org/issue12

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Removed file: http://bugs.python.org/file22075/issue12009_patch4.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Added file: http://bugs.python.org/file22076/issue12009_patch.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Removed file: http://bugs.python.org/file22074/issue12009_patch3.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Removed file: http://bugs.python.org/file22019/issue12009_patch2.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Removed file: http://bugs.python.org/file22013/issue12009_patch.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Added file: http://bugs.python.org/file22075/issue12009_patch4.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-23 Thread Ruslan Mstoi
Ruslan Mstoi added the comment: Uploading patch updated according to the review comments. -- Added file: http://bugs.python.org/file22074/issue12009_patch3.diff ___ Python tracker <http://bugs.python.org/issue12

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-18 Thread Ruslan Mstoi
Ruslan Mstoi added the comment: removed leftover debug code from patch -- Added file: http://bugs.python.org/file22019/issue12009_patch2.diff ___ Python tracker <http://bugs.python.org/issue12

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-18 Thread Ruslan Mstoi
Changes by Ruslan Mstoi : Removed file: http://bugs.python.org/file22018/issue12009_patch.diff ___ Python tracker <http://bugs.python.org/issue12009> ___ ___ Python-bug

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-18 Thread Ruslan Mstoi
Ruslan Mstoi added the comment: I agree, the test input was becoming unmaintainable. So, I updated the patch with the refactored unit tests. -- Added file: http://bugs.python.org/file22018/issue12009_patch.diff ___ Python tracker <h

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-17 Thread Ruslan Mstoi
Ruslan Mstoi added the comment: OK, finally got some time to make a patch. The fix is to seek the beginning of the comment before calling readline. That way the next line won't be deleted. Also, provided a test case for this issue in the patch. -- keywords: +patch Added file:

[issue12009] netrc module crashes if netrc file has comment lines

2011-05-05 Thread Ruslan Mstoi
New submission from Ruslan Mstoi : It seems recent patch from Issue 10464 has introduced problems into one line comment handling of netrc module. Problem 1: If there is a line starting with a comment sign the following traceback is shown: Traceback (most recent call last): File "/us