Rohit Sanjay added the comment:
Hey, I'd like to work on this issue. Seems like an easy fix. Can you please
help me out with where I will need to add the documentation for this?
--
nosy: +rohitsanjay
___
Python tracker
<https://bugs.python.
Sanjay added the comment:
the version in the patch is less code a or b or c or d becomes a or d
the version in PR is using the subnet_of, supernet_of function because overlap
means either a is subnet_of or supernet_of b. So was trying to consolidate the
implementation of overlap from 2 to 1
Change by Sanjay :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue38335>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanjay added the comment:
the issue happens in 2.7 as well
--
nosy: +Sanjay
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue38
Change by Sanjay :
--
pull_requests: +16110
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16519
___
Python tracker
<https://bugs.python.org/issu
New submission from Sanjay :
the current implementation of overlaps function tests either network or
broadcast address is in other but
we can skip checking broadcast address is in other because we anyway check if
other.network_address in self
without loss of generality if we assume self has
New submission from sanjay patel :
Below snipped goes to infinite loop when running through windows command prompt
but works in python IDLE
import subprocess
subprocess.check_output('cmd.exe dir', stderr=subprocess.STDOUT)
save as:test.py
in windows cmd use command: python test.py
New submission from Sanjay:
The less than check for ip_interface behavior seems weird. I am not sure if
this is by design. We are just comparing the network address but when network
address is equal we should compare the ip address.
The expectation is if a < b is False then b <= a must b
Sanjay added the comment:
ok I will update the doc
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29913>
___
___
Python-bugs-
Sanjay added the comment:
yes but compare_networks is not used to implement equality check. __eq__
correctly returns False when we do 1.1.1.0/24 == 1.1.1.0/25.
If compare_networks works exactly like __eq__ then it seems a bit redundant
Changes by Sanjay <sanjay...@gmail.com>:
--
pull_requests: +739
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29913>
___
__
New submission from Sanjay:
according to the docs compare_networks only checks the network address but the
implementation is also taking the mask length into account. It returns '0' only
if both the network address and the mask are equal but this can be done with
just equality check ( ip1
12 matches
Mail list logo
