Sean Reifschneider added the comment:
Toshio and Matthias: This approach seems sane to me, Nick asked me to review
this ticket. I'm not coming up with any objections. +1 for retiring SO at
some point after 3.2, and EXT_SUFFIX and SHLIB_SUFFIX.
What documentation needs to be changed?
Sean Reifschneider added the comment:
I've tried to test this but v4 doesn't apply cleanly after pure2 is applied,
and v4 doesn't include enough to test it (applying v4 only causes test
failures).
I reviewed v4 and it looks fine in general. I do see that there are changes in
Sean Reifschneider added the comment:
This might be a duplicate of issue17053, but the patch provided there doesn't
resolve the issue, at least as far as I know it. Here is an example, from
David Beazley's talk at PyCon 2013:
from inspect import Parameter, Signature
def make_signa
Sean Reifschneider added the comment:
This may be related to: http://bugs.python.org/issue17424
Perhaps there is a common fix that can address this for both?
--
nosy: +jafo
___
Python tracker
<http://bugs.python.org/issue17
New submission from Sean Reifschneider:
David Beazley in his tutorial pointed out that you could use a metaclass to
create function signatures for the common use case of:
class foo:
def __init__(self, name, value, high, low):
self.name = name
self.value = value
[...]
The
Sean Reifschneider added the comment:
Éric: In http://bugs.python.org/issue8954#msg135902 are you saying:
This issue needs to be re-targeted to a newer Python.
Close -- won't fix.
Something else?
This issue seems to be stuck here, any ideas on what needs to be done to move
this fo
Sean Reifschneider added the comment:
Martin: They are looking for you to review this, in particular see:
http://bugs.python.org/issue7511#msg106420
--
assignee: tarek -> loewis
nosy: +jafo
___
Python tracker
<http://bugs.python.org/iss
Sean Reifschneider added the comment:
The attached patch does change the semantics somewhat, but I don't fully
understand how much. In particular:
It changes the "get()" call to be turned into "get(timeout=1.0)" if inqueue
doesn't have a _reader attribute.
In
Sean Reifschneider added the comment:
Michele: Do you know what needs to be done to determine the resolution to the
_warnings/pgen question? If not, maybe asking the question on python-dev could
get some advice.
--
nosy: +jafo
___
Python tracker
Sean Reifschneider added the comment:
Attached is a patch which implements this, including updated tests. I would
appreciate a review of this patch.
--
assignee: -> ezio.melotti
keywords: +needs review, patch
stage: -> patch review
Added file: http://bugs.python.org/fil
Sean Reifschneider added the comment:
Working on this.
--
nosy: +jafo
___
Python tracker
<http://bugs.python.org/issue14259>
___
___
Python-bugs-list mailin
Sean Reifschneider added the comment:
Committed in r88500.
--
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
Thanks. I had just read that a day or so ago, reviewing it for Brett's work.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Sean Reifschneider :
--
nosy: -jafo
___
Python tracker
<http://bugs.python.org/issue8591>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sean Reifschneider added the comment:
At this point I'm going to consider this good to go, and will commit it after
the 3.2 final release. Thanks for the review everyone. Of course, I'm open to
further suggestions until then, just not expecting any...
--
assignee: ->
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20443/python-underscore_crypt-6.patch
___
Python tracker
<http://bugs.python.org/issue10
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20442/python-underscore_crypt-5.patch
___
Python tracker
<http://bugs.python.org/issue10
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20433/python-underscore_crypt-4.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
Affirmative on the "svn mv" for the C module.
The duplicated code, thanks for pointing that out. Someone else mentioned it,
but I didn't understand what they were saying and they didn't reply to my
request for clarification. Fi
Sean Reifschneider added the comment:
Thanks for the pointer about "patch -p0". I *HAD* tried that, but it didn't
seem to work either. I'll double check that though... "svn diff" is what I'd
prefer, because then I can "svn commit" it when
Sean Reifschneider added the comment:
Not sure if that was meant to be a suggestion for why my local patching wasn't
working from the "svn diff" output, but obviously -5 was messed up. Here's a
new version that I can apply to my fresh trunk and passes "make test&quo
Sean Reifschneider added the comment:
Sure thing, here's an "svn diff". I had switched to the diff because I
couldn't get it to patch into a fresh trunk, but the format looked fine; not
sure why it couldn't find the files. Anyway, here's a new version
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20428/python-underscore_crypt-3.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
Thanks for the review. Attached is a new version of the patch.
1) Done.
2) Good point, I didn't think of that. I've changed it into a class that
stores the methods list, and made the module "methods" point to that method on
an in
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20427/python-underscore_crypt-2.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
I've made a new .patch file using "diff -c" rather than "svn diff". This is
the same code, but applies without manual intervention.
--
Added file: http://bugs.python.org/file20428/python
Changes by Sean Reifschneider :
Removed file: http://bugs.python.org/file20422/python-underscore_crypt.patch
___
Python tracker
<http://bugs.python.org/issue10
Sean Reifschneider added the comment:
Oops, thanks. It's in there now, though for some reason I can't get this patch
to apply to trunk, but I'll have to look at that later this afternoon. I
wanted to get this new version up in the interim since it definitely does
include t
New submission from Sean Reifschneider :
Over the years I've written the same code over and over to create a random salt
string of 2 characters. Worse, the Modular Crypt Format is difficult to find
documentation on, so creating stronger hashed passwords is difficult to get
right.
To
Sean Reifschneider added the comment:
This issue came up on #python IRC, and that combined with the number of times
this has been duplicated makes me think that maybe the mention of the
SortedCollection recipe should be a little more prominent.
Perhaps either moved up by the method list, or
Sean Reifschneider added the comment:
Committed to 2.7 in 81681 and 3.x in 81682.
--
keywords: +needs review -patch
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
type: -> feature request
___
Python tr
Sean Reifschneider added the comment:
I'm fine without ().
I thought the direction was generally initial-capped, but I may be wrong there.
Let's go with "west".
--
___
Python tracker
<http://bu
Sean Reifschneider added the comment:
Then how about:
timedelta() showing offset from UTC, negative values indicating West of UTC
?
--
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
Alternately, here is a patch that just takes the docs.python.org description.
--
Added file: http://bugs.python.org/file17496/python-utcoffsetdoc2.patch
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
In this case, the docs.python.org link you point to seems to be correct, saying
that it returns a timedelta. It is the docstring that says it's minutes east
of UTC.
I've attached a patch which changes this wording to:
timedelta() showing o
Changes by Sean Reifschneider :
--
___
Python tracker
<http://bugs.python.org/issue8214>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Sean Reifschneider added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
This won't go into 2.7.0. I will do a patch for 3.x, and wait for 2.7.0 to see
if it can go into 2.7.1.
--
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
Switched to using assertTrue/assertFalse.
--
Added file: http://bugs.python.org/file17179/logexception5.patch
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
Changed to use import_module.
--
Added file: http://bugs.python.org/file17177/logexception4.patch
___
Python tracker
<http://bugs.python.org/issue8
Sean Reifschneider added the comment:
Thanks for the review Jack.
I was very tempted to split it into C and Python components, but I decided
against it because it's so close to the 2.7 release. I think it would be
best to defer that for the Python 3 release, because of potential pack
Sean Reifschneider added the comment:
Jack Diederich commented:
I don't have my tracker login on this computer so I'll post here.
I'd +1 on making the module python with just the core functionality
imported from C (it releases the GIL when doing IO). Then you
could replace
Sean Reifschneider added the comment:
I have completed the exception handling code as prototyped in msg101687.
Please review.
--
assignee: -> jafo
keywords: +needs review
stage: needs patch -> patch review
Added file: http://bugs.python.org/file17159/logexception2
Sean Reifschneider added the comment:
I believe I have the first function implemented. See the attached patch for
that code and feel free to review.
--
keywords: +patch
nosy: -haypo
Added file: http://bugs.python.org/file17089/logexception.diff
Sean Reifschneider added the comment:
Collin: Antoine has asked for some feedback, can you answer that question?
--
assignee: -> collinwinter
nosy: +jafo
priority: -> normal
___
Python tracker
<http://bugs.python.org/
Sean Reifschneider added the comment:
Ported to python3 and committed as 80401.
--
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
Sean Reifschneider added the comment:
Committed as 80396. Included a change to let openlog(3) pick the ident instead
of using the static string "python".
--
resolution: -> accepted
status: open -> closed
___
Pytho
Sean Reifschneider added the comment:
Ok, so I left the argument style in the docs as it was.
*** NOTE ***: Sean: Change this for the 3 trunk commit.
Setting the "python" string is outside of the argv function because we want to
use "python" on any of the many places wher
Sean Reifschneider added the comment:
Antoine: I believe I have everything you mentioned addressed with the new
patch. That was an awesome review, thank you so much.
The only things I didn't do were parts of the last two items you bring up:
If PyTuple_New(0) fails, bail ou
Changes by Sean Reifschneider :
Added file: http://bugs.python.org/file16983/syslog-kwargs2.patch
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
Changes by Sean Reifschneider :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Sean Reifschneider :
Added file: http://bugs.python.org/file16982/syslog-kwargs.patch
___
Python tracker
<http://bugs.python.org/issue8451>
___
___
Python-bug
New submission from Sean Reifschneider :
As discussed in this thread:
http://mail.python.org/pipermail/python-dev/2010-March/098500.html
The syslog module is using the C argv[0] as the program name, not the python
sys.argv[0]. So, in most cases this means that unless you explicitly set a
Changes by Sean Reifschneider :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue6543>
___
___
Python-bugs-list mailing list
Unsubscri
Sean Reifschneider added the comment:
>From a cursory glance, I don't see any problems with this patch. Though I
>admit that I don't know the traceback code nearly as well as you, Amaury. The
>tests pass on py3k trunk on my Linux box.
If you want other review, perhap
Sean Reifschneider added the comment:
pickle_batch_list_exact_py3k.diff applies cleanly on current py3k trunk and
passes tests. cpickle_list.patch applies cleanly against 2.x trunk and passes
"make test".
I don't see any objections brought up about this set of patches, so we
Sean Reifschneider added the comment:
Ugh, I forgot to check the output of my test run before submitting the last
reply. With the patch applied, "make test" fails with:
test_pickle
Fatal Python error: Cannot recover from stack overflow.
Fatal Python error: Cannot recover from stac
Sean Reifschneider added the comment:
Sorry for the delay in getting to this patch.
I've reviewed this patch and it seems fine to me. The only thing I see
outstanding is the recommendation made by Alexandre about changing the C module
to also implement this.
Aaron: You may want to
Sean Reifschneider added the comment:
Tarek: This patch seems reasonable to me, is this something that can be applied?
--
nosy: +jafo
priority: -> normal
___
Python tracker
<http://bugs.python.org/iss
Changes by Sean Reifschneider :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue7072>
___
___
Python-bugs-list mailing list
Unsubscri
Sean Reifschneider added the comment:
Since this needs review, and Christian is the author of that PEP, I'm assigning
it to him. If not appropriate, any suggestions on where to get visibility to
get reviewers?
--
assignee: ronaldoussoren -> christian.heimes
nosy: +christia
Sean Reifschneider added the comment:
I've posted to python-dev asking for a reviewer for this, the thread is at
http://mail.python.org/pipermail/python-dev/2010-March/098597.html
--
nosy: +jafo
___
Python tracker
<http://bugs.python.org/i
Sean Reifschneider added the comment:
Andrew: There have been changes committed within the last week to #7712, which
Florent suggested might be related. Can you please re-test this to see if it
still exists, and if it does, bug me and I'll try to get some more movement on
Sean Reifschneider added the comment:
The final word on this seems to be this:
- Wait until when we aren't in a beta release. (DONE)
- Quoting:
Well, For Py3K at least we might need to consider going through the C
API and fixing it so that these incorrect assumptions
Sean Reifschneider added the comment:
Committed to release26-maint as 77514.
Committed to trunk as 77515.
Committed to 3k as 77516.
--
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python track
Sean Reifschneider added the comment:
Fixed in python trunk commit 74277.
Fixed in py3k trunk commit 74278.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
New submission from Sean Reifschneider :
As detailed in the python-dev post:
http://mail.python.org/pipermail/python-dev/2009-July/090791.html
I have found a bug in the handling of PyArg_ParseTuple where a NUL in an
argument causes a message like this:
syslog.syslog('hello\0
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I'm attaching a new version here, which addresses the object call type
comments.
Added file: http://bugs.python.org/file11948/pass-examples-2.patch
___
Python tracker <[EMAIL PRO
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I originally had that, but then I realized that if I make it a comment I
can then do something like "dw." on that line when I start filling in
the code to keep the comment around. Because I find that when I fill i
New submission from Sean Reifschneider <[EMAIL PROTECTED]>:
I'm giving a Python tutorial to a bunch of local people and have decided
to use the Python.org tutorial to go by. One of the things I found I
wanted in the section on the "pass" statement was more information a
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue>
__
___
Python-b
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Is a straightforward patch, but I'd like NAS to comment on the change in
behavior. Probably would also need a documentation change, are you up
for doing that Lorenz?
--
assignee: -> nascheme
keywords: +ea
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Kei: The documentation does not say that quit() returns a value, so the
current behavior is correct. However, SMTP defines a return value for
QUIT, so there is a case for smtplib.quit() returning that value.
This patch does
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
status: open -> pending
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2211>
__
___
Pyt
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I'm going to push this to pending until you can get a patch. Thanks, Jamie.
--
nosy: +jafo
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bu
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
It's actually been quite a while since it changed from being
Modules/Setup to being in setup.py, I think a couple of years at least.
And, yes, I realize that Fedora is changing the Modules/Setup file in
their SRPM, but wit
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Fred: You most recently touched the code impacted by this test, does
this sound reasonable?
--
assignee: -> fdrake
nosy: +fdrake, jafo
priority: -> normal
type: behavior -> resource usage
versio
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> georg.brandl
nosy: +georg.brandl
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I would agree with Georg that there isn't anything we can do about this.
I had someone try from the Windows XP command shell and: "dir" "/w"
reports that it can't run the combined command, where: dir
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Back-ported to 2.5 and committed in rev 61675.
--
nosy: +jafo
priority: -> normal
status: pending -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
This patch looks good to me. Greg?
--
assignee: -> gward
components: +Distutils -Library (Lib)
keywords: +easy
nosy: +gward, jafo
priority: -> normal
__
Tracker <[EMAIL PR
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
This patch looks ok to me, but I'd like jlt63 to review it since they
were the last to touch these regexes.
--
assignee: -> jlt63
keywords: +easy
nosy: +jafo, jlt63
priority: -> normal
t
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
I just tested it under Linux Fedora 8 Firefox 3 and it shows results for
the searches "move" and "rename" and got reasonable-looking results.
--
nosy: +jafo
priority: -> normal
resolution: later -&
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Don't modify Modules/Setup*, do as the message says and modify setup.py.
Search for "4, 5", and change that to "4, 6", then run configure and
make and it will build without this message.
I have done thi
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
This patch buffers data inside imaplib, so if anything else wants to use
the socket it may generate surprises. Piers?
--
assignee: -> pierslauder
keywords: +patch
nosy: +jafo
priority:
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> georg.brandl
nosy: +georg.brandl
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Fix is inline.
--
assignee: -> akuchling
keywords: +patch
nosy: +akuchling, jafo
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> brett.cannon
nosy: +brett.cannon
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> akuchling
nosy: +akuchling
priority: -> normal
type: -> feature request
__
Tracker <[EMAIL PROTECTED]>
<http://b
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> georg.brandl
nosy: +georg.brandl
priority: -> normal
versions: +Python 2.6
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
priority: -> normal
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2203>
__
__
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> nnorwitz
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2181>
__
__
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2181>
__
___
Python-bugs-list mailing list
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> akuchling
nosy: +akuchling
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Neal: Can you make that doc change?
--
assignee: -> nnorwitz
nosy: +jafo
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
As addition thought is required by Alexander, I'm going to close this as
postponed and you can re-open it if after further consideration you
think it needs to be applied. Probably would be good to discuss on
python-dev if y
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2173>
__
___
Python-b
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> ping
nosy: +ping
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Sean Reifschneider <[EMAIL PROTECTED]> added the comment:
Yeah, I'm going to agree that urllib's documentation is clear about it
taking a string instead of a list.
--
assignee: -> jafo
nosy: +jafo
priority: -> normal
resolution: -> wont fix
status: open -&g
Changes by Sean Reifschneider <[EMAIL PROTECTED]>:
--
assignee: -> loewis
nosy: +loewis
priority: -> normal
type: -> feature request
__
Tracker <[EMAIL PROTECTED]>
<http://b
1 - 100 of 316 matches
Mail list logo
