[issue22419] wsgiref request length

Changes by Senthil Kumaran sent...@uthcode.com: -- versions: +Python 2.7, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22419

[issue22417] PEP 476: verify HTTPS certificates by default

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22417 ___ ___ Python-bugs-list

[issue22421] securing pydoc server

Senthil Kumaran added the comment: The localhost breaking on your linux system might be due to improper /etc/hosts or is localhost pointing to an ipv6 address? That said, I think it is okay to rely on 127.0.0.1 as host for running pydoc server. I am unsure why the initial check was done only

[issue22421] securing pydoc server

Senthil Kumaran added the comment: sys.platform is darwin since OS X 10.5. I am not sure when it's value was 'mac', So effectively the host was localhost on mac systems. Directly setting the host value to localhost on all platforms may be right thing to do. Here is a patch with tests

[issue22421] securing pydoc server

Senthil Kumaran added the comment: 2.7 was not affected and it was binding to localhost properly. Since it is security related issue, I have fixed it in 3.3 as well. Fix is now present in 3.4 and 3.5 -- resolution: - fixed stage: patch review - resolved status: open - closed versions

[issue22366] urllib.request.urlopen shoudl take a context (SSLContext) argument

Senthil Kumaran added the comment: With the final review comment addressed, this could go in. Since you have commit rights, please feel free to commit it. (else, please assign this to me and I will commit and follow up with the buildbots

[issue22366] urllib.request.urlopen shoudl take a context (SSLContext) argument

Changes by Senthil Kumaran sent...@uthcode.com: -- assignee: - alex ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22366 ___ ___ Python-bugs-list

[issue22245] test_urllib2_localnet prints out error messages

Senthil Kumaran added the comment: Interesting. I had not noticed these with my run on Mac and neither did Buildbots report. Looks like explicit closing of wfile do_GET method can be cause of tis problem. -- ___ Python tracker rep

[issue22245] test_urllib2_localnet prints out error messages

Senthil Kumaran added the comment: It was reproducible on my local machine too. Those errors were present and somehow escaped me. Thanks for raising this. Fixed these and tested in my local machine and test_urllib2_localnet was successful. -- assignee: - orsenthil resolution

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Senthil Kumaran added the comment: This is fixed in all active versions (2.7.8+, 3.4.2? and 3.5). Thanks all! -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue22165] Empty response from http.server when directory listing contains invalid unicode

Changes by Senthil Kumaran sent...@uthcode.com: -- resolution: - fixed stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22165

[issue22165] Empty response from http.server when directory listing contains invalid unicode

Changes by Senthil Kumaran sent...@uthcode.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22165 ___ ___ Python-bugs

[issue22165] Empty response from http.server when directory listing contains invalid unicode

Senthil Kumaran added the comment: Looks like we hit with an encoding issue, which is due to way os.fsdecode() and os.listdir() decode the filenames. support.TESTFN_UNDECODABLE b'@test_99678_tmp\xe7w\xf0' dir_list = os.listdir(self.tempdir) dir_list ['@test_99678_tmp%E7w%F0.txt', 'test

[issue22165] Empty response from http.server when directory listing contains invalid unicode

Changes by Senthil Kumaran sent...@uthcode.com: -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22165 ___ ___ Python-bugs

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Senthil Kumaran added the comment: I have backed out my changes. The buildbot failures were new as I could not reproduce them in my local test on Mac. I will run the buildbot suite on branch and fix it before committing. -- ___ Python tracker rep

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Senthil Kumaran added the comment: @Serhiy, yeah, I think the patch attached to issue22165 will fix one of the buildbot failures. For this issue. there was another one with Broken PIPE which may need a different fix. -- ___ Python tracker rep

[issue22165] Empty response from http.server when directory listing contains invalid unicode

Senthil Kumaran added the comment: Attached patch looks good to me. If an unittest can be provided for this situation in test_httpservers.py it will be comprehensive and will be good to go. -- nosy: +orsenthil ___ Python tracker rep

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Senthil Kumaran added the comment: This bug has been open for a while and I had lost sight of it. Upon prompted recently, I dug bit into history and could think of a good solution. A brief history. 1. The bug maximum recursion depth exceeded when doing Basic Authentication was introduced

[issue21970] Broken code for handling file://host in urllib.request.FileHandler.file_open

Senthil Kumaran added the comment: I have addressed the mistake where req.host is self.get_names() was done instead of req.host in self.get_names() in the first commit as it was an obvious problem. I will come up with patch/solution addressing the other behavior mentioned in this report

[issue21970] Broken code for handling file://host in urllib.request.FileHandler.file_open

Senthil Kumaran added the comment: Thanks for the report. Point 2 is definitely a bug (and an overlook by me), I will fix it. I think, the url[:2] == '//' check was present for ftp case which supported file:// protocol. I can't see a clear requirement to change here. The scenarios you

[issue15588] quopri: encodestring and decodestring handle bytes, not strings

Senthil Kumaran added the comment: Thanks for the review, Mark. Addressed that and committed the changes in changeset 606a18938476 (3.4) changeset b4130b2f7748 (3.5) -- nosy: +orsenthil resolution: - fixed stage: patch review - resolved status: open - closed versions: +Python 3.5

[issue21869] Clean up quopri, correct method names encodestring and decodestring

New submission from Senthil Kumaran: issue15588 brought the topic that quopri has ancient methods like encodestring, decodestring, which a user might expect that will send a string, but instead has to send bytes. This needs to be cleaned up. a) function name should be accurate and represent

[issue20753] disable test_robotparser test that uses an invalid URL

Senthil Kumaran added the comment: The patch was good and captured what was required. I made some minor modifications and committed it in 3.4 and 3.5 Thanks for the patch, Vajrasky Kok. -- assignee: - orsenthil nosy: +orsenthil resolution: - fixed stage: needs patch - resolved

[issue20091] An index entry for __main__ in 30.5 runpy is missing

Senthil Kumaran added the comment: Attached patch adds the index entry. -- keywords: +patch nosy: +orsenthil Added file: http://bugs.python.org/file35703/20091.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20091

[issue20091] An index entry for __main__ in 30.5 runpy is missing

Senthil Kumaran added the comment: Fixed in all active branches. -- resolution: - fixed stage: needs patch - resolved status: open - closed versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20091

[issue19917] [httplib] logging information for request is not pretty printed

Senthil Kumaran added the comment: I believe, repr() is the correct call here. You should know the proper end of line characters like \n, \r\n which were sent in the request while debugging. A pretty print here, while look good, might remove that capability and thus may not add any value

[issue21693] Broken link to Pylons in the HOWTO TurboGears documentation

Senthil Kumaran added the comment: Fixed these. Thanks for the report. -- nosy: +orsenthil resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21693

[issue21640] References to other Python version in sidebar of documentation index is not up to date

Senthil Kumaran added the comment: Fixed the follwing changesets. 2.7 b8655be522d4 3.4 e6dce5611dae 3.5 50c9df76bb77 -- resolution: - fixed stage: - resolved status: open - closed type: - behavior ___ Python tracker rep...@bugs.python.org http

[issue21643] File exists error during venv --upgrade

Senthil Kumaran added the comment: I could not reproduce this in 3.4 / 3.5 [localhost 21643]$ ./python.exe Tools/scripts/pyvenv --upgrade usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear] [--upgrade] [--without-pip] ENV_DIR [ENV_DIR ...] venv

[issue21648] urllib urlopener leaves open sockets for FTP connection

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21648 ___ ___ Python-bugs-list

[issue21641] smtplib leaves open sockets around if SMTPResponseException is raised in __init__

Senthil Kumaran added the comment: The first patch was correct and consistent with how other Exceptions were closing the socket. Fixed this and thanks for the patch. -- assignee: - orsenthil nosy: +orsenthil resolution: - fixed stage: - resolved status: open - closed versions

[issue21640] References to other Python version in sidebar of documentation index is not up to date

Senthil Kumaran added the comment: I see that all the patches are correct. My only worry is since 3.1,3.2 and 3.3 are in security fix only mode, we may not apply it to those. 2.7, 3.4 and 3.5 ones are okay. -- nosy: +orsenthil ___ Python tracker

[issue7776] http.client.HTTPConnection tunneling is broken

Changes by Senthil Kumaran sent...@uthcode.com: -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7776 ___ ___ Python-bugs

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: @dstufft - should you commit it in 3.4 branch (since the change is already in 3.5) and then wait for larry's approval or rejection? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7776

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: I am glad that issues with 3rdparty libs which dependent on the previous wrong behavior has been resolved. As indicated previously, I think, it makes sense to have this in 2.7 as well. I created a patch and tested it 2.7 and it is all good. I plan to commit

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: This is fixed in 2.7 as well here (changeset 568041fd8090). We shall close this ticket after @dstufft pulls in the updated pip for 3.4 Thanks! -- priority: high - release blocker versions: +Python 2.7 ___ Python

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: I prefer we update the ensurepip in 3.4.1 That will be helpful too since 3.5 has the fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7776

[issue15002] urllib2 does not download 4 MB file completely using ftp

Senthil Kumaran added the comment: This is fixed in 3.4 and 3.5. I will backport to 2.7 ( I think, it is worth it). -- resolution: - fixed stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002

[issue15002] urllib2 does not download 4 MB file completely using ftp

Senthil Kumaran added the comment: Christian's patch is good.It helps in setting the socket.makefile file descriptor to a well behaving well file close wrapper and thus will help us prevent some tricky fd close issues. I added tests for coverage to ensure that we are asserting the type

[issue10362] AttributeError: addinfourl instance has no attribute 'tell'

Senthil Kumaran added the comment: I agree. Having tell on a file descriptor of a URL request is not going to be of help. You can easily write to a local file and use all the local file features, if it is things like .tell is desired. -- resolution: - not a bug stage: needs patch

[issue18967] Find a less conflict prone approach to Misc/NEWS

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: -orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18967 ___ ___ Python-bugs-list

[issue16827] Remove the relatively advanced content from section 2 in tutorial

Senthil Kumaran added the comment: For this bug, I think, section 2.2.4 and section 2.2.5 can be moved to section 13 and inserted between section 13.1 and 13.2 as it seem to be fit in naturally there. -- ___ Python tracker rep...@bugs.python.org

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: -orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2052 ___ ___ Python-bugs-list

[issue15002] urllib2 does not download 4 MB file completely using ftp

Senthil Kumaran added the comment: I'll make another wireshark recording to get more details for me to analyze. Thank you! That will be useful. Please test it against 3.x version as it has seen cleanups recently. -- ___ Python tracker rep

[issue21257] Document parse_headers function of http.client

New submission from Senthil Kumaran: It is undocumented. While fixing a doc issue issue18229 for http.server I noticed that I referenced that function and when I looked up for the documentation, it was lacking. -- assignee: orsenthil messages: 216494 nosy: orsenthil priority: normal

[issue15002] urllib2 does not download 4 MB file completely using ftp

Senthil Kumaran added the comment: Christian , with respect to patch, I agree with the logic (using something similar to #18879). Does all current unittests succeed with this? (I suspect not) A unittest for coverage would be helpful. -- ___ Python

[issue18229] attribute headers of http.server.BaseHTTPRequestHandler sometimes does not exists

Changes by Senthil Kumaran sent...@uthcode.com: -- resolution: - fixed stage: - committed/rejected status: open - closed versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18229

[issue21190] Broken download link on README for CPython docs

Senthil Kumaran added the comment: Éric, no preference. I thought this was explicit and if you would like to change it back to /3/, fine, no problem with me. Just think of any redirection issue, if we may accidentally stumble upon, that's

[issue21229] Path used for HTTP PUT request doesn't match the description

Senthil Kumaran added the comment: Yes. And thanks for the patch. I applied a slight variation of it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21229

[issue21248] BROWSER env var described inaccurately in webbrowser docs

Senthil Kumaran added the comment: Thanks for the bug report. The documentation has been fixed in the active versions. -- versions: +Python 3.4, Python 3.5 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21248

[issue21248] BROWSER env var described inaccurately in webbrowser docs

Senthil Kumaran added the comment: Which may be sane thing thing do. So the docs could be made better. Like - the list of browsers specified in env var BROWSER is tried first before looking at the platform defaults. -- nosy: +orsenthil ___ Python

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

Senthil Kumaran added the comment: I am getting to this late. I don't know whether the file descriptor read is expected to be meaningful for urllib2/urllib.request. Senthil, what do you think? It should be meaningful no matter what the length is. I am looking further into this now

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

Senthil Kumaran added the comment: This is the best way I found to reproduce the failure. I changed the resource to www.example.com and then ran this. $ ./python.exe -m test -m *fileno* -u all -v -F test_urllibnet -- ___ Python tracker rep

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

Senthil Kumaran added the comment: This is turning out be trickier than I ever thought. fileno() returning b'' is just random error. The underlying issue is, *directly* reading from the fp of the socket() is returning a incomplete output at all times. The correct way to read the output

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

Senthil Kumaran added the comment: Ned Deily had done the correct analysis in the msg214947 and has this question - I don't know whether the file descriptor read is expected to be meaningful for urllib2/urllib.request. I can see that this test case was for the old behavior where we

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: I verified the patch and this indeed corrects a nasty bug in sending a wrong header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad term) to the end host..I was worried as why we did not observe this earlier and it seems to me

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: This is fixed in 3.4 and 3.5 (finally). I will port it to 2.7 as well. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7776

[issue7776] http.client.HTTPConnection tunneling is broken

Changes by Senthil Kumaran sent...@uthcode.com: -- resolution: - fixed stage: test needed - committed/rejected versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7776

[issue21219] WARNING: Inline literal start-string without end-string.

Senthil Kumaran added the comment: Oops did not notice. Thanks for catching. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21219 ___ ___ Python

[issue21219] WARNING: Inline literal start-string without end-string.

Senthil Kumaran added the comment: Fixed: 3.5 a85606b6de32 3.4 fb5516cbc522 -- resolution: - fixed stage: - committed/rejected status: open - closed type: compile error - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue21224] BaseHTTPRequestHandler, update the protocol version to http 1.1 by default?

Senthil Kumaran added the comment: It may not just the be the version, but the capabilities. We have ensure that capabilities are met/added before updated the version. Thanks for filing the issue. -- nosy: +orsenthil ___ Python tracker rep

[issue10318] make altinstall installs many files with incorrect shebangs

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: -orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10318 ___ ___ Python-bugs-list

[issue16278] Improve os.rename documentation and tests

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: -orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16278 ___ ___ Python-bugs-list

[issue9374] urlparse should parse query and fragment for arbitrary schemes

Senthil Kumaran added the comment: Reviewed the issue and correct rollbacks and commits were applied. This ticket should be closed. Thanks! -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9374

[issue10983] Errors in http.client.HTTPConnection class (python3)

Senthil Kumaran added the comment: Yes, they indeed are. Thank you! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10983

[issue21228] Missing enumeration of HTTPResponse Objects methods of urllib.request.urlopen's http.client.HTTPResponse?

Senthil Kumaran added the comment: Hello Evens, If you can, then please attach a doc to this and we and fix this soon. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21228

[issue21229] Path used for HTTP PUT request doesn't match the description

Senthil Kumaran added the comment: A simple docs patch would definitely help here. Thanks for the bug report. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21229

[issue21229] Path used for HTTP PUT request doesn't match the description

Senthil Kumaran added the comment: Sure, here is the information on how to create a patch - https://docs.python.org/devguide/ It could feel that there are multiple steps, but the process is easy. -- ___ Python tracker rep...@bugs.python.org http

[issue7776] http.client.HTTPConnection tunneling is broken

Senthil Kumaran added the comment: I am reviewing this patch right now and you will see my action soon. It is completely and I am reviewing to validating the technical details/fix. Thanks for patch, Nikolaus. -- ___ Python tracker rep

[issue21190] Broken download link on README for CPython docs

Senthil Kumaran added the comment: Fixed this all active versions. Thanks for the report. -- nosy: +orsenthil resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue20939] test_geturl of test_urllibnet fails with 'https://www.python.org/' != 'http://www.python.org/'

Senthil Kumaran added the comment: The suggested patch(s) looks good to me. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20939

[issue20529] Unittest displays ResourceWarning warnings when running tests, it probably should not

Changes by Senthil Kumaran sent...@uthcode.com: -- assignee: - orsenthil resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20529

[issue19092] ExitStack.__exit__ incorrectly suppresses exceptions in __exit__ callbacks of inner context managers

Senthil Kumaran added the comment: The last tracker message msg207926 is applicable to issue #19097 and not here. Sorry for the confusion. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19092

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Senthil Kumaran added the comment: Fixed in: New changeset a3e49868cfd0 by Senthil Kumaran in branch '3.3': Issue #19092 - Raise a correct exception when cgi.FieldStorage is given an http://hg.python.org/cpython/rev/a3e49868cfd0 New changeset 1638360eea41 by Senthil Kumaran in branch 'default

[issue19082] Lib/xmlrpc/client.py demo code points to the dead server

Senthil Kumaran added the comment: Addressed this in all active branches (2.7, 3.3 and 3.4). Thanks! -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue20138] wsgiref on Python 3.x incorrectly implements URL handling causing mangled Unicode

Senthil Kumaran added the comment: And those examples were only in test. Use of latin-1 to have a literal text for round trip is ok. The patch looks good to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20138

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Senthil Kumaran added the comment: This is fixed in all active branches (2.7,3,3 and 3.4). I have addressed all review comments. Thanks. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue20116] urlparse.parse_qs should take argument for query separator

Senthil Kumaran added the comment: If you could point to RFC which states the list of characters which can be used as valid query string separators, we can include that list. (Of course in 3.5) -- nosy: +orsenthil ___ Python tracker rep

[issue12692] test_urllib2net is triggering a ResourceWarning

Senthil Kumaran added the comment: @Martin. Agree that this should have been backported. I have done that. Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12692

[issue19383] nturl2path test coverage

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19383 ___ ___ Python-bugs-list

[issue19350] macurl2path coverage

Senthil Kumaran added the comment: Patch committed in these versions. Thank you! 2.7 -5fda64d39540 3.3 - 06b9a9e75a6c 3.4 - 060d9b2e4d5e -- assignee: - orsenthil resolution: - fixed stage: - committed/rejected status: open - closed type: - behavior

[issue19350] macurl2path coverage

Changes by Senthil Kumaran sent...@uthcode.com: -- versions: +Python 2.7, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19350

[issue19350] macurl2path coverage

Changes by Senthil Kumaran sent...@uthcode.com: -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19350 ___ ___ Python-bugs-list

[issue19082] Lib/xmlrpc/client.py demo code points to the dead server

Senthil Kumaran added the comment: Sounds good.I shall update patch (.rstify the security warning). Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19082

[issue19082] Lib/xmlrpc/client.py demo code points to the dead server

Senthil Kumaran added the comment: The patch is good. I think, it is better to include this information in documentation too. Please let me know if this suitable, I shall go ahead committing this. (With credits to Vajrasky Kok) -- assignee: - orsenthil nosy: +orsenthil versions

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Changes by Senthil Kumaran sent...@uthcode.com: -- versions: +Python 3.3, Python 3.4 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19097

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Senthil Kumaran added the comment: Addressing storchaka's review comments. Here is the updated patch. -- Added file: http://bugs.python.org/file32021/19092-v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19097

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Senthil Kumaran added the comment: Hi Guido, Agree with both your points. Attaching a patch that fixes this issue. 1. Raises TypeError exception when header is not a Mapping or email.message.Message type. 2. Asserts for fp.read and fp.readline() to assert that fp, the first argument

[issue14927] add Do not supply 'int' argument to random.shuffle docstring

Senthil Kumaran added the comment: Hi Raymond, Ezio provided some comments on improvements to the patch. Do you mind if Ezio or I take over task of improvement. Not cause problems != no need to improve. TIA. -- ___ Python tracker rep

[issue19097] bool(cgi.FieldStorage(...)) may be False unexpectedly

Senthil Kumaran added the comment: FieldStorage(foo, bar) is invalid because the first argument is supposed to be file-like object and second one headers. Here we are sending invalid headers. By default, if the headers is none, the content-type is urlencoded. The right way of using

[issue19094] urljoin should raise a TypeError if URL is not a string

Senthil Kumaran added the comment: I have provided my comments in the review tool. Please check them out. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19094

[issue18978] Allow urllib.request.Request subclasses to override method

Senthil Kumaran added the comment: Thanks for the this change, Jason. Docs could be updated to reflect this change (using ..versionchanged: directive). Thank you! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18978

[issue18857] urlencode of a None value uses the string 'None'

Senthil Kumaran added the comment: Hi Joshua, I did not setup a php server to test the html form that you uploaded. We cannot test this in browsers because HTML does not have None as values, it is simple empty strings and that is correct. I think that the cost of making this change is higher

[issue18553] os.isatty() is not Unix only

Senthil Kumaran added the comment: Georg: Thanks for spotting. I feel bad for the mistake. I shall correct it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18553

[issue18553] os.isatty() is not Unix only

Senthil Kumaran added the comment: Fixed now. Ascertained myself by doing hg diff -r tip^ -U 10 on local commits before pushing. :-) -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18553

[issue18553] os.isatty() is not Unix only

Senthil Kumaran added the comment: Hello Dmi, I having a snippet to fix that, should I open a new issue for patch? Please open a new issue. Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18553

[issue17764] Support http.server passing bind address via commend line argument

Senthil Kumaran added the comment: Found the patch suitable and had addressed Berker Pesag's review comments too. Thanks for contributing, Malte Swart and thanks for submitting the contributor agreement too. -- nosy: +orsenthil resolution: - fixed stage: patch review - committed

[issue18857] urlencode of a None value uses the string 'None'

Senthil Kumaran added the comment: The patch looks good, but I have doubt in the claim that, this new behavior is actually a right thing to do. RDM wrote: Now, that said, it seems to me that while it is not (apparently) RFC compliant, query strings do have a natural way to support null

[issue14927] add Do not supply 'int' argument to random.shuffle docstring

Senthil Kumaran added the comment: Georg Brandl added the comment: I would propose a leading underscore for these methods; they should make it clear to the user that the parameter is meant to be private. +1 to this proposal. This style is present with randrange, randbelow and shuffle

[issue14927] add Do not supply 'int' argument to random.shuffle docstring

Senthil Kumaran added the comment: Tim Peters added the comment: ..., _fast=slow, ... in an argument list means we endure the slow lookup (of `slow`) only once, when the function is first defined. When the function is _called_, that binding is available via the local (much faster

<    1   2   3   4   5   6   7   8   9   10   >