Steve Dower added the comment:
> Note that CopyFileEx() is a high-level Windows API function, not a "kernel
> mode" copy.
This is true today, but could change whenever Windows feels like changing it.
If we switch to the native API then we'll get any advantage there aut
Steve Dower added the comment:
Oh, and there's no harm in adding a note to that doc section explicitly
pointing out that it doesn't enable CPython itself to be installed to a long
path, and it may not enable packages to be imported from long paths in all
scenarios (as it'
Steve Dower added the comment:
It enables it for accessing from within Python, but doesn't enable Python
itself to be installed into a long path. And because a venv is essentially an
installation, they're included in that. (Possibly %PYTHONPATH% entries are too.)
I haven
Steve Dower added the comment:
Great! I backported to 3.10, but we never took the other changes back to 3.9 so
it can stop there.
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10,
Steve Dower added the comment:
New changeset f3289a50503ed1a809d77fb03744bdcc7b9f1093 by Steve Dower in branch
'3.10':
bpo-44479: Regenerate test_frozenmain.h and frozen_hello.h during build on
Windows (GH-26984)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +25595
pull_request: https://github.com/python/cpython/pull/27035
___
Python tracker
<https://bugs.python.org/issue44
Steve Dower added the comment:
New changeset 1b133ab8412e4f6a53914212df7a7656f376256d by Steve Dower in branch
'main':
bpo-44479: Regenerate test_frozenmain.h and frozen_hello.h during build on
Windows (GH-26984)
https://github.com/python/cpyt
Change by Steve Dower :
--
keywords: +patch
pull_requests: +25546
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26984
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I agree that's theoretically how it should go, but we've had enough examples of
undocumented/buggy behaviour where the fix was worse than the bug (to the point
where we brought back an undocumented C field that was deprecated in 3.0
because removing
Steve Dower added the comment:
We can't delete the definition without going through a deprecation process, as
it will break existing code with a new exception at the point of access rather
than the point of use. At best, we can short-circuit those errors and raise
them with a
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset d3a95c1b6eacbbbd92c294744e7ed41932f3f63e by Steve Dower in branch
'main':
bpo-44535: Enable building with Visual Studio 2022 on Windows (GH-26962)
https://github.com/python/cpython/commit/d3a95c1b6eacbbbd92c294744e7ed4
Steve Dower added the comment:
New changeset 95919b0d2744adb87acf696ae1de905cf02a95a6 by Steve Dower in branch
'main':
bpo-41180: Fixes documentation to specify correct event name and add
versionchanged (GH-26972)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 863e3d5c7e037b24b8294b041ed7686b522973d8 by Steve Dower in branch
'3.9':
bpo-41180: Replace marshal code.__new__ audit event with marshal.load[s] and
marshal.dumps (GH-26971)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset a5764d3d96341441d3f70fb5c96a82610a3f4842 by Steve Dower in branch
'3.10':
bpo-41180: Replace marshal code.__new__ audit event with marshal.load[s] and
marshal.dumps (GH-26970)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +25536
pull_request: https://github.com/python/cpython/pull/26972
___
Python tracker
<https://bugs.python.org/issue41
Change by Steve Dower :
--
pull_requests: +25535
pull_request: https://github.com/python/cpython/pull/26971
___
Python tracker
<https://bugs.python.org/issue41
Change by Steve Dower :
--
pull_requests: +25534
pull_request: https://github.com/python/cpython/pull/26970
___
Python tracker
<https://bugs.python.org/issue41
Steve Dower added the comment:
New changeset 139de04518bd98a975b7c98ab8a38e570dc585e4 by Steve Dower in branch
'main':
bpo-41180: Replace marshal code.__new__ audit event with marshal.load[s] and
marshal.dumps (GH-26961)
https://github.com/python/cpyt
Change by Steve Dower :
--
keywords: +patch
pull_requests: +25528
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26962
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +25527
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26961
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I'm going to revert this and replace it with a marshal.loads (and dumps) event
instead.
The performance impact on loading .pyc files is too great, as it triggers the
hook for each function. Without severely modifying importlib we can't bypass
the c
New submission from Steve Dower :
The project files require an additional check in PCbuild/python.props to select
the right toolset for VisualStudioVersion=17.0. Without this, everything will
refuse to build.
The toolset is still v142, so there should be not compatibility issues. The
Steve Dower added the comment:
The file that fails contains a UTF-8 BOM at the start, which is a multibyte
character indicating that the file is definitely UTF-8.
Unfortunately, none of Python's default settings will handle this, because it's
a convention that only really exists
Steve Dower added the comment:
New changeset 19459f8ce63cc7f905e3c1a55d09d4d10d245343 by Samuel Marks in
branch 'main':
bpo-44321: Adds `os.EX_OK` for Windows (GH-26559)
https://github.com/python/cpython/commit/19459f8ce63cc7f905e3c1a55d09d4
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.11, Python 3.9
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 80190b3e533097b55077becddc75423318ab2371 by Steve Dower in branch
'main':
bpo-43298: Improved error message when building without the Windows SDK
installed (GH-26800)
https://github.com/python/cpyt
Steve Dower added the comment:
Python 3.6 is no longer supported by us, so unless this occurs with a newer
version (which apparently it does not), we're not going to be able to look into
it.
If this is critical to you, you probably want to get in touch with Anaconda or
ActiveState t
Change by Steve Dower :
--
keywords: +patch
pull_requests: +25381
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26800
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
distutils.sysconfig doesn't expose the headers path either, it's only there as
a default value for the install command (Lib/distutils/command/install.py).
So it doesn't seem unreasonable to provide a recommendation on where to put
shared heade
Steve Dower added the comment:
WINE is not a platform that we officially support, and for the installer, I'm
willing to say that we never will.
Our installer is based on the WiX Toolset, so anything that can be fixed will
have to be fixed by them first. It's possible that they ha
Steve Dower added the comment:
Jason - I think your -add and -remove options need work. I'm pretty sure the
AzureBuildTools component doesn't bring in the C++ compilers or the WinSDK.
If you configure it manually and interactively, you should be able to export a
JSON configuratio
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 9580d3894ad158ae909e7573a02dcd087de0b673 by Miss Islington (bot)
in branch '3.9':
bpo-44381: Windows build now allows enabling control flow guard (GH-26645)
https://github.com/python/cpython/commit/9580d3894ad158ae909e7573a02dcd
Steve Dower added the comment:
New changeset 5af56c6f2a0d11df37fed7ecaaf321cf6926ba13 by Steve Dower in branch
'main':
bpo-44381: Windows build now allows enabling control flow guard (GH-26645)
https://github.com/python/cpython/commit/5af56c6f2a0d11df37fed7ecaaf321
Steve Dower added the comment:
Sorry, you've reported a range of issues here and it's not clear what the
problem is.
Many many people (literally millions) have successfully installed Python on
Windows with these installers, and even more (including most Microsoft
product
Steve Dower added the comment:
FWIW, I don't actually know what the performance impact is. I'm not set up for
running the perf benchmarks, and I don't know if anyone else is (on Windows),
but if someone would like to then it'll be easier once the environment option
to e
Change by Steve Dower :
--
keywords: +patch
pull_requests: +25231
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26645
___
Python tracker
<https://bugs.python.org/issu
New submission from Steve Dower :
Currently we don't enable CFG (which is runtime protection against code
injection into tables), because it likely has a performance impact and the kind
of attack is outside our scope.
However, we should make it easier to build CPython with CFG enable
Steve Dower added the comment:
> Decrease the global recursion limit only for windows debug.
This is already what we do, so if someone has increased stack usage, they
should also decrease the value here.
Hopefully the non-debug value doesn't have to be reduced. In that case, it&
Steve Dower added the comment:
New changeset 449e6f0ef395231e3abe467f910b02d7f075c27f by Ryan Hileman in
branch 'main':
bpo-41299: Reduce lag in Windows threading timeouts by using a higher precision
time source (GH-26568)
https://github.com/python/cpyt
Steve Dower added the comment:
Change looks good. 3.8 is security fixes only at this stage, but it can go back
to 3.9
--
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/issue41
Steve Dower added the comment:
The appx layout is also the only one in CI that actually uses an installed
layout - all the rest run tests from the source tree. So it could be related to
that.
If it's a warning, it could also be that the warning is being triggered
somewhere else
Steve Dower added the comment:
I see this line in your log:
Rejecting product '{6504EEE5-2172-4D34-A76D-0372356396B4}': Non-assigned apps
are disabled for non-admin users.
I'm not entirely sure what it means, or how you managed to install it under
this apparent restrictio
Steve Dower added the comment:
You shouldn't need to install the redistributable, but if you can't, then you
have an issue that is not limited to CPython and it's not something we can fix.
It sounds like you didn't try disabling any virus scanners. That may still
help.
Steve Dower added the comment:
Unfortunately, I've got no idea whether it's failing to uninstall the MSI or if
it's specific to removing the PATH environment variable. If you've still got
the rest (no more than 2-3 I'd expect) of the uninstall log files in your
Steve Dower added the comment:
It still seems like pyexpat is not installing properly.
My best guess is that some virus scanner is silently blocking that file from
being installed.
Do you know what scanner you have enabled? If you can disable it, can you try
doing an uninstall/reinstall
Steve Dower added the comment:
Pooja, could you share your install logs? Details are in my post directly above
yours.
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue25957>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue34219>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
distutils is deprecated and no further bugs will be fixed (other than newly
discovered release blockers).
You will want to report this to setuptools instead.
--
resolution: -> out of date
stage: patch review -> resolved
status: open -&g
Steve Dower added the comment:
> If changing the console input codepage to UTF-8 fixes the mojibake problem,
> then probably you're running Python in UTF-8 mode.
I forget where I saw them, but there are some places where we incorrectly use
stdin encoding for writing to stdout
Steve Dower added the comment:
Thanks, Eric.
Anyone may feel free to create and release their own MSI distro of CPython. I
don't even mind if you use the binaries from our releases, as those are signed
and your users will be able to know that they aren't modified (it's a li
Steve Dower added the comment:
> But 3.9 and 3.8 are not failing on test_ssl, so do something has clearly
> changed. Are the failing tests new?
They're flakey in the sense that they're not failing reliably, when they
clearly should be :)
If something changed about how
Steve Dower added the comment:
I can't reproduce these on my own (Windows) machine either.
Looking at the output, I think the tests are just going to be inherently
flakey. It's not testing the specific scenario directly enough, and relying
heavily on implicit synchronization.
W
Steve Dower added the comment:
Thanks! This is a great idea.
I'd prioritise adding support to the Store app first, as that's easier to
manage (we're not having to modify files owned by other apps outside of our
install directory). But no reason we couldn't extend the
Steve Dower added the comment:
Should actually be:
LIBPL=Path(sysconfig.get_config_var("installed_base")) / "libs"
--
___
Python tracker
<https://bug
New submission from Steve Dower :
Python on Windows currently has no values in sysconfig to locate the lib files
for building. Though these are very predictable (for now), it would be nice to
have them in the same place as for other platforms.
I propose defining the following config vars in
Steve Dower added the comment:
> I've found that it's reproducible if you run flake8 on a file that just
> contains: `a.b`
ISTR there were some changes made to assigning attributes on AST classes
recently? I forget who did them, but I remember discussing it during the
s
Steve Dower added the comment:
I didn't mean to change it. Maybe bpo did it automatically?
There are a few ways to get multiple Python installs that could lead to
launching the wrong one through PATH. --user is one of the least likely.
--
status: open ->
Steve Dower added the comment:
>> Usually this error occurs due to PATH conflicts.
>
> Python 3.8 and above does not use PATH when importing extension modules
For this issue, the PATH conflict would be that "pip" and "python" refer to
different Python inst
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Thanks for the patch!
I don't think this meets the 3.8 bar now, but if Ćukasz wants it then it should
be easy.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Change by Steve Dower :
--
pull_requests: +24692
pull_request: https://github.com/python/cpython/pull/26052
___
Python tracker
<https://bugs.python.org/issue44
Steve Dower added the comment:
New changeset b4884083aed9bfec22c4da0e0223ad6a04a4bef2 by Steve Dower in branch
'3.9':
bpo-44070: Clarify NEWS message to specify the version when the behaviour was
introduced (GH-26029)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +24679
pull_request: https://github.com/python/cpython/pull/26029
___
Python tracker
<https://bugs.python.org/issue44
Change by Steve Dower :
--
pull_requests: +24678
pull_request: https://github.com/python/cpython/pull/26028
___
Python tracker
<https://bugs.python.org/issue44
Steve Dower added the comment:
New changeset 23822e2c654e950bcfa563e27b99bcb46187ac8b by Steve Dower in branch
'3.9':
bpo-44070: No longer eagerly makes import filenames absolute, except for
extension modules (GH-26025)
https://github.com/python/cpyt
Change by Steve Dower :
--
keywords: +patch
pull_requests: +24675
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26025
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I still don't think the patch goes anywhere near far enough to be useful.
Most likely we should preface that section with a "we recommend using a
third-party build backend for your package, such as ... and refer to
packaging.python.org for
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue44076>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Fundamentally I don't have an issue with the audit hook. My only concern would
be if there's anything that an application may do to _respond_ to a stall (e.g.
is this valuable for applying backpressure? etc.)
If it's purely diagnostic, and
Steve Dower added the comment:
Yeah, you're probably right. That effect was not noticed when implementing it.
We should update the fix in 3.9 and 3.8 to limit it to .pyd's on Windows to
protect against the security risks, but leave other import types loaded with
relative paths
Steve Dower added the comment:
It's almost certainly due to that change, though I'd be interested to see a
more realistic repro.
For the repro shown, you really ought to be clearing the importer cache as well
when you remove a search path (as implied by chdir with a relati
Steve Dower added the comment:
> I can reproduce it on latest master running on Linux.
Interesting. Perhaps my actual change was to cause it to raise an error
earlier (outside of a handler)? Which would mean that the Path object
was always failing before, just silently.
Arguably we sho
Steve Dower added the comment:
To be clear, I'll get to this when I can, but if someone else wants to write
the fix I'm happy to review and merge. Don't wait for me to do this one just
because I'm assigned.
--
versions: +Python 3.11
__
Steve Dower added the comment:
Looks like it was always getting lucky in the past, as sys.path requires
strings, and the "path" argument here is an alternative to it. The cache was
definitely not working as intended.
So while it's not clearly documented anywhere (other t
Steve Dower added the comment:
The return type of a ctypes function is set by whoever is accessing it. If that
is you, then you should do:
ctypes.windll.kernel32.VirtualAlloc.restype = ctypes.c_void_p
If it's not you, can you point out which code is getting this wrong? ctypes
defaul
Steve Dower added the comment:
>> The best option for restricting the import while still having it be a Python
>> import is to find the file (if it's present in the expected location under
>> sys.whatever), and then use importlib to import it:
>> http
Steve Dower added the comment:
> "pip install as root" will need to continue to work and thus distros
> need to get a way to make sure that it doesn't corrupt the system
> installed packages
Excuse my ignorance, but does "as root" imply that there's
Steve Dower added the comment:
Would "pip install --user ..." in a Docker container also work, though?
Presumably all the filesystem paths are being redirected anyway, so is there a
difference?
(My assumption is that "--user" would essentially become the default if
Steve Dower added the comment:
> I'd rather not have a new option here ...
Perhaps what I'm suggesting here is that I don't see any reason for "sudo pip
install ..." into a distro-installed Python to ever need to work, and would be
quite happy for it to just fail
Steve Dower added the comment:
The best option for restricting the import while still having it be a Python
import is to find the file (if it's present in the expected location under
sys.whatever), and then use importlib to import it:
https://docs.python.org/3/library/importlib
Steve Dower added the comment:
Correct. It does, however, write to the lookaside space, which Windows will map
back if you access it.
So reading HKLM\Software\Python\PythonCore\3.9 will return all the values that
would be there. It's only enumeration that doesn't work. I've r
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Yes, I saw some of the latest changes in the PR.
My biggest concern is with the bare "import _vendor_config", which I'd prefer
to have restricted to a fixed location, rather than being influenced by
environment variables and other options. We
Steve Dower added the comment:
> Making sysconfig look at sitecustomize seems like the wrong approach.
I mean, you're literally customizing the site, so having it be done from
sitecustomize doesn't seem terribly wrong. But I agree, I'd rather see the code
in sitecustomi
Steve Dower added the comment:
New changeset bb2f3ff7a8f0c3565ccc1946dba7e09a3f7dc209 by Steve Dower in branch
'3.9':
bpo-42800: Add audit events for f_code and tb_frame (GH-24182)
https://github.com/python/cpython/commit/bb2f3ff7a8f0c3565ccc1946dba7e0
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 10665ac37313560fe87460cf4a5c26677049bf62 by Erlend Egeberg
Aasland in branch '3.8':
bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset ad73d1657ca3591b1dd1d15bb80ce83ca7fc3223 by Erlend Egeberg
Aasland in branch '3.9':
bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset cbb7b9ed4a6069a2cb2e2f809926c2cfa332a493 by Erlend Egeberg
Aasland in branch 'master':
bpo-43434: Clean up sqlite3.connect() after GH-25818 (GH-25823)
https://github.com/python/cpython/commit/cbb7b9ed4a6069a2cb2e2f809926c2
Steve Dower added the comment:
Thanks, Erlend! Appreciate how quickly you got onto that, and the quality of
your work.
--
___
Python tracker
<https://bugs.python.org/issue43
Steve Dower added the comment:
This is the full error message (and sorry I just saw that you put it on
pastebin in the first post).
MSI (s) (18:04) [13:13:04:342]: SECREPAIR: Hash Database:
C:\Windows\Installer\SourceHash{1C17C2CE-B315-4C1C-885A-E37181C7368E}
MSI (s) (18:04) [13:13:04:342
Steve Dower added the comment:
We could get this one in after beta 1 anyway, but sure, it's in.
The backports are going to have to be manual, I suspect...
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs
Steve Dower added the comment:
New changeset c96cc089f60d2bf7e003c27413c3239ee9de2990 by Erlend Egeberg
Aasland in branch 'master':
bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Steve Dower added the comment:
Hi Marwan
If you look in your %TEMP% directory for the log file you attached, you'll find
some more similar log files. Could you attach those as well? One of them will
have the actual issue in it.
--
___
P
Steve Dower added the comment:
Yes, let's move it into the init function.
--
___
Python tracker
<https://bugs.python.org/issue43434>
___
___
Python-bugs-l
601 - 700 of 5794 matches
Mail list logo