Vinay Sajip added the comment:
New changeset 106271568c58cfebae58f0c52b640dbe716ba2ce by Vinay Sajip in branch
'master':
bpo-16576: Add checks for bitfields passed by value to functions. (GH-17097)
https://github.com/python/cpython/commit/106271568c58cfebae58f0c52b640dbe716ba2ce
Vinay Sajip added the comment:
This will be a rare use case, and I would expect anyone clearing sys.modules in
the child process to handle this consequence themselves (e.g. by reimporting
multiprocessing after clearing out the other modules, since they apparently
still want some
Change by Vinay Sajip :
--
pull_requests: +16603
pull_request: https://github.com/python/cpython/pull/17097
___
Python tracker
<https://bugs.python.org/issue16
Change by Vinay Sajip :
--
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 2.7, Python 3.2
___
Python tracker
<https://bugs.python.org/issue16576>
___
___
Vinay Sajip added the comment:
Why does this need to be in the stdlib, useful though it may be for some use
cases? As I understand it, RELP is mainly for communication between rsyslog
servers, not specifically/especially for client-rsyslog communication. From the
PyRELP link you posted
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 9def81aa52adc3cc89554156e40742cf17312825 by Vinay Sajip in branch
'master':
bpo-36876: Moved Parser/listnode.c statics to interpreter state. (GH-16328)
https://github.com/python/cpython/commit/9def81aa52adc3cc89554156e40742cf17312825
Vinay Sajip added the comment:
New changeset 519cb8772a9745b1c7d8218cabcd2f96ceda4d62 by Vinay Sajip (l0rb) in
branch 'master':
bpo-38716: stop rotating handlers from setting inherited namer and rotator to
None (GH-17072)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 484edbf9bf1a9e6bae0fcb10a0c165b89ea79295 by Vinay Sajip (Ammar
Askar) in branch '3.7':
bpo-16575: Fix refleak on passing unions in ctypes (GH-17064)
https://github.com/python/cpython/commit/484edbf9bf1a9e6bae0fcb10a0c165b89ea79295
Vinay Sajip added the comment:
> Would you consider it more acceptable to just turn
them into class level attributes of BaseRotatingHandler instead of
setting them in init?
Yes, that would be better.
--
___
Python tracker
<https://bugs.pyth
Vinay Sajip added the comment:
They can be methods, but don't need to be. In my example, I showed how you can
set the namer and rotator attributes to methods which do have access to self. I
don't want to encourage the idea that namer and rotator *have* to be methods
that have
Vinay Sajip added the comment:
I also feel that lower case true and false are synonymous with any truthy and
falsey values, as I'm sure many others do, so things in this area should in
general stay as they are. Certainly -1 for a search-and-replace approach!
--
nosy: +vinay.sajip
Vinay Sajip added the comment:
The namer and rotator attributes are callables, not methods to be overridden.
You can certainly do this with methods and set them accordingly:
class MyHandler(BaseRotatingHandler):
def __init__(self, *args, **kwargs):
super(MyHandler, self).__init__
Vinay Sajip added the comment:
You're doing it wrong. I inserted a print statement just before the
RotatingFileHandler for email.log is created. Here's what was printed:
Creating RFH email.log
Creating RFH email.log
Creating RFH email.log
Creating RFH email.log
Creating RFH email.log
Change by Vinay Sajip :
--
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsub
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Vinay Sajip :
--
assignee: docs@python -> vinay.sajip
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Vinay Sajip added the comment:
New changeset 0118d109d54bf75c99a8b0fa9aeae1a478ac4b7e by Vinay Sajip in branch
'3.7':
[3.7] bpo-16575: Add checks for unions passed by value to functions. (GH-16799)
(GH-17017)
https://github.com/python/cpython/commit/0118d109d54bf75c99a8b0fa9aeae1a478ac4b7e
Vinay Sajip added the comment:
New changeset 952899704800a5aa438e84d50f0b6fc498c72e89 by Vinay Sajip in branch
'3.8':
[3.8] bpo-16575: Add checks for unions passed by value to functions. (GH-16799)
(GH-17016)
https://github.com/python/cpython/commit/952899704800a5aa438e84d50f0b6fc498c72e89
Change by Vinay Sajip :
--
pull_requests: +16536
pull_request: https://github.com/python/cpython/pull/17017
___
Python tracker
<https://bugs.python.org/issue16
Change by Vinay Sajip :
--
pull_requests: +16535
pull_request: https://github.com/python/cpython/pull/17016
___
Python tracker
<https://bugs.python.org/issue16
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Vinay Sajip added the comment:
New changeset b15100fe7def8580c78ed16f0bb4b72b2ae7af3f by Vinay Sajip (Lucas
Cimon) in branch 'master':
bpo-38586: setting logging.Handler .name property in fileConfig (GH-16918)
https://github.com/python/cpython/commit/b15100fe7def8580c78ed16f0bb4b72b2ae7af3f
Vinay Sajip added the comment:
New changeset 79d4ed102a5069c6cebaed2627cb1645637f0429 by Vinay Sajip in branch
'master':
bpo-16575: Add checks for unions passed by value to functions. (GH-16799)
https://github.com/python/cpython/commit/79d4ed102a5069c6cebaed2627cb1645637f0429
Change by Vinay Sajip :
--
pull_requests: +16355
pull_request: https://github.com/python/cpython/pull/16799
___
Python tracker
<https://bugs.python.org/issue16
Vinay Sajip added the comment:
New changeset 0b60f64e4343913b4931dc27379d9808e5b78fe1 by Vinay Sajip in branch
'master':
bpo-11410: Standardize and use symbol visibility attributes across POSIX and
Windows. (GH-16347)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 129c2b3d44a962fc5964ef8fd4e6b22dbb691a6c by Vinay Sajip in branch
'3.7':
bpo-38368: Added fix for ctypes crash when handling arrays in structs/unions.
(GH-16589) (GH-16672)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset d004a5b082d0770682e6efbf03105a67469d4820 by Vinay Sajip in branch
'3.8':
bpo-38368: Added fix for ctypes crash when handling arrays in structs/unions.
(GH-16589) (GH-16671)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
pull_requests: +16253
pull_request: https://github.com/python/cpython/pull/16672
___
Python tracker
<https://bugs.python.org/issue38
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +16252
pull_request: https://github.com/python/cpython/pull/16671
___
Python tracker
<https://bugs.python.org/issue38
Vinay Sajip added the comment:
New changeset e8bedbddadaa86be6bd86dc32dbdbd53933a4988 by Vinay Sajip in branch
'master':
bpo-38368: Added fix for ctypes crash when handling arrays in structs…
(GH-16589)
https://github.com/python/cpython/commit/e8bedbddadaa86be6bd86dc32dbdbd53933a4988
Vinay Sajip added the comment:
Adding Thomas and Victor based on git blame on some of the source lines
concerned.
--
nosy: +twouters, vstinner
___
Python tracker
<https://bugs.python.org/issue38
Vinay Sajip added the comment:
BTW it also seems to fail when just Py_DEBUG is specified (no
--with-assertions).
--
___
Python tracker
<https://bugs.python.org/issue38
New submission from Vinay Sajip :
Following
./configure --prefix=$HOME/.local --with-assertions
and then running make leads to an error:
$ make
gcc -pthread -c -Wno-unused-result -Wsign-compare -g -fwrapv -O3 -Wall
-std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter
-Wno-missing
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +16179
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/16589
___
Python tracker
<https://bugs.python.org/issu
Vinay Sajip added the comment:
> We should not segfault here.
Agreed, MAX_ELEMENTS was set to be an upper bound which shouldn't be hit. I'll
investigate with OP's example data and see where the bug is.
--
___
Python tracker
<
Vinay Sajip added the comment:
This could perhaps be handled by just swallowing errors in the constructor (as
is done for Unix sockets, for example) and trying to connect in emit() if there
is no connection.
Not sure I want to go down the caching route - it complicates things for what
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 4f82a53c5d34df00bf2d563c2417f5e2638d1004 by Vinay Sajip (Miss
Islington (bot)) in branch '3.7':
bpo-38235: Correct some arguments names in logging documentation (GH-16571)
(GH-16577)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 3af2733a8265a2685b2c0466a58a66e544a81c64 by Vinay Sajip (Miss
Islington (bot)) in branch '3.8':
bpo-38235: Correct some arguments names in logging documentation (GH-16571)
(GH-16576)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 3142c667b50254daaa28f22c79bdda177136bd03 by Vinay Sajip (Ashley
Whetter) in branch 'master':
bpo-38235: Correct some arguments names in logging documentation (GH-16571)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor
Stinner) in branch 'master':
bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492)
https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4
Vinay Sajip added the comment:
New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor
Stinner) in branch 'master':
bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492)
https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4
Change by Vinay Sajip :
--
pull_requests: +16009
pull_request: https://github.com/python/cpython/pull/16430
___
Python tracker
<https://bugs.python.org/issue16
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
Closed, as these buildbots are now green. This was addressed via changes to the
original PR for bpo-22273.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracke
Vinay Sajip added the comment:
New changeset b92b8c53f63d2e805288ac2c665bf5887d1b7ca6 by Vinay Sajip in branch
'3.8':
[3.8] bpo-22273: Changed conditions for ctypes array-in-struct handling.
(GH-16381) (GH-16401)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
pull_requests: +15983
pull_request: https://github.com/python/cpython/pull/16401
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
New changeset d015714f89af5c57b7071a74eeca618577b3dfe4 by Vinay Sajip in branch
'3.7':
[3.7] bpo-22273: Changed conditions for ctypes array-in-struct handling.
(GH-16381) (GH-16400)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
pull_requests: +15982
pull_request: https://github.com/python/cpython/pull/16400
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
New changeset cc28ed2421bf3953efc0fbde387f28722f3801e2 by Vinay Sajip in branch
'master':
bpo-22273: Removed temporary test skipping on PPC platforms. (GH-16399)
https://github.com/python/cpython/commit/cc28ed2421bf3953efc0fbde387f28722f3801e2
Vinay Sajip added the comment:
Yes, sorry for the noise - I'm fixing it, and will close this issue once all
done.
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue38
Vinay Sajip added the comment:
> Please check if bpo-38272 regression is caused by this issue.
Yes, it is. Being worked on right now. Sorry for the noise.
--
___
Python tracker
<https://bugs.python.org/issu
Change by Vinay Sajip :
--
pull_requests: +15981
pull_request: https://github.com/python/cpython/pull/16399
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
New changeset 417089e88bd4ea146b9497e06e8edeb58a59cd65 by Vinay Sajip in branch
'master':
bpo-22273: Re-enabled ctypes test on ARM machines. (GH-16388)
https://github.com/python/cpython/commit/417089e88bd4ea146b9497e06e8edeb58a59cd65
Change by Vinay Sajip :
--
pull_requests: +15970
pull_request: https://github.com/python/cpython/pull/16388
___
Python tracker
<https://bugs.python.org/issue22
Change by Vinay Sajip :
--
pull_requests: +15961
pull_request: https://github.com/python/cpython/pull/16381
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
New changeset 57dc7d5ae8ebfb6da1ea2b25e61260ecb9c79faf by Vinay Sajip in branch
'master':
bpo-22273: Disabled tests while investigating buildbot failures on ARM7L/PPC64.
(GH-16377)
https://github.com/python/cpython/commit
Change by Vinay Sajip :
--
pull_requests: +15956
pull_request: https://github.com/python/cpython/pull/16377
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
New changeset 16c0f6df62a39f9f7712b1c0577de4eefcb4c1bf by Vinay Sajip (Miss
Islington (bot)) in branch '3.7':
bpo-22273: Update ctypes to correctly handle arrays in small structur…
(GH-15839) (GH-16369)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset ce62dcc460cf88f663c34c4a0948c1ee1dc53f4d by Vinay Sajip (Miss
Islington (bot)) in branch '3.8':
bpo-22273: Update ctypes to correctly handle arrays in small structur…
(GH-15839) (GH-16370)
https://github.com/python/cpython/commit
Vinay Sajip added the comment:
New changeset 12f209eccb1587e8c98057d9c5f865c21f4a16c1 by Vinay Sajip in branch
'master':
bpo-22273: Update ctypes to correctly handle arrays in small structur…
(GH-15839)
https://github.com/python/cpython/commit/12f209eccb1587e8c98057d9c5f865c21f4a16c1
Vinay Sajip added the comment:
Problem also seems to occur in 3.8 and 3.7.
--
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue38
New submission from Vinay Sajip :
There appears to be a failure in the Makefile build logic. Steps to reproduce:
1. Make a fresh build using "make clean && make"
2. run "touch Modules/_io/_iomodule.h"
3. Run "make" again.
Observed result: No re
Change by Vinay Sajip :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue35886>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
versions: +Python 3.9 -Python 3.3
___
Python tracker
<https://bugs.python.org/issue11410>
___
___
Python-bugs-list mailing list
Unsub
Change by Vinay Sajip :
--
pull_requests: +15924
pull_request: https://github.com/python/cpython/pull/16347
___
Python tracker
<https://bugs.python.org/issue11
Vinay Sajip added the comment:
Reopening, as a new patch is available.
--
nosy: +vinay.sajip
resolution: out of date ->
stage: resolved -> patch review
status: closed -> open
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
Is this issue still valid, or should it be closed as out of date?
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Vinay Sajip :
--
pull_requests: +15904
pull_request: https://github.com/python/cpython/pull/16328
___
Python tracker
<https://bugs.python.org/issue36
Vinay Sajip added the comment:
> Obviously the fix could be just to stop doing that in the standard library
Well, that's the right fix, and thanks for spotting it. I've applied those
changes (42b6c5d and 19c42fb) to the master, 3.8 and 3.7 branc
Change by Vinay Sajip :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue36876>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset 3b92ddb7612fd8fe2be95ff3d8022ed18335b13f by Vinay Sajip in branch
'3.8':
[3.8] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (GH-15927)
https://github.com/python/cpython/commit/3b92ddb7612fd8fe2be95ff3d8022ed18335b13f
Vinay Sajip added the comment:
New changeset aca878ecf18b9e915e9b551f095a550b5c6e9bc5 by Vinay Sajip in branch
'3.7':
[3.7] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (GH-15926)
https://github.com/python/cpython/commit/aca878ecf18b9e915e9b551f095a550b5c6e9bc5
Change by Vinay Sajip :
--
pull_requests: +15567
pull_request: https://github.com/python/cpython/pull/15927
___
Python tracker
<https://bugs.python.org/issue35
Change by Vinay Sajip :
--
pull_requests: +15566
pull_request: https://github.com/python/cpython/pull/15926
___
Python tracker
<https://bugs.python.org/issue35
Vinay Sajip added the comment:
New changeset 972cf5c06a5ba16ad243a442dbb9c15307fbed95 by Vinay Sajip (Alex) in
branch 'master':
bpo-35168: Make shlex.punctuation_chars read-only (#11631)
https://github.com/python/cpython/commit/972cf5c06a5ba16ad243a442dbb9c15307fbed95
Change by Vinay Sajip :
--
pull_requests: -11403
___
Python tracker
<https://bugs.python.org/issue35168>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
pull_requests: -11401
___
Python tracker
<https://bugs.python.org/issue35168>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
pull_requests: -11402
___
Python tracker
<https://bugs.python.org/issue35168>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Vinay Sajip :
--
pull_requests: +15486
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15839
___
Python tracker
<https://bugs.python.org/issu
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +15485
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15839
___
Python tracker
<https://bugs.python.org/issu
Change by Vinay Sajip :
--
pull_requests: +15484
pull_request: https://github.com/python/cpython/pull/15839
___
Python tracker
<https://bugs.python.org/issue22
Vinay Sajip added the comment:
> We've basically agreed that you should be able to load resources from
> subdirectories that aren't packages. It turns out to be not a simple change
> in importlib.resources, but contributions are welcome!
In case anyone is interested, I've alr
Vinay Sajip added the comment:
> are we here to punish people
No, that's not what I'm saying. But it's not a priority to support situations
where people don't follow published APIs and still expect things to work the
way they would like. I would prefer people to use setLevel(), as it he
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
> There's no way to be sure. But if you have a public (i.e.
> non-underscore-prfixed) attribute then some percentage of people are going to
> set it, particularly if it seems to work.
Well, reading it isn't problematic, so there's no leading u
Vinay Sajip added the comment:
New changeset 264e034f990240e2aa379d8484b15b9e70c1fad5 by Vinay Sajip in branch
'master':
bpo-37662: Documented venv.EnvBuilder.upgrade_dependencies(). (GH-15768)
https://github.com/python/cpython/commit/264e034f990240e2aa379d8484b15b9e70c1fad5
Vinay Sajip added the comment:
Link to issue has changed to:
https://github.com/libffi/libffi/issues/33
--
___
Python tracker
<https://bugs.python.org/issue16
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +15421
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15768
___
Python tracker
<https://bugs.python.org/issu
Vinay Sajip added the comment:
The install_scripts() API is intended to allow users to add their own
venv-specific scripts from their own project folders. We could add an
install_resources() method, which would add all the resources in a given
package. The signature would be
def
Vinay Sajip added the comment:
This has reportedly been fixed by the changes made to fix bpo-37354. I'll close
this, but please reopen if you find it's still a problem.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Vinay Sajip added the comment:
That code in the wild that sets the level attribute directly is wrong and
should be changed, right? The documentation has always been clear that
setLevel() should be used. If we now take steps to support setting the level
via attribute, isn't that encouraging
Change by Vinay Sajip :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Vinay Sajip added the comment:
New changeset cb65b3a4f484ce71dcb76a918af98c7015513025 by Vinay Sajip in branch
'master':
bpo-37742: Return the root logger when logging.getLogger('root') is c… (#15077)
https://github.com/python/cpython/commit/cb65b3a4f484ce71dcb76a918af98c7015513025
Change by Vinay Sajip :
--
keywords: +patch
pull_requests: +14824
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15077
___
Python tracker
<https://bugs.python.org/issu
Change by Vinay Sajip :
--
assignee: -> vinay.sajip
___
Python tracker
<https://bugs.python.org/issue37742>
___
___
Python-bugs-list mailing list
Unsubscrib
301 - 400 of 2016 matches
Mail list logo
