Yury Selivanov added the comment:
> > one of the things we want to fix is to eliminate non-PyObject
> pointer types from public APIs entirely.
> A notable exception is Py_buffer. [1]
Right, because Py_buffer isn't a PyObject at all :)
> Using PyObject for contextv
Yury Selivanov added the comment:
>> We'll need to make a prominent notice in the release notes though.
> Something can be added at:
https://docs.python.org/dev/whatsnew/3.7.html#notable-changes-in-python-3-7-1
Yeah, thank you for suggestion, I'll do that. I'll also update the
Change by Yury Selivanov :
--
pull_requests: +
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Yury Selivanov :
There's no point in always creating a deque() for waiters in Lock.__init__.
Not all locks end up using waiters.
--
components: asyncio
messages: 325997
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Optimize
Yury Selivanov added the comment:
Just to add to this issue: I originally realized that something is wrong with
the design when we had a super hard to track memory leak in uvloop, caused by
Cython being unable to automatically manage increfs/decrefs for PyContext*
pointers. So I do believe
Change by Yury Selivanov :
--
keywords: +patch
pull_requests: +8886
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34762>
___
___
Py
New submission from Yury Selivanov :
Unfortunately, the current C API for PEP 567 has a flaw: it uses non-PyObject
pointers.
This causes problems with integrating with tools like Cython, where PyObject is
special and a lot of machinery recognizes it and manages refcounts correctly
Yury Selivanov added the comment:
> So I think we just need to fix ag_running and then recommend people find
> other ways to interrupt running async generators.
Agree. Speaking of fixing ag_running, could you please review my PR:
https://github.com/python/cpython/pull/7468 I can then
Yury Selivanov added the comment:
Interesting.
Nathaniel, do you have this problem in Trio (aclose() not cancelling an
anext()) or cancel scopes solve this problem somehow?
--
nosy: +njs
___
Python tracker
<https://bugs.python.org/issue34
Yury Selivanov added the comment:
> This will let people confused. IMO we should use `coroutine object` or
> `coroutine function` instead of coroutine when it means an object.
I'm not sure that it's a good idea to apply this change everywhere, but I think
in general this is a good ide
Yury Selivanov added the comment:
New changeset e247b46cba4f4d32ea96a15dbc36d73265171106 by Yury Selivanov in
branch 'master':
bpo-33649: More improvements (GH-9439)
https://github.com/python/cpython/commit/e247b46cba4f4d32ea96a15dbc36d73265171106
Change by Yury Selivanov :
--
pull_requests: +8853
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Thanks for filing the bug!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Yury Selivanov added the comment:
New changeset ffef50f1f5907e5f0f175b12088d3e509011f126 by Yury Selivanov in
branch 'master':
bpo-34746: Fix stop -> close (GH-9437)
https://github.com/python/cpython/commit/ffef50f1f5907e5f0f175b12088d3e509011f
Change by Yury Selivanov :
--
keywords: +patch
pull_requests: +8851
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34746>
___
___
Py
Yury Selivanov added the comment:
Aaand... it's back.
--
___
Python tracker
<https://bugs.python.org/issue34733>
___
___
Python-bugs-list mailing list
Unsub
Yury Selivanov added the comment:
I'll revisit this later.
--
___
Python tracker
<https://bugs.python.org/issue21998>
___
___
Python-bugs-list mailing list
Unsub
Yury Selivanov added the comment:
Would you be able to test uvloop/master branch? Current uvloop 0.11.x uses
pretty much the asyncio implementation; the master branch has a completely
rewritten SSL layer. If the master branch has the leak it might mean that the
root cause is indeed
Yury Selivanov added the comment:
What is "raw asyncio SSL sockets"? We don't use SSL sockets in asyncio, we use
SSL Memory BIO. Do you think that some SSL context objects aren't being
properly released?
BTW, can you see the leak when run un
Yury Selivanov added the comment:
Closing this now, please reopen if there's still no search bar in a few hours.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Yury Selivanov added the comment:
New changeset 581890cda36f60cd46185c6e184abe35a95813a2 by Yury Selivanov in
branch '3.7':
bpo-34733: Return of the docs search bar (GH-9431)
https://github.com/python/cpython/commit/581890cda36f60cd46185c6e184abe35a95813a2
Yury Selivanov added the comment:
> Does master and 3.7 branch build the docs at different times? It's odd to me
> that master still shows the search box and 3.7 does not.
layout.html was refactored in 3.8: scripts were moved into separate files. I
accidentally copied it from 3.8
Change by Yury Selivanov :
--
keywords: +patch
pull_requests: +8848
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34733>
___
___
Py
Yury Selivanov added the comment:
Oh, this is a result of asyncio docs 3.8 -> 3.7 backport. I'll fix this.
--
___
Python tracker
<https://bugs.python.org/issu
Change by Yury Selivanov :
--
nosy: -yselivanov
___
Python tracker
<https://bugs.python.org/issue34694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
> I think the idea here is: don’t feed the trolls.
+1. Please stop this.
Larry, IMHO, if you seriously want to discuss this issue (and bring more
attention to it) I think you should email to python-commiters. Otherwise this
is just a pointless distract
Yury Selivanov added the comment:
New changeset 471503954a91d86cf04228c38134108c67a263b0 by Yury Selivanov in
branch 'master':
bpo-33649: Add a high-level section about Futures; few quick fixes (GH-9403)
https://github.com/python/cpython/commit/471503954a91d86cf04228c38134108c67a263b0
Yury Selivanov added the comment:
Same for asyncio.wait and asyncio.wait_for.
--
___
Python tracker
<https://bugs.python.org/issue34728>
___
___
Python-bug
New submission from Yury Selivanov :
asyncio.sleep is a coroutine; passing a *loop* argument to it makes no sense
anymore.
We should raise a DeprecationWarning in Python 3.8 and 3.9 and remove it in 4.0.
--
components: asyncio
keywords: easy
messages: 325684
nosy: asvetlov
Change by Yury Selivanov :
--
pull_requests: +8826
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
New changeset b042cf10c6084d14279c55a7e0d2d7595ff4e694 by Yury Selivanov in
branch 'master':
bpo-33649: Fix markup; add another note that asyncio.run is 3.7+ (GH-9389)
https://github.com/python/cpython/commit/b042cf10c6084d14279c55a7e0d2d7595ff4e694
Change by Yury Selivanov :
--
pull_requests: +8813
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
New changeset ac94e38d076aebc56c2ff96a249b5e40f32633ea by Yury Selivanov in
branch 'master':
bpo-33649: Note that asyncio.run() calls shutdown_asyncgens() (GH-9380)
https://github.com/python/cpython/commit/ac94e38d076aebc56c2ff96a249b5e40f32633ea
Yury Selivanov added the comment:
> Ned, do we auto run docs build for Python 3.7? Or do we only build them on
> release?
Never mind, the docs for 3.7 have been updated!
--
___
Python tracker
<https://bugs.python.org/i
Change by Yury Selivanov :
--
pull_requests: +8804
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Ned, do we auto run docs build for Python 3.7? Or do we only build them on
release?
--
nosy: +ned.deily
___
Python tracker
<https://bugs.python.org/issue33
Yury Selivanov added the comment:
Wow, we did this! I've just pushed a backport of the new documentation to 3.7.
Thanks to Carol, Elvis, and Andrew for the help!
I think this issue can now be closed, we'll open new ones for:
1. A high-level intro/tutorial for asyncio.
2. A low-level
Yury Selivanov added the comment:
New changeset 512d7101098b971837cbb406942215244f636547 by Yury Selivanov in
branch '3.7':
bpo-33649: Backport asyncio docs from 'master' to 3.7 (GH-9377)
https://github.com/python/cpython/commit/512d7101098b971837cbb406942215244f636547
Change by Yury Selivanov :
--
pull_requests: +8801
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
New changeset 1fa2ec49bec50bea1847b558b883c5c904334734 by Yury Selivanov (Elvis
Pranskevichus) in branch 'master':
bpo-33649: A copy-editing pass on asyncio documentation (GH-9376)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
New changeset 3085534c398e6b181e7a9ac0cb9c80f3c670f2b9 by Yury Selivanov in
branch 'master':
bpo-33649: Add a hello world example to asyncio.rst (GH-9374)
https://github.com/python/cpython/commit/3085534c398e6b181e7a9ac0cb9c80f3c670f2b9
Change by Yury Selivanov :
--
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
Thanks to Julien and Carol for reviews and sharing the opinion! I'm closing
this issue now.
In case someone needs the numbering to be re-enabled for some reason we can
re-open this issue and discuss the best approach how to make that happen, while
making
Yury Selivanov added the comment:
New changeset c62ab2862db2382808bb2228760eebdda3f608bd by Yury Selivanov in
branch 'master':
bpo-34717: Stop numbering stdlib titles/sections in the docs (GH-9370)
https://github.com/python/cpython/commit/c62ab2862db2382808bb2228760eebdda3f608bd
Change by Yury Selivanov :
--
pull_requests: +8798
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Yury Selivanov :
--
nosy: +mdk
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Yury Selivanov :
--
keywords: +patch
pull_requests: +8793
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Py
Yury Selivanov added the comment:
Please refer to the attached screenshots to see the difference.
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Yury Selivanov :
Added file: https://bugs.python.org/file47812/after_2.png
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list m
Change by Yury Selivanov :
Added file: https://bugs.python.org/file47811/after_1.png
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list m
Change by Yury Selivanov :
--
nosy: +willingc -mdk
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list mai
Change by Yury Selivanov :
--
nosy: +ezio.melotti
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Yury Selivanov :
Added file: https://bugs.python.org/file47810/now_1.png
___
Python tracker
<https://bugs.python.org/issue34717>
___
___
Python-bugs-list mailin
New submission from Yury Selivanov :
I'd like to remove the ":numbered:" option from Doc/library/index.rst TOC.
Most standard library modules don't have extensive documentation, but some, for
example asyncio, have. For such modules, numbering makes title to contain too
much nois
Yury Selivanov added the comment:
New changeset 394374e30c85f6eacddbbfc7471aab62b54ce021 by Yury Selivanov in
branch 'master':
bpo-33649: Add low-level APIs index. (GH-9364)
https://github.com/python/cpython/commit/394374e30c85f6eacddbbfc7471aab62b54ce021
Change by Yury Selivanov :
--
pull_requests: +8788
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
> How much do you think it hurts to have it always loaded into memory, even if
> it hasn't truly been imported or used?
I'd be fine with that. Would you be able to do the necessary change (I don't
have VS a
Yury Selivanov added the comment:
New changeset 5cc583d94095ed3bb543fa2f032f9593a6315a52 by Yury Selivanov
(Bumsik Kim) in branch 'master':
bpo-33649: Clarify protocol_factory as a method parameter (GH-9330)
https://github.com/python/cpython/commit/5cc583d94095ed3bb543fa2f032f9593a6315a52
Yury Selivanov added the comment:
The issue here is not the recursion, but rather about the fact that coroutines
should actually await on IO or other activity in order for the event loop to
run them cooperatively. E.g.
async def foo():
await foo()
doesn't really do anything
Yury Selivanov added the comment:
New changeset 805e27eff65d51f7aea2c00ccbb4f5d44f4499f2 by Yury Selivanov in
branch 'master':
bpo-33649: Fix asyncio-dev (GH-9324)
https://github.com/python/cpython/commit/805e27eff65d51f7aea2c00ccbb4f5d44f4499f2
Change by Yury Selivanov :
--
pull_requests: +8749
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
New changeset 7372c3bbefb4763dbd1b6d66f7971bef28c0f056 by Yury Selivanov in
branch 'master':
bpo-33649: Add high-level APIs cheat-sheet (GH-9319)
https://github.com/python/cpython/commit/7372c3bbefb4763dbd1b6d66f7971bef28c0f056
Yury Selivanov added the comment:
New changeset 6c7316439d966cdbc76ffcc005e5d9c563064ba2 by Yury Selivanov in
branch 'master':
bpo-33649: Refresh asyncio docs landing page (GH-9322)
https://github.com/python/cpython/commit/6c7316439d966cdbc76ffcc005e5d9c563064ba2
Change by Yury Selivanov :
--
pull_requests: +8748
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Yury Selivanov :
--
pull_requests: +8744
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
I'm not sure that ProactorEventLoop is stable enough TBH :( And I wouldn't be
able to be on call for Windows users to fix all bugs in ProactieEventLoop.
Andrew, your thoughts on this?
--
___
Python tracker
Change by Yury Selivanov :
--
pull_requests: +8739
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
New changeset 5b7cbd602e57265604d6c099fd174b1c7917f861 by Yury Selivanov (Carol
Willing) in branch 'master':
bpo-33649: Edit asyncio eventloop doc - second pass (GH-9233)
https://github.com/python/cpython/commit/5b7cbd602e57265604d6c099fd174b1c7917f861
Yury Selivanov added the comment:
New changeset aca819fb494d4801b3e5b5b507b17cab772c1b40 by Yury Selivanov
(Bumsik Kim) in branch 'master':
bpo-33649: Fix doc to reflect changes in 47cd10d (or bpo-23347) (GH-9219)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
New changeset aca819fb494d4801b3e5b5b507b17cab772c1b40 by Yury Selivanov
(Bumsik Kim) in branch 'master':
bpo-33649: Fix doc to reflect changes in 47cd10d (or bpo-23347) (GH-9219)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
New changeset 8be876e44b2dffb96b551029454cbfb16d697992 by Yury Selivanov in
branch 'master':
bpo-33649: Cleanup asyncio/streams and asyncio/synchronization docs (GH-9192)
https://github.com/python/cpython/commit/8be876e44b2dffb96b551029454cbfb16d697992
Change by Yury Selivanov :
--
pull_requests: +8630
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
The first PR has been just landed.
The plan is to work in 'master' branch and when the docs are ready we backport
them to 3.7 in one big PR.
So far the following files were updated/reviewed:
Doc/library/asyncio-eventloop.rst
Doc/library/asyncio
Yury Selivanov added the comment:
New changeset 7c7605ff1133cf757cac428c483827f666c7c827 by Yury Selivanov in
branch 'master':
bpo-33649: First asyncio docs improvement pass (GH-9142)
https://github.com/python/cpython/commit/7c7605ff1133cf757cac428c483827f666c7c827
Change by Yury Selivanov :
--
keywords: +patch
pull_requests: +8592
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33649>
___
___
Py
Change by Yury Selivanov :
--
components: -asyncio
nosy: -yselivanov
___
Python tracker
<https://bugs.python.org/issue34605>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
Great, thanks! There's someone working on a pr to add them as builtins (so that
pr is in C). I'll have to take a look when i'm back from vacation at that pr
too, before we can make a decision.
I've been to europython, pycon ru, and pybay conferences
Yury Selivanov added the comment:
> Is netdb_lock the GIL?
No, it's a lock used by getaddrinfo specifically on *some* platforms. It
doesn't look like it's used on Windows.
> If the thread pooling was effective, the slowdown wouldn't be linear, but it
> does indeed appear to be
Yury Selivanov added the comment:
> As far as our experiments show, the requests are blocking each other
> irrespective of thread pool size. Which is expected since the lock is global
> across threads.
It looks like you don't understand how GIL works in Python (sorry if I'm
Yury Selivanov added the comment:
> so that they wouldn't block the whole event loop.
The aren't blocking it now as they are executed in a thread pool.
--
___
Python tracker
<https://bugs.python.org/issu
Yury Selivanov added the comment:
This isn't something we want to do in Python. We have a dynamic but strict
type system. 1 + '1' is an error in Python, but works just fine in JavaScript.
Likewise, in 'await foo' foo is expected to be an awaitable in Python and not
anything else. This has
Change by Yury Selivanov :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue34270>
___
___
Python-bugs-list mailing list
Unsubscrib
Yury Selivanov added the comment:
> I'll do that if you say so, but I'm just saying that the C and Python
> implementations will still remain different in semantics then.
Probably I'm missing something here. How would they be dif
Yury Selivanov added the comment:
Please just change PyUnicode_Check to PyUnicode_CheckExact in C Task.__init__
and use the same if check in C Task.set_name.
--
___
Python tracker
<https://bugs.python.org/issue34
Yury Selivanov added the comment:
Let's just reuse this issue, it's just a small fix.
--
resolution: fixed ->
___
Python tracker
<https://bugs.python.org/issu
Yury Selivanov added the comment:
> Ok, I understand. But is the conversion a bad thing then?
It's not a bad thing, it's just that we don't do it in C Task and we do it in
pure Python Task. Eric wants us to synchronize them so that in a very unlikely
scenario where someone uses subclas
Yury Selivanov added the comment:
> I also couldn't figure out yet why PyUnicode_Check() was necessary in the
> first place. Doesn't PyObject_Str() just increment the refcount if the
> argument is already a string?
`str()` returns its argument if it's exactly a `builtins.str`
Yury Selivanov added the comment:
As a side note, Alex, what do you think about appending coroutine's name to
Task's name if the latter is autogenerated?
--
___
Python tracker
<https://bugs.python.org/issue34
Yury Selivanov added the comment:
> 2. change the check to PyUnicode_CheckExact()
I'd be OK with this, but why is this important?
--
___
Python tracker
<https://bugs.python.org/issu
Yury Selivanov added the comment:
Thank you for the contribution!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Yury Selivanov added the comment:
New changeset cca4eec3c0a67cbfeaf09182ea6c097a94891ff6 by Yury Selivanov (Alex
Grönholm) in branch 'master':
bpo-34270: Make it possible to name asyncio tasks (GH-8547)
https://github.com/python/cpython/commit/cca4eec3c0a67cbfeaf09182ea6c097a94891ff6
Yury Selivanov added the comment:
Since we're deprecating generator-based coroutines anyways, I too think that
the check can be relaxed.
--
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue34
Yury Selivanov added the comment:
Status update: I'm working on a first rewrite. I expect to have something to
review on a couple of weeks.
--
___
Python tracker
<https://bugs.python.org/issue33
Yury Selivanov added the comment:
> Depending on the configuration, stat() in a network filesystem can be between
> very slow and slow.
+1. I also quickly glanced over the patch and I think it looks like a clear
win.
--
___
Python t
Yury Selivanov added the comment:
Merged. Thank you, hope that you'll keep contributing! :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Yury Selivanov added the comment:
New changeset 6f16ffc1879fc934eba297b3e81bd940e32a7e03 by Yury Selivanov (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-34263 Cap timeout submitted to epoll/select etc. to one day.
(GH-8532) (GH-8587)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
New changeset 172a81e42bc30da1bd4027db9cd3b6172469f7fe by Yury Selivanov (Miss
Islington (bot)) in branch '3.7':
[3.7] bpo-34263 Cap timeout submitted to epoll/select etc. to one day.
(GH-8532) (GH-8586)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
New changeset 944451cd8d3e897138f4b43569de13cd081ee251 by Yury Selivanov
(MartinAltmayer) in branch 'master':
bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532)
https://github.com/python/cpython/commit
Yury Selivanov added the comment:
> Should `getsourcefile` be changed to match?
I'd say yes. There's no point in getsourcefile returning the file location of
the topmost decorator. Feel free to open a new issue and submit a PR to
New submission from Yury Selivanov :
asyncio documentation has this bit on timeouts:
Timeouts (relative *delay* or absolute *when*) should not exceed one day.
Victor told me that the actual reason for this recommendation is a limitation
in epoll (or other OS/selector) that prevents us
401 - 500 of 3072 matches
Mail list logo
