[issue16902] Add OSS module support for Solaris

2013-01-10 Thread brian-cameron-oracle
brian-cameron-oracle added the comment: Since Modules/ossaudiodev.c has the following line (which is not surrounded by any conditional #ifdef sort of things): #include sys/soundcard.h This means that the OSS plugin will only build on a system that has this header file, so it is safe to check

[issue16902] Add OSS module support for Solaris

2013-01-09 Thread brian-cameron-oracle
New submission from brian-cameron-oracle: Solaris supports OSS, but the attached patch is needed to get it to build. Note that some of the EXPORT_INT lines in Modules/ossaudiodev.c need to be #ifndef'ed out on Sun since OSS on Solaris doesn't support them all. Does it make sense to use

[issue16902] Add OSS module support for Solaris

2013-01-09 Thread brian-cameron-oracle
brian-cameron-oracle added the comment: OSS is the default audio system in Solaris 11 and 12. In Solaris 10 and earlier, the sunaudio (or SADA) interfaces are still used. You can only test this if you are using Solaris 11 or later, on a machine with a sound card supported by OSS. I would

[issue16902] Add OSS module support for Solaris

2013-01-09 Thread brian-cameron-oracle
brian-cameron-oracle added the comment: Correct, OSS should work out-of-the-box on Solaris 11 and up since it is the default audio system there. OSS was also integrated into OpenSolaris, so it is probably the most sensible audio plugin to use there also. Some end-users may build and install

[issue16902] Add OSS module support for Solaris

2013-01-09 Thread brian-cameron-oracle
brian-cameron-oracle added the comment: Sure, doing multiple #ifdef's makes sense. Do you need me to provide an updated patch, or is this something easier for someone who has commit access to the source code repository to just go ahead and do. I would think this Module would fail to compile

[issue16902] Add OSS module support for Solaris

2013-01-09 Thread brian-cameron-oracle
brian-cameron-oracle added the comment: I'm not sure how to write such OSS detection code. I do know that OSS is only on Solaris systems that have this OSS-specific file: /usr/include/sys/soundcard.h So that's probably the best way to check and it should work even on Solaris 10 if OSS