danblack added the comment:
I've committed the latest patch. Thank you very much!
much appreciate your help.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
danblack added the comment:
I don't know which error code should be returned in this case.
Thanks Christian. My fault - asked Antoine to remove the default value for it
and didn't see this like.
make line 2403:
return SSL_TLSEXT_ERR_OK
danblack added the comment:
If it isn't very clear to you, I can still handle it myself, though. Those
docs aren't the best.
Not clear enough. Yes I'd appreciate you handling it. Thanks.
--
___
Python tracker rep...@bugs.python.org
http
Changes by danblack daniel.bl...@openquery.com:
Added file: http://bugs.python.org/file28326/issue-8109-sni-serverside.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
danblack added the comment:
I've added a full set of alert descriptions and cleaned up the doco some more.
The reference counting when the SNI callback comes in is my greatest worry.
--
Added file: http://bugs.python.org/file28271/issue-8109-sni-serverside.patch
danblack added the comment:
the one error in the previous review corrected.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
___
___
Python
danblack added the comment:
Antoine Pitrou (pitrou) * Date: 2012-10-06 13:10
Daniel, I'll take a look.
minor nag :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
danblack added the comment:
happy with this?
I'm not sure what i've done to make s._set_context(newctx) work but s.context =
newctx fail. I though the code here
http://bugs.python.org/review/8109/diff2/5815:5989/Lib/ssl.py effectively maps
them
Changes by danblack daniel.bl...@openquery.com:
Removed file: http://bugs.python.org/file26950/issue8109_server_side_sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8109
danblack added the comment:
Daniel, your patch looks quite interesting. Please, send a contributor
agreement to the PSF: http://www.python.org/psf/contrib/contrib-form-python/
. Let me know when you status have changed.
Already done. Has been accepted and I've got an acknowledgement email
danblack added the comment:
Thanks for the patch
Daniel. 3.3 is nearing the release candidate phase, so I'm re-targetting to
3.4. I'll take a detailed look soon.
Welcome. Just noticed conflicts with #4473 in the client POP implementation.
Hopefully they are close anyway.
(I suppose
Changes by danblack daniel.bl...@openquery.com:
Removed file:
http://bugs.python.org/file26918/issue_10852_pop-smtp-imap-nntp.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
danblack added the comment:
previous patch had dumb error and even failed test suit. Now fixed.
--
Added file: http://bugs.python.org/file26949/issue10852-sni.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10852
danblack added the comment:
test_sni not working. getpeercert() not returning a certificate.
--
keywords: +patch
nosy: +daniel-black
Added file: http://bugs.python.org/file26950/issue8109_server_side_sni.patch
___
Python tracker rep
danblack added the comment:
Antoine,
I copied off your http example for all the other protocols.
tested with:
import smtplib
a = smtplib.SMTP_SSL('gmail-smtp-in.l.google.com.')
a.starttls()
a = smtplib.SMTP_SSL('mail.internode.on.net')
a = smtplib.SMTP_SSL('smtp.gmail.com')
import ftplib
15 matches
Mail list logo
