[issue32835] Add documention mentioning that Cygwin isn't fully compatible

Diana added the comment: Hi, I've created a pull request for pep 11. https://github.com/python/peps/pull/2065 -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/is

[issue20803] doc: clarify that struct.pack_into writes 0x00 for pad bytes

Change by Diana : -- keywords: +patch pull_requests: +26493 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28047 ___ Python tracker <https://bugs.python.org/issu

[issue20803] doc: clarify that struct.pack_into writes 0x00 for pad bytes

Diana added the comment: I'm working on this -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue20803> ___ ___ Python-bugs-list m

[issue24888] FileNotFoundException raised by subprocess.call

Change by Diana : -- keywords: +patch pull_requests: +26464 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker <https://bugs.python.org/issu

[issue24388] Python readline module crashes in history_get on FreeBSD with libedit

Change by Diana : -- nosy: +DonnaDia nosy_count: 3.0 -> 4.0 pull_requests: +26463 pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker <https://bugs.python.org/issu

[issue24888] FileNotFoundException raised by subprocess.call

Diana added the comment: Hi, I will work on this. I will create a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue24

[issue44925] [docs] Confusing deprecation notice for typing.IO

Change by Diana : -- keywords: +patch pull_requests: +26446 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28004 ___ Python tracker <https://bugs.python.org/issu

[issue44925] [docs] Confusing deprecation notice for typing.IO

Diana added the comment: Hi, I can handle this. I will provide a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue44

[issue33426] [doc] Behavior of os.path.join does not match documentation

Change by Diana : -- keywords: +patch pull_requests: +26445 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28003 ___ Python tracker <https://bugs.python.org/issu

[issue33426] [doc] Behavior of os.path.join does not match documentation

Diana added the comment: Hi, I'm working on it. I will provide the pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/is

[issue34804] Repetition of 'for example' in documentation

Diana added the comment: I will handle it. I will send a pull request within 3 days. -- nosy: +DonnaDia ___ Python tracker <https://bugs.python.org/issue34

[issue30274] Rename 'name' to 'fullname' argument to ExtensionFileLoader

Diana Van Straaten added the comment: I want to work on it. -- nosy: +zemlya3018 ___ Python tracker <https://bugs.python.org/issue30274> ___ ___ Python-bug

[issue31657] unit test for optimization levels does not cover __debug__ case

Change by diana : -- keywords: +patch pull_requests: +3827 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue31657> ___ ___ Python-

[issue31657] unit test for optimization levels does not cover __debug__ case

New submission from diana : There are currently three supported optimization levels (0, 1, and 2). Briefly summarized, they do the following. 0: no optimizations 1: remove assert statements and __debug__ blocks 2: remove docstrings, assert statements, and __debug__ blocks The

[issue2506] Add mechanism to disable optimizations

Changes by diana : -- nosy: +diana ___ Python tracker <http://bugs.python.org/issue2506> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue25711] Rewrite zipimport from scratch

Changes by diana : -- nosy: +diana ___ Python tracker <http://bugs.python.org/issue25711> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue22174] property doc fixes

diana added the comment: This whitespace? Or did you mean something else? class C: def __init__(self): self._x = None def getx(self): return self._x def setx(self, value): self._x = value def delx(self

[issue22174] property doc fixes

Changes by diana : Added file: http://bugs.python.org/file36319/Screen Shot 2014-08-08 at 4.44.07 PM.png ___ Python tracker <http://bugs.python.org/issue22174> ___ ___

[issue22174] property doc fixes

New submission from diana: The property docs are a bit funky. https://docs.python.org/3/library/functions.html#property 1) docstrings have zero to do with making a read-only property. It currently says: "If given, doc will be the docstring of the property attribute. Otherwise

[issue21582] use support.captured_stdx context managers - test_asyncore

diana added the comment: I removed some of the "from" imports and used support.x instead for consistency. "support" was already being imported, and many of the things imported from "support" were already using support.x.

[issue21583] use support.catpured_stderr context manager - test_logging

diana added the comment: oops, typo: - Updated test_logging (not test_asyncore) to use the support.catpured_stderr context manager -- ___ Python tracker <http://bugs.python.org/issue21

[issue21583] use support.catpured_stderr context manager - test_logging

New submission from diana: - Updated test_asyncore to use the support.catpured_stderr context manager - Removed unused imports -- components: Tests files: use_support_captured_stderr_test_logging.patch keywords: patch messages: 219165 nosy: diana priority: normal severity: normal status

[issue21582] use support.catpured context managers - test_asyncore

Changes by diana : -- title: use the support.catpured_stdout/stderr context managers - test_asyncore -> use support.catpured context managers - test_asyncore ___ Python tracker <http://bugs.python.org/issu

[issue21582] use the support.catpured_stdout/stderr context managers - test_asyncore

New submission from diana: Updated test_asyncore to use the support.catpured_stdout/stderr context managers rather than try/finally blocks. -- components: Tests files: use_support_captured_test_asyncore.patch keywords: patch messages: 219162 nosy: diana priority: normal severity

[issue21357] Increase filecmp test coverage from 63% to 76%

diana added the comment: Thanks Benjamin! -- ___ Python tracker <http://bugs.python.org/issue21357> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21357] Increase filecmp test coverage from 63% to 76%

diana added the comment: Nice, the support.catpured_stdout() context manager is much better. I've added a new patch with that change: increase_filecmp_test_coverage__updated_to_use_context_manager.patch Thanks for reviewing this, Benjamin! PS. I signed the contributor agre

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by diana : Removed file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker <http://bugs.python.org/issue21357> ___ ___

[issue21357] Increase filecmp test coverage from 63% to 76%

Changes by diana : Added file: http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch ___ Python tracker <http://bugs.python.org/issue21357> ___ ___

[issue21357] Increase filecmp test coverage from 63% to 76%

New submission from diana: - Increase filecmp test coverage from 63% to 76% - I left the testing style as-is, though it could probably be modernized. - I did not attempt to add coverage for 'funny_files', 'subdirs', etc, next pass perhaps. - Before: diana$ ./python.exe

[issue21355] Shallow defaults to True, not 1 [filecmp.cmp]

Changes by diana : -- title: shallow defaults to true, not 1 [filecmp.cmp] -> Shallow defaults to True, not 1 [filecmp.cmp] ___ Python tracker <http://bugs.python.org/issu

[issue21355] shallow defaults to true, not 1 [filecmp.cmp]

New submission from Diana Clarke: A minor correction to the filecmp.cmp doc string. 'defaults to 1' -> 'defaults to True' While shallow used to default to 1 years ago, it now defaults to True. def cmp(f1, f2, shallow=True): PS. I know this diff is annoyingly tr