[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-06-08 Thread fumihiko kakuma
fumihiko kakuma added the comment: Thank you in advance. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21600 ___ ___ Python-bugs-list mailing

[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-06-07 Thread fumihiko kakuma
fumihiko kakuma added the comment: Hi michael, Certainly, thank you for your many advices. I attached the new patch file. -- Added file: http://bugs.python.org/file35513/support_patch_dict_by_stopall.diff ___ Python tracker rep...@bugs.python.org

[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-06-06 Thread fumihiko kakuma
fumihiko kakuma added the comment: Thank you for your reply. Yes, you are right. The patch was too slapdash. I re-created it and added unit tests. -- Added file: http://bugs.python.org/file35499/support_patch_dict_by_stopall.diff ___ Python tracker

[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-06-02 Thread fumihiko kakuma
fumihiko kakuma added the comment: Checking mock.py(version 1.0.1) it seems that patch.stopall does not support patch.dict. Does it have any problem to support ptch.dict by stopall. I made the attached patch file for this. It seems to work well. How about this? But I don't know why sys.modules

[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-05-28 Thread fumihiko kakuma
New submission from fumihiko kakuma: It seems that stopall doesn't work when do start patch.dict to sys.modules. I show sample scripts the following. Using stopall test case seems to always refer the first mock foo object. But using stop it refers a new mock foo object. $ cat test_sampmod.py