[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Fred L. Drake, Jr.
Changes by Fred L. Drake, Jr. fdr...@acm.org: -- nosy: +fdrake ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___ ___ Python-bugs-list

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. fdr...@acm.org added the comment: Causing perfectly good Python 2 applications to degrade in performance is bad, even if something else is available. This should be fixed as a regression. -- ___ Python tracker

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: This should be fixed as a regression. As far as I understand, this is not a regression. I don't think the cStringIO code has changed in years. -- ___ Python tracker rep...@bugs.python.org

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. fdr...@acm.org added the comment: Ok, reading more carefully, it's not a regression. But it's certainly a bug, and should be fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: Ok, reading more carefully, it's not a regression. But it's certainly a bug, and should be fixed. Right. The patch looks straightforward, but I'm not familiar with the cStringIO code. Could you take a look? --

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. fdr...@acm.org added the comment: Assigning to myself for review. -- assignee: - fdrake keywords: +needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___

[issue10045] poor cStringIO.StringO seek performance

2010-10-11 Thread Fred L. Drake, Jr.
Fred L. Drake, Jr. fdr...@acm.org added the comment: Committed with minor changes in r85366 (release27-maint branch). -- keywords: -needs review resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org

[issue10045] poor cStringIO.StringO seek performance

2010-10-08 Thread Patrick Strawderman
Patrick Strawderman patr...@zope.com added the comment: Fair enough, but there is a great deal of existing code that already uses cStringIO. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread Patrick Strawderman
New submission from Patrick Strawderman patr...@zope.com: cStringIO.StringO's seek method has O(n) characteristics in certain, albeit pathological, cases, while the pure Python implementation and cStringIO.StringI's seek methods both execute in constant time in all cases. When the file offset

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread Patrick Strawderman
Changes by Patrick Strawderman patr...@zope.com: -- components: +None type: - performance ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread Patrick Strawderman
Changes by Patrick Strawderman patr...@zope.com: -- components: -None ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___ ___

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread Patrick Strawderman
Patrick Strawderman patr...@zope.com added the comment: The second sentence should have said the gap is filled in with n null bytes -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread R. David Murray
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045 ___ ___ Python-bugs-list

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: I'm changing the versions to just 2.7 (though I'm not sure this can be considered a bug fix), since StringIO is reimplemented as part of io in 3.x. -- nosy: +r.david.murray versions: -Python 2.6, Python 3.1, Python 3.2, Python

[issue10045] poor cStringIO.StringO seek performance

2010-10-07 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I don't think there's much point in fixing this. 2.7 users can use io.BytesIO, which is a fast type implemented in C. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10045