[issue10342] trace module cannot produce coverage reports for zipped modules

Changes by Alexander Belopolsky : -- versions: +Python 3.7 -Python 3.5 ___ Python tracker ___

[issue10342] trace module cannot produce coverage reports for zipped modules

Claudiu Popa added the comment: Hi, I left a couple of comments on Rietveld. -- nosy: +Claudiu.Popa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10342 ___

[issue10342] trace module cannot produce coverage reports for zipped modules

Alexander Belopolsky added the comment: I updated the patch for 3.5. [Brett] I don't quite see the point of the get_source call as it isn't returned or used. It *is* used: it is passed to _find_strings_stream: +source = loader.get_source(modulename) +strs =

[issue10342] trace module cannot produce coverage reports for zipped modules

Changes by Brett Cannon br...@python.org: -- nosy: -brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10342 ___ ___ Python-bugs-list

[issue10342] trace module cannot produce coverage reports for zipped modules

Changes by Eli Bendersky eli...@gmail.com: -- nosy: -eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10342 ___ ___ Python-bugs-list

[issue10342] trace module cannot produce coverage reports for zipped modules

Terry J. Reedy tjre...@udel.edu added the comment: What is the best way to pass around source code? - file-like objects, line iterators, readline-like function? Line iterator (list of lines) as returned by open().readlines. Memory should not be an issue. Read disk once and close. with

[issue10342] trace module cannot produce coverage reports for zipped modules

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Fri, Nov 12, 2010 at 12:54 PM, Terry J. Reedy rep...@bugs.python.org wrote: .. What is the best way to pass around source code? - file-like objects, line iterators, readline-like function? Line iterator (list of

[issue10342] trace module cannot produce coverage reports for zipped modules

Terry J. Reedy tjre...@udel.edu added the comment: Line iterator does not carry the information about source encoding which may be important for annotating the source code. I would pass around both encoding and lines, possibly as a tuple. A person heavily into OO might define a _Source class

[issue10342] trace module cannot produce coverage reports for zipped modules

Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- dependencies: +Deprecate trace module undocumented API ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10342 ___

[issue10342] trace module cannot produce coverage reports for zipped modules

STINNER Victor victor.stin...@haypocalc.com added the comment: I commited Alexander's fix for #10329: r86303. The trace module now uses the input Python script encoding, instead of the locale encoding. -- ___ Python tracker rep...@bugs.python.org

[issue10342] trace module cannot produce coverage reports for zipped modules

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: I am attaching a proof of concept patch. The trace code is in a dire need of restructuring to eliminate repeated reading of source files. -- keywords: +needs review, patch nosy: +eli.bendersky, terry.reedy stage:

[issue10342] trace module cannot produce coverage reports for zipped modules

Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10342 ___

[issue10342] trace module cannot produce coverage reports for zipped modules

STINNER Victor victor.stin...@haypocalc.com added the comment: +try: +with open(filename, 'rb') as fp: +encoding, _ = tokenize.detect_encoding(fp.readline) +except IOError: +encoding = None You should use 'utf-8'

[issue10342] trace module cannot produce coverage reports for zipped modules

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Sun, Nov 7, 2010 at 8:47 PM, STINNER Victor rep...@bugs.python.org wrote: STINNER Victor victor.stin...@haypocalc.com added the comment: +            try: +                with open(filename, 'rb') as fp: +        

[issue10342] trace module cannot produce coverage reports for zipped modules

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Sun, Nov 7, 2010 at 8:59 PM, Brett Cannon rep...@bugs.python.org wrote: .. I don't quite see the point of the get_source call as it isn't returned or used. It is passed to find_docstrings() to produce the strs

[issue10342] trace module cannot produce coverage reports for zipped modules

New submission from Alexander Belopolsky belopol...@users.sourceforge.net: Please run attached zip archive as a python script. Note that the problem is not specific for using __main__.py - any module that comes from a zip archive or loaded by a custom loader would show the same bug. $ unzip