Antoine Pitrou pit...@free.fr added the comment:
Works under Windows 7.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
R. David Murray rdmur...@bitdance.com added the comment:
committed in r87248.
--
resolution: - accepted
stage: unit test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Éric Araujo mer...@netwok.org added the comment:
Thanks for going through. Nice patch!
--
resolution: accepted - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
R. David Murray rdmur...@bitdance.com added the comment:
Updating patch because the assertTestRegexMatches name was updated.
--
Added file: http://bugs.python.org/file20029/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file19989/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file20029/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by R. David Murray rdmur...@bitdance.com:
Added file: http://bugs.python.org/file20030/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +cartman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
___
Python-bugs-list
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file20030/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by R. David Murray rdmur...@bitdance.com:
Added file: http://bugs.python.org/file20031/compileall_cli_revisited.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Ismail Donmez ism...@namtrac.org added the comment:
Patch works fine on Mac OSX 10.6.5
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
R. David Murray rdmur...@bitdance.com added the comment:
OK, here is what I hope is a comprehensive set of CLI tests, and fixes for the
bugs revealed thereby. Except for the new test added by Georg after the
original patch here was committed, all of the tests either pass using the old
R. David Murray rdmur...@bitdance.com added the comment:
I'm still working on this, making sure the remaining options that aren't
currently tested have tests and work.
--
assignee: eric.araujo - r.david.murray
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Thank you for stepping up. I plead guilty too for letting bugs slip. I’ll be
here for pre- or post-commit review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
r86611 has introduced a regression:
$ mkdir dir1 dir2
$ python3.1 -m compileall dir1 dir2
Listing dir1 ...
Listing dir2 ...
$ python3.2 -m compileall dir1 dir2
usage: compileall.py [-h] [-l] [-f] [-q] [-b] [-d
Éric Araujo mer...@netwok.org added the comment:
Whoops, a nargs='?' should have been '*'. Who wants to write the test?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
R. David Murray rdmur...@bitdance.com added the comment:
I'm working on it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
___
Éric Araujo mer...@netwok.org added the comment:
Let me be more helpful, just in case. This is the offending line:
parser.add_argument('compile_dest', metavar='FILE|DIR', nargs='?')
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Here's the test. The fix isn't as simple as making it nargs='*', though.
--
Added file: http://bugs.python.org/file19960/compileall_multidir_test.diff
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Here is a fix. This is not finished, though, because I see that I did not do
an adequate review of the original patch. There are still bugs in the -d and
-i handling that need both tests and fixes.
--
Added file:
Changes by Éric Araujo mer...@netwok.org:
--
priority: normal - high
stage: needs patch - unit test needed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Éric Araujo mer...@netwok.org added the comment:
Thanks for the patch Stefan. I can’t test on Windows now; can you/have you?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Stefan Krah stefan-use...@bytereef.org added the comment:
Yes, the patch is tested on Windows. Feel free to commit it if you have
a chance.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Michele Orrù maker...@gmail.com added the comment:
Thank you Stefan, these days I was a little busy and I hadn't the time to
review my patch. I really appreciate you help.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Revision 86758, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
___
Stefan Krah stefan-use...@bytereef.org added the comment:
On Windows, test_compileall fails due to #10197. The patch uses
subprocess.check_output() instead. Technically, now byte strings
are compared instead of strings, but that should not matter for
the outcome.
--
nosy: +skrah
Added
Éric Araujo mer...@netwok.org added the comment:
Patch for test_quiet looks good, thanks.
Do you want to write test_noargs?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Éric Araujo mer...@netwok.org added the comment:
test_quiet hopefully fixed in r86668.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Éric Araujo mer...@netwok.org added the comment:
Not fixed:
http://www.python.org/dev/buildbot/all/builders/AMD64%20Windows%20Server%202008%203.x/builds/54/steps/test/logs/stdio
--
___
Python tracker rep...@bugs.python.org
Michele Orrù maker...@gmail.com added the comment:
I'm still working on this task; the attachment shows how I'm solving the bug.
The patch is NOT yet completed, there are some problems with the unittests.
Hoping that Eric will give me a help soon.
--
keywords: +patch
nosy:
Changes by Michele Orrù maker...@gmail.com:
Removed file: http://bugs.python.org/file19679/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Michele Orrù maker...@gmail.com added the comment:
The new attached patch passes the unittest.
--
Added file: http://bugs.python.org/file19682/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Changes by Michele Orrù maker...@gmail.com:
Removed file: http://bugs.python.org/file19682/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by Michele Orrù maker...@gmail.com:
Added file: http://bugs.python.org/file19684/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Daniel Albeseder ko...@gmx.at added the comment:
I did a very simple addition to the CommandLineTest, to check that -h really
returns the usage:. I am not sure, if this is useful since, it rather tests
argparse now with the proposed patch...
--
nosy: +Kotan
Added file:
Michele Orrù maker...@gmail.com added the comment:
Eric, the unittests in Lib/test/test_compileall.py seems quite consistent to
me, so for now I won't add anything.
About adding a method for testing the '-h' argument, now that Lib/compileall.py
uses argparse, it sounds trivial.
EDIT: Kotan,
Daniel Albeseder ko...@gmx.at added the comment:
I wanted to test, that no unwanted output is given before the usage. I just
added the test before I started to try to fix this bug, as I recognized Michele
already was already fixing the bug. This was just my test-driven approach,
where the
R. David Murray rdmur...@bitdance.com added the comment:
On the other hand, the test case in test_compileall says test some aspects of
compileall's CLI. Since the patch completely changes the logic of CLI
parsing, having tests that cover as much as practical of the CLI would greatly
increase
Changes by Michele Orrù maker...@gmail.com:
Removed file: http://bugs.python.org/file19684/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Michele Orrù maker...@gmail.com added the comment:
Unittest added; should be enough.
--
Added file: http://bugs.python.org/file19702/issue10453.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Changes by Michele Orrù maker...@gmail.com:
Added file: http://bugs.python.org/file19703/issue10453_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by Michele Orrù maker...@gmail.com:
Added file: http://bugs.python.org/file19708/issue10453_final.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Bruno Gola brunog...@gmail.com added the comment:
applied the patch on an ubuntu 10.04 64bits, py3k (trunk)
test_force fails as following:
==
FAIL: test_force (__main__.CommandLineTests)
Michele Orrù maker...@gmail.com added the comment:
Yes, I was discussing about that on IRC. That's a matter of platform -on mine
for example works-. He gave me a hand in solving this failure; now -I think-
he's gonna apply that.
--
___
Python
Michele Orrù maker...@gmail.com added the comment:
*discussing that on IRC with R. David Murray
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Changes by R. David Murray rdmur...@bitdance.com:
--
assignee: eric.araujo - r.david.murray
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
R. David Murray rdmur...@bitdance.com added the comment:
Patch committed with minor formatting changes and one fixed test (test_force)
in r86611. Thanks, Michele!
--
resolution: - accepted
stage: commit review - committed/rejected
status: open - closed
Éric Araujo mer...@netwok.org added the comment:
Invocation without arguments does not work. I have a fix, I’ll add a test and
commit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Michele Orrù maker...@gmail.com added the comment:
Sorry.
--
Added file: http://bugs.python.org/file19717/issue10453_noargs.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
Éric Araujo mer...@netwok.org added the comment:
One buildbot also shows a bug in quiet or test_quiet:
Traceback (most recent call last):
File
D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_compileall.py,
line 227, in test_quiet
self.assertTrue(len(noise)
Éric Araujo mer...@netwok.org added the comment:
I hadn’t seen your patch Michele. I find mine more readable:
http://pastealacon.com/26257 . That was just the easy part though; do you want
to write a test?
--
___
Python tracker
Michele Orrù maker...@gmail.com added the comment:
Yeah, maybe your is more readable.
I suppose that failure was due to some missing arguments when calling
compileall (line 225). The attached patch should fix this issue, but currently
I have no Windows machines where to test.
--
New submission from Éric Araujo mer...@netwok.org:
It would be useful if “python -m compileall -h” was possible. Right now it
fails with “option -h not recognized” and prints its help text, which is a bit
silly :)
Bug week-end candidate!
--
assignee: eric.araujo
components: Library
Éric Araujo mer...@netwok.org added the comment:
One neat way to solve this is to make compileall use argparse.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
___
54 matches
Mail list logo
