[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Éric Araujo added the comment: Good catch. I’m tired, I should have noticed that :) -- resolution: -> duplicate stage: unit test needed -> committed/rejected status: open -> closed superseder: -> gzip module calls getattr incorrectly ___ Python tr

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Charles Harris added the comment: Looks like this was fixed by r86555 and a test added. I think you can close the ticket. -- ___ Python tracker ___

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Éric Araujo added the comment: The best way is to learn by imitation. If you prefer to read, there is some guidance on http://www.python.org/dev/workflow/ and http://www.python.org/dev/faq/#how-to-test-a-patch . Concretely, you need to open a file, wrap it in a _PaddedFile and check that at

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Changes by Charles Harris : Removed file: http://bugs.python.org/file19921/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Charles Harris added the comment: Hi Eric, On Thu, Dec 2, 2010 at 8:12 PM, Éric Araujo wrote: Where are the guidelines for writing python tests? Chuck -- Added file: http://bugs.python.org/file19921/unnamed ___ Python tracker

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

Éric Araujo added the comment: Thanks for the report and patch. Can you add a test, to prevent a regression? -- nosy: +eric.araujo stage: -> unit test needed type: -> behavior versions: +Python 2.7, Python 3.1 ___ Python tracker

[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order

New submission from Charles Harris : The attached patch fixes the problem. -- components: Library (Lib) files: gzip.patch keywords: patch messages: 123171 nosy: charris44 priority: normal severity: normal status: open title: gzip._PaddedFile calls getattr with arguments in reversed order