[issue1067] test_smtplib failures (caused by asyncore)

Changes by Thomas Wouters: -- assignee: twouters - nobody nosy: +nobody __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list mailing list

[issue1067] test_smtplib failures (caused by asyncore)

Changes by Georg Brandl: -- resolution: - wont fix status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list mailing list

[issue1067] test_smtplib failures (caused by asyncore)

Guido van Rossum added the comment: OK, closing. I see plenty of mention of these two modules in the lists, so maybe someone else wants to take a whack at it. I'll post to python-dev. -- keywords: +py3k nosy: -nobody priority: high - normal __ Tracker

[issue1067] test_smtplib failures (caused by asyncore)

Thomas Wouters added the comment: I thought I already had, in my reply to Martin and the original comment: he's right, but I don't care about asyncore or asynchat. I merely perpetuated the fix that was already in place. The real 'fix' is to teach both modules about unicode; have them handle in

[issue1067] test_smtplib failures (caused by asyncore)

Changes by Skip Montanaro: -- nosy: +skip.montanaro __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1067] test_smtplib failures (caused by asyncore)

Guido van Rossum added the comment: I have no idea. I'm no asynchat expert. Let Thomas look into this once he's back from vacation. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __

[issue1067] test_smtplib failures (caused by asyncore)

Christian Heimes added the comment: Guido, what needs to be done here? -- nosy: +tiran __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list

[issue1067] test_smtplib failures (caused by asyncore)

Changes by Sean Reifschneider: -- priority: - high __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1067] test_smtplib failures (caused by asyncore)

Martin v. Löwis added the comment: I think it's incorrect: asynchat operates on bytes, not strings, as it directly interfaces with the socket, and no encoding is specified for the protocol. So, IMO, callers should be expected to pass bytes only, as terminator and as data. -- nosy:

[issue1067] test_smtplib failures (caused by asyncore)

Thomas Wouters added the comment: I agree, but the change wasn't actually mine. I merely adjusted the already-implemented strategy to the fact that bytes(str) no longer works. I think the original change was Jeremy H's. __ Tracker [EMAIL PROTECTED]

[issue1067] test_smtplib failures (caused by asyncore)

Guido van Rossum added the comment: (Reopening given recent discussion.) -- resolution: fixed - status: closed - open __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __

[issue1067] test_smtplib failures (caused by asyncore)

New submission from Thomas Wouters: test_smtplib fails because asyncore uses bytes(data) where data may be bytes or str or some undefined type. The attached patch fixes it to the extend that test_smtplib works again (plus a small fix in test_smtplib itself.) I'm not sure if this is the right

[issue1067] test_smtplib failures (caused by asyncore)

Changes by Guido van Rossum: -- versions: +Python 3.0 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue1067] test_smtplib failures (caused by asyncore)

Guido van Rossum added the comment: Great, please check it in. This is close to what I had sitting somewhere, but I hadn't finished it. -- assignee: gvanrossum - twouters resolution: - accepted __ Tracker [EMAIL PROTECTED]

[issue1067] test_smtplib failures (caused by asyncore)

Thomas Wouters added the comment: Checked in. -- resolution: accepted - fixed status: open - closed __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1067 __ ___