Ezio Melotti added the comment:
Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I committed this to 2.7 in 9336b470544b but screwed up the copy and paste of
the issue number so it didn't auto post.
--
nosy: +r.david.murray
resolution: - fixed
stage: commit review - resolved
status: open - closed
Ezio Melotti added the comment:
Here is an updated patch that is the same as my first patch but also includes
the documentation provided by Berker (thanks!).
--
Added file: http://bugs.python.org/file32808/issue10712-2.diff
___
Python tracker
Serhiy Storchaka added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset cc0fc4e9b494 by Ezio Melotti in branch 'default':
#10712: 2to3 has a new asserts fixer that replaces deprecated names of
unittest methods.
http://hg.python.org/cpython/rev/cc0fc4e9b494
--
nosy: +python-dev
Ezio Melotti added the comment:
Committed in 3.4, I'll backport it to 2.7/3.3 later.
Thanks for the review!
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
Changes by Serhiy Storchaka storch...@gmail.com:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
There are reasons why Ezio did not include assert*Regexp*-assert*Regex* in his
patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Berker Peksag added the comment:
I've converted Ezio's patch to Mercurial format, updated the lib2to3
documentation and added tests for assertRegexpMatches and assertRaisesRegexp
aliases[1].
[1] http://docs.python.org/3.4/library/unittest.html#deprecated-aliases
--
components: +2to3
Ezio Melotti added the comment:
Can this still go on 2.7/3.2/3.3?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list
Gregory P. Smith added the comment:
Yes! 2to3 features are allowed in stable releases.
On Mar 2, 2013 5:17 AM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti added the comment:
Can this still go on 2.7/3.2/3.3?
--
___
Python tracker
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Bradley Froehle added the comment:
Bikeshedding, but the fixer name of 'asserts' bugs me. I'd suggest 'unittest'
or 'unittest_asserts'.
--
nosy: +bfroehle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
Benjamin Peterson added the comment:
Looks fine, though. Make sure to add docs to library/2to3.rst.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +gregory.p.smith
versions: +Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Ezio Melotti added the comment:
Ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
Python-bugs-list mailing list
Unsubscribe:
Ezio Melotti ezio.melo...@gmail.com added the comment:
Should this still go to the sandbox? and if so, what is the right sandbox?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
___
___
New submission from Ezio Melotti ezio.melo...@gmail.com:
The attached patch against 2.7 adds a new fixer to 2to3 that replaces
deprecated unittest method names with the correct ones.
There are a few issues:
1) only the safe renamings are included; the
assert[SameElements|ItemsEqual|CountEqual]
Martin v. Löwis mar...@v.loewis.de added the comment:
2to3 patches should currently be made against and checked into the sandbox.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10712
22 matches
Mail list logo
