[issue10761] tarfile.extractall fails to overwrite symlinks

Change by Chris Albright : -- components: +Unicode nosy: +ezio.melotti, vstinner type: behavior -> performance versions: +Python 3.8 ___ Python tracker

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: It turns out that my fix was at least one byte short of complete. If the target pathname is a broken symlink, os.path.exists() returns False, and the OSError is raised. I should have used os.path.lexists(). Also, I believe the same

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: here is a diff of a better fix based on the previous patch: Index: tarfile.py === --- tarfile.py (revision 49758) +++ tarfile.py (working copy) @@ -2239,12 +2239,14 @@

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: tests that verify the bug/fix: def test_extractall_broken_symlinks(self): # Test if extractall works properly when tarfile contains symlinks tempdir = os.path.join(TEMPDIR, testsymlinks) temparchive =

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: oops... I left some of my local edits in those tests. be sure to fix the TEMPDIR use if you add these into the tarfile tests. -- ___ Python tracker rep...@bugs.python.org

[issue10761] tarfile.extractall fails to overwrite symlinks

Antoine Pitrou pit...@free.fr added the comment: Senthil, Windows buildbots on 3.1, 3.2 and 3.x show test failures. See e.g. http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.1/builds/1780/steps/test/logs/stdio -- assignee: lars.gustaebel - orsenthil nosy: +pitrou status:

[issue10761] tarfile.extractall fails to overwrite symlinks

Roundup Robot devnull@devnull added the comment: New changeset 2665a28643b8 by Senthil Kumaran in branch 'default': Wrap the correct test with the skip decorator for the issue10761. http://hg.python.org/cpython/rev/2665a28643b8 -- ___ Python tracker

[issue10761] tarfile.extractall fails to overwrite symlinks

Senthil Kumaran sent...@uthcode.com added the comment: I had wrapped skipUnless decorator for the wrong test (test_extractall instead of test_extractall_symlinks) in the 3.x code. Corrected it and waiting for next bb reports. Thank you. -- ___

[issue10761] tarfile.extractall fails to overwrite symlinks

Senthil Kumaran sent...@uthcode.com added the comment: buildbots are green again. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10761 ___

[issue10761] tarfile.extractall fails to overwrite symlinks

Roundup Robot devnull@devnull added the comment: New changeset 0c8bc3a0130a by Senthil Kumaran in branch '2.7': Fix closes issue10761: tarfile.extractall failure when symlinked files are present. http://hg.python.org/cpython/rev/0c8bc3a0130a -- nosy: +python-dev resolution: - fixed

[issue10761] tarfile.extractall fails to overwrite symlinks

Senthil Kumaran sent...@uthcode.com added the comment: I had tried/tested against 3.x branch and did not find the problem. Later realized that it was only again 2.7. Pushed in the changes and the tests. I shall the tests only in 3.x codeline. --

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: It happens on RedHat and CentOS 5, but I suspect it would happen on any Unix variant. Here's a test that exacerbates the issue: # # test_tarfile.py # # Description: # tests for python tarfile module # # $Id$ # import os import

[issue10761] tarfile.extractall fails to overwrite symlinks

Scott Leerssen sleers...@gmail.com added the comment: I just hit the same issue. This seems to work: Modified:Lib/tarfile.py === ---Lib/tarfile.py 2011-04-26 20:36:33 UTC (rev 49502) +++Lib/tarfile.py 2011-04-26

[issue10761] tarfile.extractall fails to overwrite symlinks

Senthil Kumaran sent...@uthcode.com added the comment: Scott- which platform did you observe this? I can't reproduce this on the 2.7 code on Linux. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10761

[issue10761] tarfile.extractall fails to overwrite symlinks

Changes by Santoso Wijaya santoso.wij...@gmail.com: -- nosy: +santa4nt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10761 ___ ___

[issue10761] tarfile.extractall fails to overwrite symlinks

Changes by Lars Gustäbel l...@gustaebel.de: -- assignee: - lars.gustaebel nosy: +lars.gustaebel ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10761 ___

[issue10761] tarfile.extractall fails to overwrite symlinks

New submission from Sridhar Ratnakumar sridh...@activestate.com: tarfile.extractall overwrites normal files and directories, yet it fails to overwrite symlinks: [..] tf.extractall() File /opt/ActivePython-2.7/lib/python2.7/tarfile.py, line 2046, in extractall self.extract(tarinfo,