[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

Ned Deily added the comment: I have no special insight into this one but, since there seems to be general agreement here that this makes things better for those using C++ on OS X and FreeBSD, I guess it's time to try it. Pushed for release in 2.7.13, 3.5.3, and 3.6.0. Thanks for the version

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

Roundup Robot added the comment: New changeset 2f857ac9c7af by Ned Deily in branch '3.5': Issue #10910: Avoid C++ compilation errors on FreeBSD and OS X. https://hg.python.org/cpython/rev/2f857ac9c7af New changeset 27a99a722828 by Ned Deily in branch '3.5': Issue #10910: Update FreedBSD version

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

koobs added the comment: @Brett / Ned I'm happy to carry the proposed patch in the FreeBSD ports/packages until the next releases if that helps your confidence levels. -- versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

Brett Cannon added the comment: What do you think, Ned? -- assignee: ronaldoussoren -> ned.deily nosy: +benjamin.peterson, brett.cannon, georg.brandl, larry, ned.deily priority: normal -> release blocker ___ Python tracker

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

Changes by Mihai Capotă : -- nosy: +mihaic ___ Python tracker ___ ___ Python-bugs-list

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

Dimitry Andric added the comment: I am a FreeBSD committer, and I recently ran into this issue too, since I am working on an update of libc++ in the FreeBSD base system. As part of this work, we attempt to recompile all ports with the proposed change (see [1]). During such a recompile, we

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Changes by koobs koobs.free...@gmail.com: -- nosy: +koobs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10910 ___ ___ Python-bugs-list mailing

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Ronald Oussoren added the comment: The bytes_methods.h issue is not present in the default branch, but is still present in the 2.7 branch. I'm not sure why those defines are there, I'm adding Gregory P. Smith to the nosy list because he added the defines and might remember why they were added

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Gregory P. Smith added the comment: I was merely refactoring for PEP3137, the original version of all that code prior to 2.7 was in Objects/stringobject.c and long predates me. -- ___ Python tracker rep...@bugs.python.org

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Ronald Oussoren added the comment: I've some more digging to do then, although I expect that nobody knows anymore why the #define's are there. It should be safe to remove them by now, and they are not present in the default branch. -- ___ Python

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Barry Alan Scott barry-sc...@users.sourceforge.net added the comment: I'm happy to review patches or create them for you. I see a related set of errors on Mac OS X that are down to issues in bytes_methods.py that mirror the pyport.h issues. In C++ isspace and friends are functions not macros.

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: Per Chen Huang's comment, I retested my test case code using several versions of boost and Python 2.7: boost 1.45: build fails, errors as reported. boost 1.46: success. boost 1.47: success. I've attached a revised test case that automatically

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Ronald Oussoren ronaldousso...@mac.com added the comment: The only real fix I found is to introduce Py_ prefixed versions of all definitions in ctypes.h that are used in Python (that is Py_isalnum) and use that throughout the python source tree. That's a pretty invasive patch though and would

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Bert JW Regeer ber...@regeer.org added the comment: In my first comment on this bug post I posted what project has issues with this, Botan with Boost.Python on FreeBSD and Mac OS X. If required I will post how to reproduce this error using that project. If you would prefer a simplified test

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Chen Huang chi...@gmail.com added the comment: I am experiencing the same issue. Googled for a bit but couldn't find much with the error, then changed the search context, come across to this thread. In file included from /opt/local/include/boost/date_time/gregorian/parsers.hpp:13,

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Chen Huang chi...@gmail.com added the comment: if I put #include cctype before boost/date_time, it solves my problem. And by the way, i can't seem to get to the point where boost/week_ptr.hpp causes the error. I tried to compile Nasos's upload test-boost-python. That codes works on my

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Chen Huang chi...@gmail.com added the comment: Nevermind, putting #include cctype doesn't help. I have to put python.h on top to get away this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10910

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Ronald Oussoren ronaldousso...@mac.com added the comment: Waiting for a new version of boost probably won't help: this is an incompatibility between a redefinition of ctypes macros in pyport.h and definitions in the C++ header locale. I barely use C++ at this time and don't know how to tweak

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: Ronald, thanks again.  I stripped out as much as I could from the original code and generated the attached project. In doing so, I narrowed the problem down to boost/weak_ptr.hpp. The sample project consists of: test-boost-python/Makefile

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: With attachment-- -- Added file: http://bugs.python.org/file22703/test-boost-python.tar.gz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10910

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: Ronald, Thanks much for your help and insight. I tried the patch but unfortunately it didn't work for me-- this might be because I have Python extensions written in C++. Any other suggestions? Should I wait for the next version of

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Changes by Ronald Oussoren ronaldousso...@mac.com: Removed file: http://bugs.python.org/file21728/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10910 ___

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Ronald Oussoren ronaldousso...@mac.com added the comment: The problem is that pyport tries to replace the ctypes definion of the isascii(ch) and related functions by a replacement that works better with UTF-8 on FreeBSD and OSX. That replacement is incompatible with the localfwd.h header. The

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: Meador et al, Thanks for your attention to this issue. Just to clarify, I can eliminate the compile errors by prepending #include Python.h to any source file with #includeboost/python.hpp Also, my code compiles in Linux, with and without

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Meador Inge mead...@gmail.com added the comment: This doesn't look like it has anything to to with the 'ctypes' library component (http://docs.python.org/library/ctypes). So I am removing 'ctypes' from the 'Components' selection. Please correct me if I am wrong ... -- components:

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Changes by Meador Inge mead...@gmail.com: -- components: +Macintosh ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10910 ___ ___ Python-bugs-list

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

Nasos Dousis ndou...@gmail.com added the comment: I'm upgrading from Python 2.6.5 to 2.7.1, and I'm getting the error below when compiling my code using Boost 1.45 and gcc 4.2.1 in OSX 10.6.6. The following thread describes similar symptoms related to the ordering of header files and macro

[issue10910] pyport.h FreeBSD/Mac OS X fix causes errors in C++ compilation

New submission from Bert JW Regeer ber...@regeer.org: I was recently attempting to get Botan (http://botan.randombit.net) working with Python 2.6.6 on FreeBSD when it failed to compile, I filled a bug with Botan (http://bugs.randombit.net/show_bug.cgi?id=135) and first thought it was a