[issue10932] distutils.core.setup - data_files misbehaviour ?

Steve Dower added the comment: Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If

[issue10932] distutils.core.setup - data_files misbehaviour ?

STINNER Victor added the comment: This issue is 8 years old has 4 patches: it's far from being "newcomer friendly", I remove the "Easy" label. -- keywords: -easy nosy: +vstinner ___ Python tracker

[issue10932] distutils.core.setup - data_files misbehaviour ?

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- components: -Distutils2 nosy: +dstufft versions: +Python 3.4, Python 3.5 -3rd party, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932

[issue10932] distutils.core.setup - data_files misbehaviour ?

Prashant Kumar contactprashan...@gmail.com added the comment: Certainly, a test is needed to check that ('config', ['cfg/data.cfg']) would create a file in config/data.cfg and not config/cfg/data.cfg. Though, I've added a patch 'test_command_sdist.diff' for the changes made in 'patch.diff'.

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: Patch looks good. Detail: I’d find a call to basename more readable than i.split('/')[-1:][0]. Does this need a test in test_manifest too? A doc update? -- ___ Python tracker rep...@bugs.python.org

[issue10932] distutils.core.setup - data_files misbehaviour ?

Changes by Prashant Kumar contactprashan...@gmail.com: Added file: http://bugs.python.org/file21720/test_command_sdist.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932 ___

[issue10932] distutils.core.setup - data_files misbehaviour ?

Prashant Kumar contactprashan...@gmail.com added the comment: If I'm not wrong, the contents in the manifest file should be: 'data.cfg' (not cfg/data.cgg) I've added a patch which fixes the above issue. -- Added file: http://bugs.python.org/file21721/fix-manifest.diff

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: Can you remove all obsolete repositories and patches from this report and upload one complete patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932

[issue10932] distutils.core.setup - data_files misbehaviour ?

Changes by Prashant Kumar contactprashan...@gmail.com: Removed file: http://bugs.python.org/file21720/test_command_sdist.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932 ___

[issue10932] distutils.core.setup - data_files misbehaviour ?

Changes by Prashant Kumar contactprashan...@gmail.com: Removed file: http://bugs.python.org/file21721/fix-manifest.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932 ___

[issue10932] distutils.core.setup - data_files misbehaviour ?

Prashant Kumar contactprashan...@gmail.com added the comment: Sure, patch.diff is a complete one. -- Added file: http://bugs.python.org/file21727/patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: The “remote hg repo” is supposed to be the URI of a clone (not of a changeset) of cpython (not distutils2), so the repos you added don’t work. Can you remove them and add a patch file instead? Thanks. The first changeset looks good; I don’t

[issue10932] distutils.core.setup - data_files misbehaviour ?

Prashant Kumar contactprashan...@gmail.com added the comment: I made changes in manifest.py which can be viewed here: https://bitbucket.org/pkumar/distutils2_bugs/changeset/111c1253ea7a I'm not sure if I should modify test_command_sdist.py for the failing tests of manifest contents(since it

[issue10932] distutils.core.setup - data_files misbehaviour ?

Changes by Éric Araujo mer...@netwok.org: -- hgrepos: +19 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932 ___ ___ Python-bugs-list mailing

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: Looks great, thanks. You haven’t addressed this part of my previous message: “I think the fix may be in the wrong place: You fixed sdist but not bdists. I think the root of the problem is in the manifest (distutils2) / filelist (distutils1)

[issue10932] distutils.core.setup - data_files misbehaviour ?

Prashant Kumar contactprashan...@gmail.com added the comment: I have added a test for the modification in msg127191. Though, inside zip-file we get files without its parent dir, nothing changes in manifest file(should it change?). Please have a look at the changeset

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: Thanks for the patch. Would you like to complete it? It lacks tests, and I think the fix may be in the wrong place: You fixed sdist but not bdists. I think the root of the problem is in the manifest (distutils2) / filelist (distutils1)

[issue10932] distutils.core.setup - data_files misbehaviour ?

Thorsten Simons t...@snomis.de added the comment: Hi Éric, All, thank you for the directions you gave me! It's all about a call of os.path.basename() missing in sdist.py. Pls. see attached diff. Regards, Thorsten -- keywords: +patch Added file:

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: Thanks for the report. “No directory information from files is used to determine the final location of the installed file; only the name of the file is used” I understand this line to mean that only the basename of the file will be used in the

[issue10932] distutils.core.setup - data_files misbehaviour ?

Fred L. Drake, Jr. fdr...@acm.org added the comment: On Wed, Jan 19, 2011 at 12:42 PM, Éric Araujo rep...@bugs.python.org wrote: I understand this line to mean that only the basename of the file will be used in the target directory, IOW that ('config', ['cfg/data.cfg']) will create a file in

[issue10932] distutils.core.setup - data_files misbehaviour ?

Éric Araujo mer...@netwok.org added the comment: See also #9261. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10932 ___ ___ Python-bugs-list