[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Berker Peksag added the comment: Thank you, Anthony. I added a test case and committed your patch to 3.6 and master branches. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Berker Peksag added the comment: New changeset 4b3042900e7e8dc120408bab86642c09c9d25a5a by Berker Peksag in branch '3.6': bpo-1102: View.Fetch() now returns None when it's exhausted (GH-4459) https://github.com/python/cpython/commit/4b3042900e7e8dc120408bab86642c09c9d25a5a -- __

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Berker Peksag added the comment: > Will it be added to 3.6 also? Yes, I've created a backport PR: PR 4520 > And when it will be available in the windows installations you release? The dates for 3.6.4 release is listed at https://www.python.org/dev/peps/pep-0494/#id4 --

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

uday kiran added the comment: Will it be added to 3.6 also? And when it will be available in the windows installations you release? -- ___ Python tracker ___ ___

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Change by Berker Peksag : -- pull_requests: +4457 stage: backport needed -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Berker Peksag added the comment: New changeset bdb8315c21825487b54852ff0511fb4881ea2181 by Berker Peksag in branch 'master': bpo-1102: View.Fetch() now returns None when it's exhausted (GH-4459) https://github.com/python/cpython/commit/bdb8315c21825487b54852ff0511fb4881ea2181 -- ___

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Change by Berker Peksag : -- stage: patch review -> backport needed versions: -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Berker Peksag added the comment: I've opened PR 4459 to fix this. Here's a simple reproducer I adapted from the script uploaded by uday kiran in issue 32064. -- nosy: +berker.peksag, uday kiran versions: +Python 3.6, Python 3.7 -Python 3.4, Python 3.5 _

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Change by Berker Peksag : -- keywords: +patch pull_requests: +4396 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Zachary Ware added the comment: Sorry, I have no familiarity with msilib, _msi, or the internals of MSIs in general. The patch looks reasonably harmless to me, but I don't have the confidence to take responsibility for it. -- ___ Python tracker

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Anthony Tuininga added the comment: I note that this patch has still not been accepted! Please let me know what needs to be done. I just tried against Python 3.4 and the patch works as expected -- other than the starting line number is now 715. I have signed the contributor agreement if that i

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Terry J. Reedy : -- nosy: -terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Mark Lawrence added the comment: Can someone review the latest patch please as it's only five additional lines of C code. -- nosy: +BreamoreBoy, steve.dower, zach.ware versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Anthony Tuininga added the comment: All, I have trimmed this patch down to the bare minimum required to solve this problem. Please review this as I would dearly love to have this committed. The error received without this patch is MSIError: unknown error 103 This occurs when there are no mor

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Martin v. Löwis added the comment: I lost track what problem precisely this patch solves, so it's hard to tell whether it's a bug fix or not. -- ___ Python tracker ___ _

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Terry J. Reedy added the comment: Martin, would this go in a bugfix release or is it a new feature for 3.3 only? -- nosy: +terry.reedy versions: +Python 3.3 -Python 3.1 ___ Python tracker __

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Tim Golden : -- components: +Windows nosy: +tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Mark Lawrence : -- stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6 ___ Python tracker ___ _

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- priority: normal -> high ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-l

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Anthony Tuininga <[EMAIL PROTECTED]> added the comment: With apologies for the delay, I have modified the patch to remove the stuff that has been added already. Some of the other changes are to make use of new C API functionality but they can be ignored, if desired. The changes that are relevant

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Anthony Tuininga <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file8385/_msi.patch.txt ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Yes, please do provide an updated patch. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Py

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Anthony Tuininga <[EMAIL PROTECTED]> added the comment: This patch appears to be mostly duplicated by patch 2125 which has been accepted. Would it be helpful if I separated out the parts that have now been accepted? ___ Python tracker <[EMAIL PROTECTED]>

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Martin v. Löwis: -- assignee: -> loewis nosy: +loewis __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscri

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Anthony Tuininga : -- type: behavior -> __ Tracker <[EMAIL PROTECTED]> __ _

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

New submission from Anthony Tuininga : Attached is a patch that adds the requested support. This is in relation to the thread at http://www.gossamer-threads.com/lists/python/python/584264 In addition to the two methods I a

[issue1102] Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

Changes by Anthony Tuininga : -- components: Library (Lib) severity: normal status: open title: Add support for _msi.Record.GetString() and _msi.Record.GetInteger() type: behavior versions: Python 2.5 _