[issue11410] Use GCC visibility attrs in PyAPI_*

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue11410] Use GCC visibility attrs in PyAPI_*

Vinay Sajip added the comment: New changeset 0b60f64e4343913b4931dc27379d9808e5b78fe1 by Vinay Sajip in branch 'master': bpo-11410: Standardize and use symbol visibility attributes across POSIX and Windows. (GH-16347)

[issue11410] Use GCC visibility attrs in PyAPI_*

Change by Vinay Sajip : -- versions: +Python 3.9 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11410] Use GCC visibility attrs in PyAPI_*

Change by Vinay Sajip : -- pull_requests: +15924 pull_request: https://github.com/python/cpython/pull/16347 ___ Python tracker ___

[issue11410] Use GCC visibility attrs in PyAPI_*

Vinay Sajip added the comment: Reopening, as a new patch is available. -- nosy: +vinay.sajip resolution: out of date -> stage: resolved -> patch review status: closed -> open ___ Python tracker

[issue11410] Use GCC visibility attrs in PyAPI_*

Nathaniel Smith added the comment: Was this actually fixed, or did everyone just get tired and give up on the original patch? -- nosy: +njs ___ Python tracker

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Thomas Wouters : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

STINNER Victor added the comment: See also the issue #19569: Use __attribute__((deprecated)) to warn usage of deprecated functions and macros. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410

[issue11410] Use GCC visibility attrs in PyAPI_*

STINNER Victor added the comment: I extracted the changes on the PyMODINIT_FUNC macro and I opened the issue #23685. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

STINNER Victor added the comment: +#if defined(__GNUC__) __GNUC__ = 4 +# define HAVE_ATTRIBUTE_VISIBILITY +#endif Clang now also supports __attribute__((visibility(...))). I don't know since which version. I'm not sure because I don't see it:

[issue11410] Use GCC visibility attrs in PyAPI_*

STINNER Victor added the comment: The getargs.c change *is* necessary, although it doesn't have to be that exact change. Why not moving these declarations to Include/modsupport.h where _PyArg_Parse...() are already used? -- ___ Python tracker

[issue11410] Use GCC visibility attrs in PyAPI_*

STINNER Victor added the comment: In the issue #23685, I proposed a patch to add _PyBUILTIN_MODINIT_FUNC for builtin modules. It makes possible to hide PyInit_xxx symbols of builtin symbols with __attribute__((visibility(hidden))). It also avoids to export these privates symbols on Windows in

[issue11410] Use GCC visibility attrs in PyAPI_*

Samuel Bronson added the comment: Um ... any progress on reviewing this? -- nosy: +SamB ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___ ___ Python-bugs-list

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Tom Tromey tro...@redhat.com: -- nosy: +tromey ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___ ___ Python-bugs-list mailing

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___ ___ Python-bugs-list

[issue11410] Use GCC visibility attrs in PyAPI_*

Antoine Pitrou pit...@free.fr added the comment: Why the cygwin changes? Are they related? Also, is the change in Python/getargs.c necessary? -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Antoine Pitrou pit...@free.fr: -- stage: - patch review type: - feature request versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

Thomas Wouters tho...@python.org added the comment: The cygwin changes are no-ops, just refactoring the needlessly nested if statement for clarity. I can revert them. The getargs.c change *is* necessary, although it doesn't have to be that exact change. The problem is that the functions in

[issue11410] Use GCC visibility attrs in PyAPI_*

Antoine Pitrou pit...@free.fr added the comment: The cygwin changes are no-ops, just refactoring the needlessly nested if statement for clarity. I can revert them. Perhaps you can commit them separately? I don't think they need review. As for the getargs.c change, perhaps Martin has an

[issue11410] Use GCC visibility attrs in PyAPI_*

Martin v. Löwis mar...@v.loewis.de added the comment: Exporting the SizeT functions on all systems is fine. It's not true that they aren't declared: they are declared in modsupport.h if PY_SSIZE_T_CLEAN is defined. Else they are not declared. The patch looks fine to. I agree that mere cleanup

[issue11410] Use GCC visibility attrs in PyAPI_*

Thomas Wouters tho...@python.org added the comment: Windows/Cygwin parts of the patch reverted and new patch uploaded. My point about the _Py*_SizeT functions is that they're only declared when you define PY_SSIZE_T_CLEAN, and I don't know if we want to change that (I don't think it makes

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Thomas Wouters tho...@python.org: Removed file: http://bugs.python.org/file21014/gcc-visibility.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

New submission from Thomas Wouters tho...@python.org: This patch adds support for the GCC visibility attributes to the PyAPI_* macros (currently only used for Windows.) GCC's default visibility is 'public', but can be changed to 'hidden' with the '-fvisibility=hidden' argument; see

[issue11410] Use GCC visibility attrs in PyAPI_*

Thomas Wouters tho...@python.org added the comment: This patch adds support for the GCC visibility attributes to the PyAPI_* macros (currently only used for Windows.) GCC's default visibility is 'public', but can be changed to 'hidden' with the '-fvisibility=hidden' argument; see

[issue11410] Use GCC visibility attrs in PyAPI_*

Changes by Thomas Wouters tho...@python.org: -- Removed message: http://bugs.python.org/msg130144 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___

[issue11410] Use GCC visibility attrs in PyAPI_*

Thomas Wouters tho...@python.org added the comment: Uploaded to Rietveld, too: http://codereview.appspot.com/4260052/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11410 ___