Nick Coghlan ncogh...@gmail.com added the comment:
I'm currently planning to postpone fixing this until 3.4. However, if someone
else wants to pick it up for 3.3, go ahead.
--
assignee: ncoghlan -
versions: +Python 3.4 -Python 3.3
___
Python
Nick Coghlan ncogh...@gmail.com added the comment:
And, back on topic...
I've been pondering this problem and the approach I adopted in my branch and
decided it's the *wrong* way to go about it. It takes an already complex piece
of code and makes it even more complicated.
A completely
Nick Coghlan ncogh...@gmail.com added the comment:
Heh, rereading the issue comments, I noticed that my latest idea is quite
similar to what Terry suggested last year, just using delegation to adjust the
signatures appropriately rather than copying the function pointers directly
over.
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21367/650549138a3d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21258/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21367/650549138a3d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21368/650549138a3d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file21383/8bd713a823b5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Nick Coghlan ncogh...@gmail.com added the comment:
Martin and I are still experimenting with this issue as a test case for the
remote repository diff calculator, so apologies for the noise as we add and
remove patch files.
--
___
Python tracker
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21383/8bd713a823b5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21384/8bd713a823b5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21384/8bd713a823b5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21386/8bd713a823b5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21217/b9b7d4c10bc4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21256/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21256/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21257/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Removed file: http://bugs.python.org/file21257/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Martin v. Löwis mar...@v.loewis.de:
Added file: http://bugs.python.org/file21258/f1bd5468dae6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Nick Coghlan ncogh...@gmail.com added the comment:
The draft code is now only on the respect_LHS_precedence branch of my sandbox
repository.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Nick Coghlan ncogh...@gmail.com added the comment:
Well, there and in the named diff file on here, of course.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Alex Gaynor alex.gay...@gmail.com:
--
nosy: +alex
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list mailing
Nick Coghlan ncogh...@gmail.com added the comment:
Armin: yeah, I learned better in the course of trying to fix this misbehaviour
in CPython. I've adjusted assorted sq_concat methods to return NotImplemented
in the sandbox where I'm working on this, along with modifying abstract.c to
Nick Coghlan ncogh...@gmail.com added the comment:
My work in progress is on the respect_LHS_precedence branch in
http://hg.python.org/sandbox/ncoghlan
Current status is that I have tests for correct handling of sq_concat and
sq_repeat, and am close to having sq_concat and sq_inplace_concat
Nick Coghlan ncogh...@gmail.com added the comment:
Trying out the hg integration MvL added to Roundup.
--
hgrepos: +3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file21216/85d7c99fd31e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file21216/85d7c99fd31e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file21217/b9b7d4c10bc4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Nick Coghlan ncogh...@gmail.com added the comment:
I generated a patch between my sandbox and the main repository using the rdiff
extension immediately after syncing with the main line of development. (hg
diff --reverse cpython where cpython is aliased to the main repository)
This is the
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file21220/2f5db44c98f2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file21220/2f5db44c98f2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Nick Coghlan ncogh...@gmail.com added the comment:
I think the roundup/Hg integration may be getting confused by the merges of the
cpython main line of development with my sandbox.
--
___
Python tracker rep...@bugs.python.org
Benjamin Peterson benja...@python.org added the comment:
Is that a patch you can put on Rietveld then? (/me wanting to review)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Nick Coghlan ncogh...@gmail.com added the comment:
MvL says the review creation script should be able to cope with the rdiff
output within the next day or so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Terry J. Reedy tjre...@udel.edu added the comment:
b9b7d4c10bc4.diff is a huge compilation of all commits from the last few days,
with the abstract.c diff buried about 3/4ths of the way through.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
We know, I left it there to help MvL debug the issues in the diff generator.
The version I created with the rdiff extension is correct though, and Martin
fixed the Reitveld integration to handle the extra lines at the start of the
diff.
I
Changes by Armin Rigo ar...@users.sourceforge.net:
--
nosy: -arigo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Changes by Carl Friedrich Bolz cfb...@gmx.de:
--
nosy: +cfbolz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Nick Coghlan ncogh...@gmail.com added the comment:
Armin, I'm not sure returning NotImplemented from __iadd__ is a good idea in
this case. It means += on a mutable object may silently fail to mutate
in-place - enabling that seems rather questionable.
--
nosy: +ncoghlan
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
It seems to me that the underlying (design) flaw is having duplicate slots in
the C type structure*. I presume that having two different functions in
num-add and seq-add (concat) (I know, not quite the proper names), etc, is an
error. I also
Terry J. Reedy tjre...@udel.edu added the comment:
And if num-add is present and seq-add not, copy the other way, even if it were
recommended to only use the former.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Armin Rigo ar...@users.sourceforge.net added the comment:
Nick: we get a TypeError anyway if we do unsupported things like lst += None.
It seems to me that you are confusing levels, unless you can point out a
specific place in the documentation that would say never return NotImplemented
from
Terry J. Reedy tjre...@udel.edu added the comment:
I think Nick's point, and one I agree with, is (or amounts to):
'somelist += ob' == 'somelist.__iadd__(ob)' ==
'somelist.extend(ob)' == 'somelist[len(somelist):len(somelist)]=ob'
is defined and should be implemented for all somelist,ob
Changes by Daniel Urban urban.dani...@gmail.com:
--
nosy: +durban
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Armin Rigo ar...@users.sourceforge.net added the comment:
Note that I fixed one case in PyPy: if the class C has no __iter__() but only
__radd__(), and we call somelist += C(). This was done simply by having
somelist.__iadd__(x) return NotImplemented in case x is not iterable, instead
of
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
New submission from Terry J. Reedy tjre...@udel.edu:
Example (which can serve as testcase with buggy output corrected).
class C(object):
def __iter__(self):
yield 'yes!'
def __radd__(self, other):
other.append('bug!')
return other
def __rmul__(self, other):
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
Second link to pydev should be
http://mail.python.org/pipermail/python-dev/2011-March/109130.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
53 matches
Mail list logo
