[issue11613] test_subprocess fails under Windows

2011-03-21 Thread Reid Kleckner
Reid Kleckner added the comment: The bot is green again as of ab2363f89058. Thanks for the heads up. -- status: open -> closed ___ Python tracker ___ __

[issue11613] test_subprocess fails under Windows

2011-03-20 Thread Reid Kleckner
Reid Kleckner added the comment: It is necessary, WaitForSingleObject takes its argument in milliseconds. It will make the exception message wrong, though, which I can fix. Reid On Sun, Mar 20, 2011 at 1:46 PM, Santoso Wijaya wrote: > > Santoso Wijaya added the comment: > > The timeout valu

[issue11613] test_subprocess fails under Windows

2011-03-20 Thread Santoso Wijaya
Santoso Wijaya added the comment: Actually, the multiplication was necessary because _subprocess.WaitForSingleObject takes the timeout argument in millisecond unit. Defer multiplication until then. -- Added file: http://bugs.python.org/file21311/timeoutsec.patch _

[issue11613] test_subprocess fails under Windows

2011-03-20 Thread Santoso Wijaya
Changes by Santoso Wijaya : Removed file: http://bugs.python.org/file21310/timeoutsec.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11613] test_subprocess fails under Windows

2011-03-20 Thread Santoso Wijaya
Santoso Wijaya added the comment: The timeout value given to wait() is multiplied by 1000 before being passed to TimeoutExpired constructor. The multiplication is unnecessary since we take the input unit as time unit second. -- keywords: +patch nosy: +santa4nt Added file: http://bugs.

[issue11613] test_subprocess fails under Windows

2011-03-20 Thread Antoine Pitrou
New submission from Antoine Pitrou : There seem to be some buglets in the timeout code: http://www.python.org/dev/buildbot/all/builders/x86%20Windows7%203.x/builds/2783/steps/test/logs/stdio == ERROR: test_check_output_timeout