Roundup Robot devnull@devnull added the comment:
New changeset 575ee55081dc by Antoine Pitrou in branch 'default':
Issue #11688: Add sqlite3.Connection.set_trace_callback(). Patch by Torsten
Landschoff.
http://hg.python.org/cpython/rev/575ee55081dc
--
nosy: +python-dev
Antoine Pitrou pit...@free.fr added the comment:
Patch committed, thank you!
--
assignee: ghaering -
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Reopening, a failure appeared on some of the buildbots. I've made the failure
message a bit more explicit:
test_sqlite: testing with version '2.6.0', sqlite_version '3.6.12'
[...]
Antoine Pitrou pit...@free.fr added the comment:
Ok, it seems that expanding the value of bound parameters in the statement
passed to the trace callback is a recent SQLite feature:
http://www.sqlite.org/draft/releaselog/3_6_21.html
“The SQL output resulting from sqlite3_trace() is now
Roundup Robot devnull@devnull added the comment:
New changeset ce37570768f5 by Antoine Pitrou in branch 'default':
Fix TraceCallbackTests to not use bound parameters (followup to issue #11688)
http://hg.python.org/cpython/rev/ce37570768f5
--
___
Antoine Pitrou pit...@free.fr added the comment:
Should be fixed now.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11688
___
Antoine Pitrou pit...@free.fr added the comment:
The patch looks good to me, thank you!
Gerhard, would you like to tackle this? Otherwise I'll commit in a couple of
days.
--
stage: patch review - commit review
___
Python tracker
Torsten Landschoff t.landsch...@gmx.net added the comment:
The patch looks good to me, thank you!
Gerhard, would you like to tackle this? Otherwise I'll commit in a couple of
days.
What I am still wondering about is if it would make sense to use the text
factory here. It might make sense
Antoine Pitrou pit...@free.fr added the comment:
OTOH, this is mostly a debugging aid and nothing that would be enabled
in production. And premature optimization is the root of all evil...
Agreed.
--
___
Python tracker rep...@bugs.python.org
Torsten Landschoff t.landsch...@gmx.net added the comment:
- you need to document the new API in Doc/library/sqlite3.rst
Included in the updated patch.
+self.assertTrue([x for x in traced_statements if x.find(create
table foo) != -1])
This looks a bit complicated, why not
Antoine Pitrou pit...@free.fr added the comment:
Thanks for the patch.
A couple of comments:
- this is a new feature, so can only go in in 3.x: no need to post a 2.7 patch
(unless this helps Gerhard for his standalone project)
- you need to document the new API in Doc/library/sqlite3.rst
Torsten Landschoff t.landsch...@gmx.net added the comment:
A couple of comments:
- this is a new feature, so can only go in in 3.x: no need to post a 2.7
patch (unless this helps Gerhard for his standalone project)
The motivation for the 2.7er patch is mostly that we are still using Python
New submission from Torsten Landschoff t.landsch...@gmx.net:
I'd like to access the SQLite trace callback from Python to actually see the
same queries that SQLite actually gets to see.
The C API of SQLite supports this via the sqlite3_trace function. I added
support to this to the sqlite3
Torsten Landschoff t.landsch...@gmx.net added the comment:
Here is the same change for Python 2.7. I don't expect this to get merged on
the Python 2 branch, put perhaps it is useful to somebody.
--
Added file: http://bugs.python.org/file21414/sqlite_trace_py27.diff
Changes by Benjamin Peterson benja...@python.org:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11688
___
15 matches
Mail list logo
