[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2013-08-02 Thread Charles-François Natali
Changes by Charles-François Natali cf.nat...@gmail.com: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11757 ___ ___

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2013-07-05 Thread Christian Heimes
Christian Heimes added the comment: Is there anything left to do here? -- nosy: +christian.heimes resolution: - fixed stage: needs patch - committed/rejected status: open - pending ___ Python tracker rep...@bugs.python.org

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-10 Thread Reid Kleckner
Reid Kleckner r...@mit.edu added the comment: I think the best behavior would be to go ahead and check one last time before raising the exception, so _remaining_time should turn a negative value into 0 (assuming that a timeout value of zero does the right thing for our use case). If people

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-09 Thread Charles-Francois Natali
Charles-Francois Natali neolo...@free.fr added the comment: Oh, I didn't know. In this case, is my commit 3664fc29e867 correct? I think that it is, because without the patch, subprocess may call poll() with a negative timeout, and so it is no more a timeout at all. Yes, it looks correct.

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-09 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset 3982be773b54 by Antoine Pitrou in branch 'default': Issue #11757: select.select() now raises ValueError when a negative timeout http://hg.python.org/cpython/rev/3982be773b54 -- ___ Python

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-08 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: Le vendredi 08 avril 2011 à 05:34 +, Charles-Francois Natali a écrit : Charles-Francois Natali neolo...@free.fr added the comment: You may also patch poll_poll(). Poll accepts negative timeout values, since it's the

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-07 Thread Charles-Francois Natali
Charles-Francois Natali neolo...@free.fr added the comment: It seems to have fixed the failure, no ? I don't know what's the policy regarding syscall parameters check, but I think it'd be better to check that the timeout passed to select is not negative, and raise an exception otherwise, instead

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-07 Thread Gregory P. Smith
Gregory P. Smith g...@krypto.org added the comment: Adding that check with an exception to selectmodule.c is a good idea. i like your patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11757

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-07 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: You may also patch poll_poll(). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11757 ___

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-07 Thread Charles-Francois Natali
Charles-Francois Natali neolo...@free.fr added the comment: You may also patch poll_poll(). Poll accepts negative timeout values, since it's the only way to specify an infinite wait (contrarily to select which can be passed NULL). -- ___ Python

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-05 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@haypocalc.com: -- title: test_subprocess failure - test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout? ___ Python tracker rep...@bugs.python.org

[issue11757] test_subprocess.test_communicate_timeout_large_ouput failure on select(): negative timeout?

2011-04-05 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset 3664fc29e867 by Victor Stinner in branch 'default': Issue #11757: subprocess ensures that select() and poll() timeout = 0 http://hg.python.org/cpython/rev/3664fc29e867 -- nosy: +python-dev