STINNER Victor victor.stin...@haypocalc.com added the comment:
A timeout of 60 minutes looks to be fine. Today I debuged a thread+signal issue
which gave me an headache, so I prefer to close this issue: only add create
thread per file, and not a thread per function.
--
resolution: -
STINNER Victor victor.stin...@haypocalc.com added the comment:
Simplify the test and set the default timeout to 15 min.
--
Added file: http://bugs.python.org/file21582/regrtest_timeout-3.patch
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21575/regrtest_timeout-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11800
___
Michael Foord mich...@voidspace.org.uk added the comment:
Victor's reasons for wanting per-test timeout rather than per-file seem sound.
Need to review the patch to see how much extra complexity it actually
introduces (although on a casual reading the new custom result object it
introduces is
STINNER Victor victor.stin...@haypocalc.com added the comment:
With the current implementation of faulthandler.dump_tracebacks_later(), use a
timeout per function means create a new thread for each function (the thread is
interrupted and exits when the test is done).
Quick benchmark with
STINNER Victor victor.stin...@haypocalc.com added the comment:
I did a similar test on Windows: test_io takes ~19.1 sec with and without
timeout. If I look closer, the timeout overhead (call a thread per function
call) is 112 µs per function call. The average duration of a test is 48 ms
Antoine Pitrou pit...@free.fr added the comment:
I did a similar test on Windows: test_io takes ~19.1 sec with and
without timeout.
You may want to test with test_argparse.
--
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
Le vendredi 08 avril 2011 à 17:31 +, Antoine Pitrou a écrit :
Antoine Pitrou pit...@free.fr added the comment:
I did a similar test on Windows: test_io takes ~19.1 sec with and
without timeout.
You may want to test with
New submission from STINNER Victor victor.stin...@haypocalc.com:
I added recently a --timeout option to regrtest.py: dump the traceback of all
threads and exit if a test takes more than TIMEOUT seconds (issue #11727). But
my implementation was not correct: the timeout is applied on the whole
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11800
___
___
Python-bugs-list
STINNER Victor victor.stin...@haypocalc.com added the comment:
I forgot to patch some calls to runtest(): new patch.
--
Added file: http://bugs.python.org/file21575/regrtest_timeout-2.patch
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file21573/regrtest_timeout.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11800
___
Antoine Pitrou pit...@free.fr added the comment:
The question is: what's the point? Having an individual test timeout is not
more correct than having a timeout for a test file. Both are arbitrary.
Therefore, I'd prefer we choose the simplest solution and this patch brings
complication. I'm
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
FWIW, I prefer the whole file approach.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11800
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
I would like a timeout per function call because some files contain many slow
tests: the duration of a file depends on the number of tests. Imagine that all
functions takes 1 second: a file with 200 functions takes 200 seconds,
Antoine Pitrou pit...@free.fr added the comment:
Buildbots use currently a global timeout of 1 hour. I tried timeouts
of 5, 15 and 30 minutes for a file, and I always got false positive.
Using a timeout of 15 minutes per function, I don't expect any false
positive anymore.
Still I don't see
STINNER Victor victor.stin...@haypocalc.com added the comment:
Still I don't see the point. Is a 60 minutes timeout too long?
If regrtest timeout is too close to the buildbot timeout, we may not get the
traceback if the blocking test is the last test.
I don't know yet if we will get false
Antoine Pitrou pit...@free.fr added the comment:
Le jeudi 07 avril 2011 à 23:08 +, STINNER Victor a écrit :
STINNER Victor victor.stin...@haypocalc.com added the comment:
Still I don't see the point. Is a 60 minutes timeout too long?
If regrtest timeout is too close to the buildbot
18 matches
Mail list logo
