Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 7c48bb929e6e by Stefan Krah in branch 'default':
Issue #11826: Fix memory leak in atexitmodule.
http://hg.python.org/cpython/rev/7c48bb929e6e
--
nosy: +python-dev
___
Changes by Stefan Krah stefan-use...@bytereef.org:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11826
Stefan Krah stefan-use...@bytereef.org added the comment:
Actually _iomodule.c already has a freefunc with the same signature.
atexit_free() is properly called in:
static void
module_dealloc(PyModuleObject *m)
{
PyObject_GC_UnTrack(m);
if (m-md_def m-md_def-m_free)
Stefan Krah stefan-use...@bytereef.org added the comment:
Antoine Pitrou rep...@bugs.python.org wrote:
Well, if it doesn't crash, it's probably ok ;)
Perhaps check modstate-atexit_callbacks for non-NULL?
Or do we trust free() to do the right thing?
I was initially surprised by this, but the
Antoine Pitrou pit...@free.fr added the comment:
Well, if it doesn't crash, it's probably ok ;)
Perhaps check modstate-atexit_callbacks for non-NULL? Or do we trust free() to
do the right thing?
--
nosy: +pitrou
___
Python tracker
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
It's the very first usage of PyModuleDef::m_free.
Martin, do you agree with the path?
--
nosy: +amaury.forgeotdarc, loewis
___
Python tracker rep...@bugs.python.org
New submission from Stefan Krah stefan-use...@bytereef.org:
Valgrind reports a leak (definitely lost) in atexitmodule.c. The
patch fixes the problem.
--
components: Extension Modules
files: atexit-leak.patch
keywords: patch
messages: 133501
nosy: skrah
priority: normal
severity: normal
