Éric Araujo mer...@netwok.org added the comment:
The module docstring (which duplicates the reST docs) still mentions
list2cmdline. I’d vote for removal there too.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11827
Changes by Eli Bendersky eli...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11827
___
___
Python-bugs-list
Roundup Robot devnull@devnull added the comment:
New changeset e7a55e236b8b by Eli Bendersky in branch '3.1':
Issue #11827: remove mention of list2cmdline in the doc of subprocess
http://hg.python.org/cpython/rev/e7a55e236b8b
--
nosy: +python-dev
___
Roundup Robot devnull@devnull added the comment:
New changeset f38489a3394f by Eli Bendersky in branch '2.7':
Issue #11827: remove mention of list2cmdline in the doc of subprocess
http://hg.python.org/cpython/rev/f38489a3394f
--
___
Python tracker
Changes by Eli Bendersky eli...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11827
___
___
Python-bugs-list
Eli Bendersky eli...@gmail.com added the comment:
Patch committed to 3.3, 3.2, 3.1, 2.7
In case no objections arise, I will close this issue in a couple of days
--
status: pending - open
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
LGTM.
--
versions: +Python 2.7, Python 3.1, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11827
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
If a _ is added to list2cmdline the old name should be kept and deprecated.
The function is also on 2.x and it's not deprecated there (and it's probably
too late to deprecate it now), so we might have to wait a few versions before
it will
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11827
___
___
Python-bugs-list
Eli Bendersky eli...@gmail.com added the comment:
Attaching a proposed patch for 3.2, focusing only on the documentation for the
time being (I realize that deprecation is a loaded issue and should be probably
handled in a centralized manner).
The patch removes mention of list2cmdline, instead
New submission from Eli Bendersky eli...@gmail.com:
The documentation of subprocess.Popen mentions a function named list2cmdline():
On Windows: the Popen class uses CreateProcess() to execute the child
program, which operates on strings. If args is a sequence, it will be converted
to a
R. David Murray rdmur...@bitdance.com added the comment:
I vote for (2) (I presume 'it' in that sentence is 'subprocess'). list2cmdline
shouldn't be a real public method, at least not without the issues
surrounding being given careful design attention.
--
nosy: +r.david.murray
Eli Bendersky eli...@gmail.com added the comment:
I also prefer (2) since I see no reason for the user to use list2cmdline()
directly, let alone from subprocess (had there been rationale for such a public
function it should probably be in another module).
As for 'it', I guess you can say it
R. David Murray rdmur...@bitdance.com added the comment:
Ah, right. I guess I was advocating that the docs be written from the
perspective that list2cmdline doesn't exist as an identifiable entity. From
the POV of the updated docs, it is just subprocess's behavior, and list2cmdline
is an
Ross Lagerwall rosslagerw...@gmail.com added the comment:
#10838 has a bit of discussion about list2cmdline and being part of the public
api (generally agreeing that it should be made private, I think).
--
nosy: +rosslagerwall
___
Python tracker
Eli Bendersky eli...@gmail.com added the comment:
Thanks for the pointer, Ross.
So I propose to remove the mention of list2cmdline from the documentation of
subprocess, explaining instead what it does to the path (since I think this
should be publicly known, otherwise it's just black magic).
16 matches
Mail list logo
