Roundup Robot added the comment:
New changeset 5bff555168ab by Petri Lehtinen in branch '3.2':
#11964: Document a change in v3.2 to the json indent parameter
http://hg.python.org/cpython/rev/5bff555168ab
New changeset 0fb511659ef4 by Petri Lehtinen in branch 'default':
#11964: Document a change
Petri Lehtinen added the comment:
Fixed, thanks.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
Chris Rebert added the comment:
It's been over a year and the patch is trivial. Any chance of it getting
applied soon?
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
Éric Araujo added the comment:
See my previous message where I say that a careful check is needed.
--
nosy: +sandro.tosi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
___
Petri Lehtinen added the comment:
I don't think the test changes are needed, because both dump() and dumps() use
JSONEncoder internally, and all current indent testing is done using dumps()
anyway.
More important would be to update the documentation of indent for JSONEncoder
to match that of
Petri Lehtinen added the comment:
Attached a new patch.
--
Added file: http://bugs.python.org/file27017/issue11964.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
___
Éric Araujo added the comment:
LGTM.
--
assignee: eric.araujo - petri.lehtinen
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
___
Éric Araujo mer...@netwok.org added the comment:
This is my current patch, FYI.
--
keywords: +patch
Added file:
http://bugs.python.org/file22178/versionadded-3.2-json-indent-str.diff
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
It turns out that only one documentation block talks about the new indent
behavior. It was easy to add a versionchanged directive to that, but I think a
complete patch would fix all mentions of the indent argument, after checking
that all of
Éric Araujo mer...@netwok.org added the comment:
I will fix this.
Prashanth Raghu: (sorry to call you by your full name, which is not very nice
in my language, but I’m not sure which is your first name) “The .rst file that
was downloaded as of 30-04-2011 (dd-mm-) had the updated doc”:
New submission from Éric Araujo mer...@netwok.org:
I found out that the indent parameter of json.dump was changed in 3.2: it can
be a string as well as an int. The docstring was not updated; the reST doc
was, but without a versionchanged directive.
This probably applies to the doc and
R. David Murray rdmur...@bitdance.com added the comment:
This change was made by Raymond in issue 5729. It is the only feature added by
that patch; the missing versionchanged was an oversight and I don't think it
makes any more likely that other features were added that weren't documented.
Éric Araujo mer...@netwok.org added the comment:
This change was made by Raymond in issue 5729. It is the only feature
added by that patch; the missing versionchanged was an oversight and I
don't think it makes any more likely that other features were added
that weren't documented.
Ah, I’m
Prashanth Raghu p.is.prasha...@gmail.com added the comment:
The .rst file that was downloaded as of 30-04-2011 (dd-mm-) had the updated
doc .
--
nosy: +Prashanth.Raghu
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11964
___
___
15 matches
Mail list logo
