[issue12139] Add CCC command support to ftplib

2011-06-30 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: The test is still failing on many buildbots. x86 Ubuntu Shared 3.x: == ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)

[issue12139] Add CCC command support to ftplib

2011-06-30 Thread Giampaolo Rodola'
Giampaolo Rodola' g.rod...@gmail.com added the comment: The culprit here is the dummy FTP test server which does not complete the SSL shutdown procedure successfully. I believe it's better if we remove the self.client.sendcmd('noop') line. That's there in order to check that client and server

[issue12139] Add CCC command support to ftplib

2011-06-30 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset 0cef8cac71c8 by Giampaolo Rodola' in branch 'default': Issue 12139: ftplib - remove 'post CCC' test to fix various buildot failures due to dummy test server not properly handling SSL shutdown(), see http://bugs.python.org/msg139499

[issue12139] Add CCC command support to ftplib

2011-06-30 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12139 ___ ___

[issue12139] Add CCC command support to ftplib

2011-06-29 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- resolution: - fixed status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12139 ___

[issue12139] Add CCC command support to ftplib

2011-06-27 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset d2eacbbdaf57 by Giampaolo Rodola' in branch 'default': Issue 12139: add CCC command support to FTP_TLS class to revert the SSL connection back to clear-text. http://hg.python.org/cpython/rev/d2eacbbdaf57 -- nosy:

[issue12139] Add CCC command support to ftplib

2011-06-27 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12139

[issue12139] Add CCC command support to ftplib

2011-06-27 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/4043/steps/test/logs/stdio == ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)

[issue12139] Add CCC command support to ftplib

2011-06-27 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: http://www.python.org/dev/buildbot/all/builders/x86%20Tiger%203.x/builds/2792/steps/test/logs/stdio == ERROR: test_ccc (test.test_ftplib.TestTLS_FTPClass)

[issue12139] Add CCC command support to ftplib

2011-06-27 Thread Giampaolo Rodola'
Giampaolo Rodola' g.rod...@gmail.com added the comment: Hmm... Reopening. I'll look into this later. -- resolution: fixed - status: closed - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12139

[issue12139] Add CCC command support to ftplib

2011-05-21 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola' g.rod...@gmail.com: In FTPS, CCC command can be used to switch back to a clear-text control connection. This can be useful to take advantage of firewalls that know how to handle NAT with non-secure FTP without opening fixed ports. Patch in attachment

[issue12139] Add CCC command support to ftplib

2011-05-21 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: This can be useful to take advantage of firewalls that know how to handle NAT with non-secure FTP without opening fixed ports. Can you explain this a little more? +resp = self.voidcmd('CCC') +self.sock =

[issue12139] Add CCC command support to ftplib

2011-05-21 Thread Giampaolo Rodola'
Giampaolo Rodola' g.rod...@gmail.com added the comment: voidcmd() expects a response code starting with 2 and automatically raises an exception otherwise. A server succesfully accepting the CCC command is supposed to first reply with 220 and then shutdown() the SSL layer. Client is supposed to