[issue12190] intern filenames in bytecode

2011-05-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: Okay, I'll close. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyt

[issue12190] intern filenames in bytecode

2011-05-27 Thread Mike Solomon
Mike Solomon added the comment: The in-memory fix is really the most important - the disk space was a bonus and an easy metric to gather. Unfortunately, our app won't be upgrading to python 3.x. On Fri, May 27, 2011 at 7:10 AM, Benjamin Peterson wrote: > > Benjamin Peterson added the comment

[issue12190] intern filenames in bytecode

2011-05-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: As you can see, I've implemented a similar solution in 3.3. It should have the same memory savings but not disk space saving. (This would require reintroducing the marshal feature for interned strings.) -- ___ P

[issue12190] intern filenames in bytecode

2011-05-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27359a4e0f8c by Benjamin Peterson in branch 'default': try to use the same str object for all code filenames when compiling or unmarshalling (#12190) http://hg.python.org/cpython/rev/27359a4e0f8c -- nosy: +python-dev _

[issue12190] intern filenames in bytecode

2011-05-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2011/5/26 Mike Solomon : > > Mike Solomon added the comment: > > If you have a file with say a hundred functions, and each function contains > the full path of that file on disk, your pyc file will contain about > (100*(path_size+overhead)) bytes. In some ca

[issue12190] intern filenames in bytecode

2011-05-26 Thread Charles-François Natali
Changes by Charles-François Natali : Removed file: http://bugs.python.org/file22136/unnamed ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12190] intern filenames in bytecode

2011-05-26 Thread Mike Solomon
Mike Solomon added the comment: If you have a file with say a hundred functions, and each function contains the full path of that file on disk, your pyc file will contain about (100*(path_size+overhead)) bytes. In some cases, this is pretty significant. On Thu, May 26, 2011 at 12:47 PM, Benjami

[issue12190] intern filenames in bytecode

2011-05-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue12190] intern filenames in bytecode

2011-05-26 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo type: performance -> resource usage versions: +Python 3.3 -Python 2.6, Python 2.7 ___ Python tracker ___ _

[issue12190] intern filenames in bytecode

2011-05-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: How exactly does it bring down your disk space? -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue12190] intern filenames in bytecode

2011-05-26 Thread Nadeem Vawda
Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue12190] intern filenames in bytecode

2011-05-26 Thread Mike Solomon
New submission from Mike Solomon : I work on a large app and we noticed that a surprising portion of our heap was filenames embedded the the bytecode. This one-line patch to intern filenames reduces our on-disk size about ~15% and brings down our heap and in-memory object count by a similar pe