[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Change by Zackery Spytz : -- pull_requests: +13599 pull_request: https://github.com/python/cpython/pull/13712 ___ Python tracker ___

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.7 ___ Python tracker ___

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Berker Peksag added the comment: New changeset 549e55a3086d04c13da9b6f33214f6399681292a by Berker Peksag (Zackery Spytz) in branch 'master': bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib (GH-13711)

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Zackery Spytz added the comment: This issue needs to be fixed. Passing an invalid value to SummaryInformation.GetProperty() will cause the first MsiSummaryInfoGetProperty() call to fail. As the call is not properly checked, the "type" variable will then be used uninitialized in

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Change by Zackery Spytz : -- pull_requests: +13598 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13711 ___ Python tracker ___

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Mark Lawrence added the comment: The code change to _msi.c is minimal, the bulk of the patch is additional test code. I think we could still use this. Thoughts? See also #1104. -- components: +Windows nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

New submission from Mark Mc Mahon mtnbikingm...@gmail.com: Per Eric V. Smith's comment issue1104 (msg134976) the return value of the call MsiSummaryInfoGetProperty() in summary_getproperty() (pc\_msi.c) is only checked for the error return ERROR_MORE_DATA. Other error values should be

[issue12202] Check status returns in msilib.SummaryInformation.GetProperty()

Mark Mc Mahon mtnbikingm...@gmail.com added the comment: I have added tests to the patch - but it's not easy to know what would cause an error in MsiSummaryInfoGetProperty which would trigger the new code. -- keywords: +patch Added file: