[issue12268] file readline, readlines & readall methods can lose data on EINTR

Martijn Pieters added the comment: Follow-up bug, readahead was missed: http://bugs.python.org/issue1633941 -- nosy: +mjpieters ___ Python tracker ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Roundup Robot added the comment: New changeset a5e7b38caee2 by Gregory P. Smith in branch '2.7': Additional fix for Issue #12268: The io module file object writelines() methods http://hg.python.org/cpython/rev/a5e7b38caee2 New changeset 2fd669aa4abc by Gregory P. Smith in branch '3.2':

[issue12268] file readline, readlines readall methods can lose data on EINTR

STINNER Victor added the comment: Oh, so we can now implement a version of writelines() using writev()! 2013/2/1 Roundup Robot rep...@bugs.python.org: Roundup Robot added the comment: New changeset a5e7b38caee2 by Gregory P. Smith in branch '2.7': Additional fix for Issue #12268: The io

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith added the comment: it was easier to just take care of auditing the write calls as part of this given the code change was directly related to it. On Python 2.7 most of the write calls in the builtin file object (Objects/fileobject.c) rather than the new io module use the libc

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Antoine Pitrou added the comment: Is there anything left to do here? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith added the comment: Yes. See my comment from June. The write paths need to be taken care of. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Antoine Pitrou added the comment: Well, this issue is about readline, readlines readall. It would be easier to follow if you opened a separate issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gary Miguel gar...@google.com: -- nosy: +Gary.Miguel ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___ Python-bugs-list

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Mark Dickinson dicki...@gmail.com: -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Roundup Robot added the comment: New changeset 751a91e332d9 by Gregory P. Smith in branch '2.7': Fixes Issue #12268 for the io module - File readline, readlines and http://hg.python.org/cpython/rev/751a91e332d9 -- ___ Python tracker

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___ Python-bugs-list

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: I'm attaching an updated patch for 2.7. It fixes read, readline, readlines and readinto and includes tests. More code auditing for other methods to fix is still needed. -- versions: -Python 3.1 Added file:

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: The 3.* ubuntu arm buildbot hanging in test_io is very odd. I'm going to undo my supposedly straight forward signal.alarm(...) to signal.setitimer(...) change first to see if that is related. --

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: Removed file: http://bugs.python.org/file22258/file-signal-eintr-27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 95b071194ddd by Gregory P. Smith in branch '3.2': Backout change e8f44ebacda7052267318cecf5b6f128d35add17. Reverting the test http://hg.python.org/cpython/rev/95b071194ddd New changeset b4ae7aa21b46 by Gregory P.

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: Removed file: http://bugs.python.org/file22262/test_and_fix_readers_3.2-gps02.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Antoine Pitrou pit...@free.fr added the comment: I don't think setitimer() is the culprit, rather the fact that the timeout is too short. You could try setting it to e.g. 0.4. -- ___ Python tracker rep...@bugs.python.org

[issue12268] file readline, readlines readall methods can lose data on EINTR

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 67dc99a989cd by Gregory P. Smith in branch '2.7': Fixes issue #12268 for file readline, readlines and read() and readinto methods. http://hg.python.org/cpython/rev/67dc99a989cd --

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: The uses of fwrite() and fflush() also need this EINTR treatment in 2.7. I haven't checked the write paths in 3.2 yet. Also, the fix change to 3.2's _io module needs backporting to 2.7's _io module for people using that. --

[issue12268] file readline, readlines readall methods can lose data on EINTR

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 781b95159954 by Gregory P. Smith in branch '3.2': Fixes issue #12268: File readline, readlines and read() or readall() methods http://hg.python.org/cpython/rev/781b95159954 New changeset 19a6bef57490 by Gregory P.

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: I'm leaving this open as I still need to audit the write methods and commit the fix(es) for 2.7. I tried to merge the test into test_io's signals tests but I could not get that to actually work to reproduce the original problem so I kept my

[issue12268] file readline, readlines readall methods can lose data on EINTR

Antoine Pitrou pit...@free.fr added the comment: For the record, there was a crash on the ARM buildbot: [196/368/1] test_io Timeout (1:00:00)! Thread 0x2aac5300: File /var/lib/buildbot/buildarea/3.x.warsaw-ubuntu-arm/build/Lib/test/test_io.py, line 3051 in check_interrupted_write_retry

[issue12268] file readline, readlines readall methods can lose data on EINTR

Antoine Pitrou pit...@free.fr added the comment: I'm not sure why you're creating a separate test file. There are already signals-related tests in test_io. Also, perhaps you can reuse the idioms used there, rather than spawn subprocesses. -- stage: - patch review

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: I haven't looked beyond the reading methods it is possible that some of the write implementations have a similar issue. Patch gps02 for 3.2 attached. I'll use that as the basis for a stand alone test_file_eintr.py targeted at 2.7.

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: Removed file: http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___ Python-bugs-list mailing

[issue12268] file readline, readlines readall methods can lose data on EINTR

Gregory P. Smith g...@krypto.org added the comment: .readall() and the equivalent unbounded .read() also have this problem. -- title: file readline readlines methods can lose data on EINTR - file readline, readlines readall methods can lose data on EINTR

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by John O'Connor tehj...@gmail.com: -- nosy: +jcon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___ ___ Python-bugs-list mailing

[issue12268] file readline, readlines readall methods can lose data on EINTR

Changes by Gregory P. Smith g...@krypto.org: Added file: http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12268 ___