Changes by Éric Araujo mer...@netwok.org:
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 8862ec62f9ee by Ezio Melotti in branch '3.2':
#12531: Fix spaces and markup.
http://hg.python.org/cpython/rev/8862ec62f9ee
New changeset b47c9982506c by Ezio Melotti in branch 'default':
#12531: merge with 3.2.
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 8328fe952303 by Eli Bendersky in branch '2.7':
Issue #12531: add index entries to documentation of * and ** in function calls
http://hg.python.org/cpython/rev/8328fe952303
--
nosy: +python-dev
Eli Bendersky eli...@gmail.com added the comment:
I've committed a fix into 2.7, taking Terry's advice (in function calls
subsection instead of statement) and Eric's sequence/iterable correction into
account.
If this looks OK, I will commit a similar fix to the 3.x branches as well.
Éric Araujo mer...@netwok.org added the comment:
Looks good to me.
One tip for commits: it’s often better to let a line exceed 80 characters in
order to make for a smaller diff. Here, only one word was changed but four
lines were marked as changed, which makes reviews longer. Lines are
Eli Bendersky eli...@gmail.com added the comment:
Éric - when I was just starting contributing patches to Python, I was strictly
disciplined by veteran devs to stay within 80 chars no matter what :-)
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a8aa918041c2 by Eli Bendersky in branch '3.2':
Issue #12531: add index entries to documentation of * and ** in function calls
http://hg.python.org/cpython/rev/a8aa918041c2
New changeset 221ca00121ef by Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
Eli Bendersky eli...@gmail.com added the comment:
Peter, would you like to submit a corrected patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
Éric Araujo mer...@netwok.org added the comment:
[...] If the syntax *expression appears in the function call,
expression must evaluate to a sequence.
An iterable :)
--
nosy: +eric.araujo -ericsnow, terry.reedy
versions: -Python 2.7, Python 3.2
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +ericsnow, terry.reedy
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
Terry J. Reedy tjre...@udel.edu added the comment:
I would not propose to do everything in one grand patch as it would be way too
much to review all at once. A somewhat separate subissue is whether there
should be however many separate issues over the next however many years or one
master
Terry J. Reedy tjre...@udel.edu added the comment:
expression must evaluate to a sequence.
To be clear, Eli quoted the doc correctly and Eric correctly suggested that
'sequence' needs to be updated to 'iterable' (in at least two places). Since
the patch for this issue will be adding
Eli Bendersky eli...@gmail.com added the comment:
Peter, doesn't your patch also refer to the meaning of * and ** in function
definitions?
I would argue that the missing reference is to a paragraph further down:
[...] If the syntax *expression appears in the function call, expression
Terry J. Reedy tjre...@udel.edu added the comment:
This is just the tip of the iceberg as far as needed symbol index entries goes.
Nearly 3 years ago, I wrote a Python 3 symbol glossary Python3 Syntax Symbol
Uses that was complete as far as I knew then. I think most of the entries
there
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +ericsnow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
___
Python-bugs-list
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
___
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12531
___
___
Python-bugs-list
New submission from Peter Eisentraut pete...@gmx.net:
The existing documentation index entries for * and ** only point to their use
in function definitions but not to their use in function calls. I was looking
for the latter, and it was difficult to find without this. Here is a small
patch
19 matches
Mail list logo
