Antoine Pitrou pit...@free.fr added the comment:
Here is a patch. Can someone take a look?
--
Added file: http://bugs.python.org/file23962/oserror_new.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
Antoine Pitrou pit...@free.fr added the comment:
Updated patch. I've renamed oserror_post_init to oserror_init. Also addressed
Nick's other comments.
--
Added file: http://bugs.python.org/file23965/oserror_new2.patch
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d22c99e77768 by Antoine Pitrou in branch 'default':
Fix OSError.__init__ and OSError.__new__ so that each of them can be
http://hg.python.org/cpython/rev/d22c99e77768
--
Antoine Pitrou pit...@free.fr added the comment:
Fixed now.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
Changes by Nick Coghlan ncogh...@gmail.com:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Antoine Pitrou pit...@free.fr added the comment:
Is the following change in behavior caused by the fix for this issue?
$ python3.2 -c $'class A(IOError):\n def __init__(self, arg): pass\nA(arg=1)'
$ python3.3 -c $'class A(IOError):\n def __init__(self, arg): pass\nA(arg=1)'
Traceback
Antoine Pitrou pit...@free.fr added the comment:
Is the following change in behavior caused by the fix for this issue?
$ python3.2 -c $'class A(IOError):\n def __init__(self, arg):
pass\nA(arg=1)'
$ python3.3 -c $'class A(IOError):\n def __init__(self, arg):
pass\nA(arg=1)'
Nick Coghlan ncogh...@gmail.com added the comment:
There's a fairly sophisticated tapdance in object.__new__ that deals with this
problem at that level.
See: http://hg.python.org/cpython/file/default/Objects/typeobject.c#l2869
The new IOError may require something similarly sophisticated to
Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com added the comment:
Is the following change in behavior caused by the fix for this issue?
$ python3.2 -c $'class A(IOError):\n def __init__(self, arg): pass\nA(arg=1)'
$ python3.3 -c $'class A(IOError):\n def __init__(self, arg):
Nick Coghlan ncogh...@gmail.com added the comment:
Indeed, this seems to be the most likely culprit for the current buildbot
failures in the new urllib2 tests:
http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/2868/steps/test/logs/stdio
--
resolution:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a3ddee916808 by Jason R. Coombs in branch 'default':
Pass positional arguments - HTTPError is not accepting keyword arguments.
Reference #13211 and #12555.
http://hg.python.org/cpython/rev/a3ddee916808
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 41a1de81ef2b by Antoine Pitrou in branch 'default':
PEP 3151 / issue #12555: reworking the OS and IO exception hierarchy.
http://hg.python.org/cpython/rev/41a1de81ef2b
--
nosy: +python-dev
Antoine Pitrou pit...@free.fr added the comment:
Thanks everyone for the reviews!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
Antoine Pitrou pit...@free.fr added the comment:
Should the input of OSError be checked?
It could, but pre-PEP it is not, so I assumed it's better to minimize
compatibility-breaking changes.
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file23307/554524a74bbe.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Antoine Pitrou pit...@free.fr added the comment:
Patch update against latest default. There shouldn't be anything interesting to
see.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
Stefan Krah stefan-use...@bytereef.org added the comment:
I still need to understand the full impact of the PEP, but it seems
very sound. I've left two small comments on Rietveld, and there's
an additional question:
Should the input of OSError be checked?
OSError(not an errno, Bad file
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file23074/8a0e40f4f004.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Antoine Pitrou pit...@free.fr added the comment:
Here is a new patch implementing the latest PEP changes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file22966/aa9e276a791d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Antoine Pitrou pit...@free.fr added the comment:
New patch incorporating Ezio's comments and synchronized with latest default.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file22913/524e47d8b878.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Antoine Pitrou pit...@free.fr added the comment:
Updated patch with latest changes from the PEP. The implementation is now
complete.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
Remi Pointel pyt...@xiri.fr added the comment:
Hi,
I have tested on OpenBSD -current, and it seems to work fine:
$ ./python -E -bb Lib/test/test_mmap.py
test_access_parameter (__main__.MmapTests) ... ok
test_anonymous (__main__.MmapTests) ... ok
test_bad_file_desc (__main__.MmapTests)
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file22714/1d8b7f158721.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file22705/40ae82fafaed.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file22705/40ae82fafaed.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
--
components: +Library (Lib)
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Éric Araujo mer...@netwok.org added the comment:
The patch looks good. I can’t comment on details of the C code, but I’ve seen
the changed Python code and the tests and I like this.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
Changes by Dirkjan Ochtman dirk...@ochtman.nl:
--
nosy: +djc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Python-bugs-list mailing
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Python-bugs-list
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Python-bugs-list
New submission from Antoine Pitrou pit...@free.fr:
I now have a working PEP 3151 implementation, working on various platforms
(tested on Linux, Windows, FreeBSD and OpenIndiana buildbots).
The implementation has all the semantic changes and additions in PEP 3151. It
still lacks the
Changes by Antoine Pitrou pit...@free.fr:
--
hgrepos: +41
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Python-bugs-list mailing
Changes by Antoine Pitrou pit...@free.fr:
--
keywords: +patch
Added file: http://bugs.python.org/file22647/cac46b853098.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file22647/cac46b853098.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file22648/d305942126b6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Antoine Pitrou pit...@free.fr added the comment:
(I'm sorry for the filenames. I'm using the create patch feature in the hope
that a code review is possible through the Rietveld integration :-))
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file22650/9bb6b71f172d.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file22648/d305942126b6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12555
___
42 matches
Mail list logo
