Guido van Rossum added the comment:
2007/10/15, Christian Heimes [EMAIL PROTECTED]:
Christian Heimes added the comment:
Guido van Rossum wrote:
BTW we need a 2to3 fixer for this. Should be trivial -- just replace
*all* occurrences of basestring with str.
I believe you that it's
Guido van Rossum added the comment:
Committed revision 58495.
Thanks Christian!!!
--
resolution: - accepted
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
__
Christian Heimes added the comment:
Here is an updated patch which applies cleanly and fixes some additional
unit tests and removes one that doesn't make sense any more (re.compile
doesn't accept bytes).
The unit tests profile, cProfile and doctest fail w/ and w/o this patch.
They seem to
Guido van Rossum added the comment:
Hm? This is a one-word patch to email/generator.py.
On 10/15/07, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes added the comment:
Here is an updated patch which applies cleanly and fixes some additional
unit tests and removes one that
Changes by Guido van Rossum:
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
__
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
The unit tests profile, cProfile and doctest fail w/ and w/o this patch.
They seem to suffer from the latest changes of our previous patch and
additional calls to utf_8_decode().
Any details on those? They don't fail for me.
Guido van Rossum added the comment:
I'll check this in as soon as there's agreement on the list about this.
Not that I expect disagreement, but I just realized it was never brought
up and it isn't in PEP 3137 (yet).
__
Tracker [EMAIL PROTECTED]
Christian Heimes added the comment:
Any details on those? They don't fail for me.
Here you are.
$ ./python Lib/test/test_cProfile.py
121 function calls (101 primitive calls) in 1.000 CPU seconds
Ordered by: standard name
ncalls tottime percall cumtime percall
Guido van Rossum added the comment:
BTW we need a 2to3 fixer for this. Should be trivial -- just replace
*all* occurrences of basestring with str.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
__
Guido van Rossum added the comment:
Even before this patch, the re module doesn't work very well on byte
strings. IMO this should be fixed. I've filed a separate bug to remind
us: bug 1282.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
Christian Heimes added the comment:
Guido van Rossum wrote:
BTW we need a 2to3 fixer for this. Should be trivial -- just replace
*all* occurrences of basestring with str.
I believe you that it's trivial for *you* but I've never dealt with the
fixers or the grammar. Fortunately for me I was
Guido van Rossum added the comment:
Thanks, evaluating!
--
nosy: +gvanrossum
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
__
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
I see 10 failing tests:
test_ctypes test_email test_httplib test_inspect test_os test_re
test_subprocess test_sys test_xml_etree test_xml_etree_c
--
assignee: - gvanrossum
__
Tracker [EMAIL PROTECTED]
Christian Heimes added the comment:
test_ctypes: works for me
test_email: need some help from an email expoert
test_httplib: __file__ has a wrong type str8. I'm looking into it.
test_inspect: same issue as httplib
test_os: same issue
test_re: I had the failing test before my changes
File
Guido van Rossum added the comment:
On 10/10/07, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes added the comment:
test_ctypes: works for me
Did you svn up, make clean and rebuild?
test_email: need some help from an email expoert
Which test is failing?
test_httplib:
Christian Heimes added the comment:
Guido van Rossum wrote:
Did you svn up, make clean and rebuild?
The ctypes package didn't change since my last rebuild an hour ago. I'm
on Linux (Ubuntu i386)
test_email: need some help from an email expoert
Which test is failing?
Guido van Rossum added the comment:
On 10/10/07, Christian Heimes [EMAIL PROTECTED] wrote:
Christian Heimes added the comment:
Guido van Rossum wrote:
Did you svn up, make clean and rebuild?
The ctypes package didn't change since my last rebuild an hour ago. I'm
on Linux (Ubuntu i386)
Changes by Martin v. Löwis:
--
keywords: +patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1258
__
___
Python-bugs-list mailing list
Unsubscribe:
18 matches
Mail list logo