Changes by Éric Araujo mer...@netwok.org:
--
resolution: - out of date
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12659
___
Francisco Martín Brugué franci...@email.de added the comment:
I've updated the patch with a test case for 'create_distribution' and one minor
rename.
I personally don't like too much the structure of 'LoggingCatcherTestCase' so
improvements are welcome.
Cheers,
francis
--
Added
Francisco Martín Brugué franci...@email.de added the comment:
Patch updated.
BTW, I didn't get any email due the review that Éric did (does one has to be
registered? I've done that now).
--
Added file: http://bugs.python.org/file24689/issue12659_434cd2fedf81.patch
Francisco Martín Brugué franci...@email.de added the comment:
Patch looks good, thanks! BTW are you running a coverage tool to see how
far along we are?
Yes, always. The classes tested in that patch are at 100%.
The overall coverage is:
Name Stmts Miss Cover
Francisco Martín Brugué franci...@email.de added the comment:
On 02/11/2012 05:59 AM, Éric Araujo wrote:
BTW: in distutils2 I get (not because of this change):
Actually I did fix that, but depending on your Python version the conditional
in the test may be wrong. What’s the Python version
Éric Araujo mer...@netwok.org added the comment:
BTW: in distutils2 I get (not because of this change):
Actually I did fix that, but depending on your Python version the conditional
in the test may be wrong. What’s the Python version you used?
If so, could you provide a patch this time?
Éric Araujo mer...@netwok.org added the comment:
I've just updated “test_support.py” and tested against 'default'
Do you mean that you have added more tests to the existing file? If so, could
you provide a patch this time?
BTW: in distutils2 I get (not because of this change):
It’s a known
Francisco Martín Brugué franci...@email.de added the comment:
If so, could you provide a patch this time?
Done. The patch is against default.
what about against distutils2? Do you need also a patch for it?
--
Added file: http://bugs.python.org/file24458/issue12659_58bd6a58365d.patch
Francisco Martín Brugué franci...@email.de added the comment:
I've just updated “test_support.py” and tested against 'default'
and 'distutils2' (after changing the imports).
Just let me know what has to be changed ...
BTW: in distutils2 I get (not because of this change):
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 659bf2a679d2 by Éric Araujo in branch 'default':
Add tests for tests.support (#12659), thanks to Francisco Martín Brugué
http://hg.python.org/distutils2/rev/659bf2a679d2
--
Éric Araujo mer...@netwok.org added the comment:
I've added runTest to Tester
It turns out this was the only change needed. Tarek’s repo on bitbucket is not
up-to-date, I should have given you the hg.python.org link. (You can edit
.hg/hgrc in your repo and run “hg pull -u” to get missing
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
I've mutated test_support.py a bit and now passes in
https://bitbucket.org/tarek/distutils2 changeset:6c3d67ed3adb.
I've added runTest to Tester, used os.unlink also removed the test fake_dec
test as in support.py from
Éric Araujo mer...@netwok.org added the comment:
I ported the patch to distutils2, but it fails because of some unittest
internal problem. Help welcome.
--
Added file: http://bugs.python.org/file23664/test_support.py
___
Python tracker
Francisco Martín Brugué franci...@email.de added the comment:
Hi Éric,
Nice! and thanks for the info: I was just waiting to the check-in to
compare and try further with the tests. Now I can just commit another
patch by synching against the actual tip.
Cheers,
francis
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 0aad55c8ff26 by Éric Araujo in branch 'default':
Add tests for packaging.tests.support (#12659).
http://hg.python.org/cpython/rev/0aad55c8ff26
--
nosy: +python-dev
___
Éric Araujo mer...@netwok.org added the comment:
This first patch is committed! If you have any question about the changes I
made to your patch, feel free to ask them. The most important change I did was
running setUp and tearDown before and after each test method, as real unittest
would
Éric Araujo mer...@netwok.org added the comment:
Yes, you did. There are a few minor edits I’ll make to the patch, but
otherwise this is good to commit.
--
assignee: tarek - eric.araujo
versions: +3rd party
___
Python tracker rep...@bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Let me know if I've understood your review.
Thanks !
--
Added file: http://bugs.python.org/file23370/issue12659_v3.patch
___
Python tracker rep...@bugs.python.org
Francisco Martín Brugué franci...@email.de added the comment:
I've updated the patch. From your review: the class 'Mixin' is still
there as the idea was to imitate the use of 'TempdirManager' as is
used in the rest of the tests and test what it's documentation says.
Just let me know your
Éric Araujo mer...@netwok.org added the comment:
Follow the link titled “review” on the right of your patch in the list of files
above the messages.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12659
Éric Araujo mer...@netwok.org added the comment:
I made a review on Rietveld; a mail should have been sent.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12659
___
Francisco Martín Brugué franci...@email.de added the comment:
I've started with test for “fake_dec” and “TempdirManager”. Please let me know
if that in the line you want.
Thanks in advance
Francis
--
keywords: +patch
nosy: +francismb
Added file:
Changes by shane moore dstor...@gmail.com:
--
nosy: +shane.moore
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12659
___
___
Python-bugs-list
New submission from Éric Araujo mer...@netwok.org:
Packaging’s test support module should have tests.
Using the “easy” keyword because I’m willing to review and commit partial
patches by new contributors instead of waiting for one complete patch.
--
assignee: tarek
components:
24 matches
Mail list logo
