[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: Backported to distutils2 as 5e49c9bc43eb. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue12785] list_distinfo_file is wrong

Changes by Éric Araujo : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue12785] list_distinfo_file is wrong

Roundup Robot added the comment: New changeset c6d52971dd2a by Éric Araujo in branch 'default': Fix packaging.database.Distribution.list_distinfo_files (#12785). http://hg.python.org/cpython/rev/c6d52971dd2a -- nosy: +python-dev ___ Python tracker <

[issue12785] list_distinfo_file is wrong

Jeremy Kloth added the comment: The attached patch seems to work as-is. That is, just testing for `self.path` as the prefix. On Windows, at least, the paths in RECORD are always absolute. Further changes will be necessary, of course, once changes for alternative paths (--prefix, --home, and

[issue12785] list_distinfo_file is wrong

Changes by Éric Araujo : Removed file: http://bugs.python.org/file23065/fix-list_distinfo_files-2.diff ___ Python tracker ___ ___ Python-bugs-

[issue12785] list_distinfo_file is wrong

Changes by Éric Araujo : Removed file: http://bugs.python.org/file22948/fix-list_distinfo_files.diff ___ Python tracker ___ ___ Python-bugs-li

[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: I have added tests to make sure the return value (depending on the local parameter) is correct. Please test when you have a free slot. If it fails, the usual line after the XXX comment should be deleted and the test re-run. -- Added file: http://bugs.p

[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: > I've tested the attached patch against 3.3 on Windows XP, and it > seems to fix the test_database failures. Thanks. > I've uploaded the exact diff of what I tested with. Your diff matches the one I get after updating my clone, we’re good. > I tested both with a

[issue12785] list_distinfo_file is wrong

Nadeem Vawda added the comment: I've tested the attached patch against 3.3 on Windows XP, and it seems to fix the test_database failures. There were some merge conflicts when I applied the patch (because some of the docstring and comment changes had already been committed in fixes from the other

[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: The tests using build_ext now pass \o/ I would love for someone with Windows and a 3.3 clone to test this patch (and if it does not fix, try with the two lines mentioned in msg142773 removed). -- ___ Python tracker

[issue12785] list_distinfo_file is wrong

Nadeem Vawda added the comment: > These are unrelated, I’m only interested in test_database for this patch. I see. I'll re-run the tests this evening, and see whether that failure crops up. -- ___ Python tracker

[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: Ahem, I read your message too fast. > With the patch applied, I still get failures in test_old_record_extensions > and test_record_basic, so it doesn't seem to work. These are unrelated, I’m only interested in test_database for this patch. -- ___

[issue12785] list_distinfo_file is wrong

Éric Araujo added the comment: Thanks. Can you test again after removing these two lines: # XXX see first if we need to convert at all prefix = self.path -- ___ Python tracker ___

[issue12785] list_distinfo_file is wrong

Nadeem Vawda added the comment: With the patch applied, I still get failures in test_old_record_extensions and test_record_basic, so it doesn't seem to work. -- nosy: +nadeem.vawda ___ Python tracker _

[issue12785] list_distinfo_file is wrong

Changes by Éric Araujo : -- keywords: +patch Added file: http://bugs.python.org/file22948/fix-list_distinfo_files.diff ___ Python tracker ___

[issue12785] list_distinfo_file is wrong

New submission from Éric Araujo : The list_distinfo_files method does not fulfills its mission. I changed the test file to be more stupid (and therefore not use high-level functions that we can’t trust) when building the expected list and discovered that list_distinfo_files returned too many