Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 3c9ddd93c983 by Antoine Pitrou in branch '3.2':
Issue #12856: Ensure child processes do not inherit the parent's random seed
for filename generation in the tempfile module.
Antoine Pitrou pit...@free.fr added the comment:
Patch committed, thank you!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12856
Charles-François Natali neolo...@free.fr added the comment:
The patch looks good to me.
Note that the whole kill(pid, SIGKILL) looks overkill to me...
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12856
Ferringb ferri...@gmail.com added the comment:
Bleh; pardon, reuploading the patch. hg export aparently appends to the output
file rather than overwriting it (last patch had duplicated content in it).
--
Added file:
New submission from Ferringb ferri...@gmail.com:
Roughly; tempfile's uniqueness is derived from a global random instance; while
there are protections for thread access, a forked child process /will/ inherit
that PRNG source, resulting in children/parent trying the same set of names.
Mostly
Changes by Ferringb ferri...@gmail.com:
Removed file:
http://bugs.python.org/file23066/unique-seed-per-process-tempfile.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12856
___
Antoine Pitrou pit...@free.fr added the comment:
Interesting, thank you.
Two nits:
- the test must be skipped where os.fork() isn't available (namely, under
Windows)
- I would do os.read(fd, 100) (or some other large value) rather than
os.read(fd, 6), so that the test doesn't depend on the
Ferringb ferri...@gmail.com added the comment:
the test must be skipped where os.fork() isn't available (namely, under
Windows)
Done, although I still humbly suggest telling windows to bugger off ;)
I would do os.read(fd, 100) (or some other large value) rather than
os.read(fd, 6), so
